diff mbox

[2/4] i2c: meson: reduce timeout

Message ID 20171126164057.27728-3-b.galvani@gmail.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Beniamino Galvani Nov. 26, 2017, 4:40 p.m. UTC 
The datasheet doesn't specify a suggested timeout and 500ms seems very
long: reduce it to 100ms.

Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
---
 drivers/i2c/meson_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Nov. 27, 2017, 5:09 p.m. UTC | #1 
On 26 November 2017 at 09:40, Beniamino Galvani <b.galvani@gmail.com> wrote:
> The datasheet doesn't specify a suggested timeout and 500ms seems very
> long: reduce it to 100ms.
>
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
>  drivers/i2c/meson_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Heiko Schocher Dec. 7, 2017, 8:24 a.m. UTC | #2 
Hello Beniamino,

Am 26.11.2017 um 17:40 schrieb Beniamino Galvani:
> The datasheet doesn't specify a suggested timeout and 500ms seems very
> long: reduce it to 100ms.
> 
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
>   drivers/i2c/meson_i2c.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
Heiko Schocher Dec. 7, 2017, 12:19 p.m. UTC | #3 
Hello Beniamino,

Am 26.11.2017 um 17:40 schrieb Beniamino Galvani:
> The datasheet doesn't specify a suggested timeout and 500ms seems very
> long: reduce it to 100ms.
> 
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
>   drivers/i2c/meson_i2c.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-i2c master

Thanks!

bye,
Heiko
diff mbox

Patch

diff --git a/drivers/i2c/meson_i2c.c b/drivers/i2c/meson_i2c.c
index 2434d9ed53..84e1997c76 100644
--- a/drivers/i2c/meson_i2c.c
+++ b/drivers/i2c/meson_i2c.c
@@ -9,7 +9,7 @@ 
 #include <dm.h>
 #include <i2c.h>
 
-#define I2C_TIMEOUT_MS		500
+#define I2C_TIMEOUT_MS		100
 
 /* Control register fields */
 #define REG_CTRL_START		BIT(0)