| Message ID | 20180704224511.29350-3-yixun.lan@amlogic.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Yixun, On Wed, Jul 4, 2018 at 4:49 PM Yixun Lan <yixun.lan@amlogic.com> wrote: > > Document the pins for Amlogic's Meson-G12A SoC. I suggest to combine patch 1 (adding the compatible string) and 2 (this one) as discussed in the cover letter: it would be great if you could add a comment (at least to the commit message) stating that GPIOE is actually located (checked with the ASIC / hardware team) in the AO bank > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> with that: Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > include/dt-bindings/gpio/meson-g12a-gpio.h | 114 +++++++++++++++++++++ > 1 file changed, 114 insertions(+) > create mode 100644 include/dt-bindings/gpio/meson-g12a-gpio.h > > diff --git a/include/dt-bindings/gpio/meson-g12a-gpio.h b/include/dt-bindings/gpio/meson-g12a-gpio.h > new file mode 100644 > index 000000000000..f7bd69350d18 > --- /dev/null > +++ b/include/dt-bindings/gpio/meson-g12a-gpio.h > @@ -0,0 +1,114 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */ > +/* > + * Copyright (c) 2018 Amlogic, Inc. All rights reserved. > + * Author: Xingyu Chen <xingyu.chen@amlogic.com> (since I'm not sure about all the licensing bits:) do we also need a "Signed-off-by" from Xingyu Chen? Regards Martin
HI Martin thanks for the comments On 07/14/2018 10:47 PM, Martin Blumenstingl wrote: > Hi Yixun, > > On Wed, Jul 4, 2018 at 4:49 PM Yixun Lan <yixun.lan@amlogic.com> wrote: >> >> Document the pins for Amlogic's Meson-G12A SoC. > I suggest to combine patch 1 (adding the compatible string) and 2 (this one) > > as discussed in the cover letter: it would be great if you could add a > comment (at least to the commit message) stating that GPIOE is > actually located (checked with the ASIC / hardware team) in the AO > bank > sure, I will state this in commit message, and will also put a note in code. >> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> > with that: > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > thanks, I assume I can add your Ack to this whole patch series (dt-binding patch and pinctrl driver patch)? >> --- >> include/dt-bindings/gpio/meson-g12a-gpio.h | 114 +++++++++++++++++++++ >> 1 file changed, 114 insertions(+) >> create mode 100644 include/dt-bindings/gpio/meson-g12a-gpio.h >> >> diff --git a/include/dt-bindings/gpio/meson-g12a-gpio.h b/include/dt-bindings/gpio/meson-g12a-gpio.h >> new file mode 100644 >> index 000000000000..f7bd69350d18 >> --- /dev/null >> +++ b/include/dt-bindings/gpio/meson-g12a-gpio.h >> @@ -0,0 +1,114 @@ >> +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */ >> +/* >> + * Copyright (c) 2018 Amlogic, Inc. All rights reserved. >> + * Author: Xingyu Chen <xingyu.chen@amlogic.com> > (since I'm not sure about all the licensing bits:) do we also need a > "Signed-off-by" from Xingyu Chen? > sure, this pinctrl driver is mostly Xingyu's work, I will add this. > > Regards > Martin > > . >
diff --git a/include/dt-bindings/gpio/meson-g12a-gpio.h b/include/dt-bindings/gpio/meson-g12a-gpio.h new file mode 100644 index 000000000000..f7bd69350d18 --- /dev/null +++ b/include/dt-bindings/gpio/meson-g12a-gpio.h @@ -0,0 +1,114 @@ +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */ +/* + * Copyright (c) 2018 Amlogic, Inc. All rights reserved. + * Author: Xingyu Chen <xingyu.chen@amlogic.com> + */ + +#ifndef _DT_BINDINGS_MESON_G12A_GPIO_H +#define _DT_BINDINGS_MESON_G12A_GPIO_H + +/* First GPIO chip */ +#define GPIOAO_0 0 +#define GPIOAO_1 1 +#define GPIOAO_2 2 +#define GPIOAO_3 3 +#define GPIOAO_4 4 +#define GPIOAO_5 5 +#define GPIOAO_6 6 +#define GPIOAO_7 7 +#define GPIOAO_8 8 +#define GPIOAO_9 9 +#define GPIOAO_10 10 +#define GPIOAO_11 11 +#define GPIOE_0 12 +#define GPIOE_1 13 +#define GPIOE_2 14 + +/* Second GPIO chip */ +#define GPIOZ_0 0 +#define GPIOZ_1 1 +#define GPIOZ_2 2 +#define GPIOZ_3 3 +#define GPIOZ_4 4 +#define GPIOZ_5 5 +#define GPIOZ_6 6 +#define GPIOZ_7 7 +#define GPIOZ_8 8 +#define GPIOZ_9 9 +#define GPIOZ_10 10 +#define GPIOZ_11 11 +#define GPIOZ_12 12 +#define GPIOZ_13 13 +#define GPIOZ_14 14 +#define GPIOZ_15 15 +#define GPIOH_0 16 +#define GPIOH_1 17 +#define GPIOH_2 18 +#define GPIOH_3 19 +#define GPIOH_4 20 +#define GPIOH_5 21 +#define GPIOH_6 22 +#define GPIOH_7 23 +#define GPIOH_8 24 +#define BOOT_0 25 +#define BOOT_1 26 +#define BOOT_2 27 +#define BOOT_3 28 +#define BOOT_4 29 +#define BOOT_5 30 +#define BOOT_6 31 +#define BOOT_7 32 +#define BOOT_8 33 +#define BOOT_9 34 +#define BOOT_10 35 +#define BOOT_11 36 +#define BOOT_12 37 +#define BOOT_13 38 +#define BOOT_14 39 +#define BOOT_15 40 +#define GPIOC_0 41 +#define GPIOC_1 42 +#define GPIOC_2 43 +#define GPIOC_3 44 +#define GPIOC_4 45 +#define GPIOC_5 46 +#define GPIOC_6 47 +#define GPIOC_7 48 +#define GPIOA_0 49 +#define GPIOA_1 50 +#define GPIOA_2 51 +#define GPIOA_3 52 +#define GPIOA_4 53 +#define GPIOA_5 54 +#define GPIOA_6 55 +#define GPIOA_7 56 +#define GPIOA_8 57 +#define GPIOA_9 58 +#define GPIOA_10 59 +#define GPIOA_11 60 +#define GPIOA_12 61 +#define GPIOA_13 62 +#define GPIOA_14 63 +#define GPIOA_15 64 +#define GPIOX_0 65 +#define GPIOX_1 66 +#define GPIOX_2 67 +#define GPIOX_3 68 +#define GPIOX_4 69 +#define GPIOX_5 70 +#define GPIOX_6 71 +#define GPIOX_7 72 +#define GPIOX_8 73 +#define GPIOX_9 74 +#define GPIOX_10 75 +#define GPIOX_11 76 +#define GPIOX_12 77 +#define GPIOX_13 78 +#define GPIOX_14 79 +#define GPIOX_15 80 +#define GPIOX_16 81 +#define GPIOX_17 82 +#define GPIOX_18 83 +#define GPIOX_19 84 + +#endif /* _DT_BINDINGS_MESON_G12A_GPIO_H */
Document the pins for Amlogic's Meson-G12A SoC. Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> --- include/dt-bindings/gpio/meson-g12a-gpio.h | 114 +++++++++++++++++++++ 1 file changed, 114 insertions(+) create mode 100644 include/dt-bindings/gpio/meson-g12a-gpio.h