| Message ID | 20190617111718.2277220-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/3] media: meson: include linux/kthread.h | expand |
Hello Arnd, On Mon, Jun 17, 2019 at 1:17 PM Arnd Bergmann <arnd@arndb.de> wrote: > > Without this header, we get a compilation error in some configurations: > > drivers/staging/media/meson/vdec/vdec.c: In function 'vdec_recycle_thread': > drivers/staging/media/meson/vdec/vdec.c:59:10: error: implicit declaration of function 'kthread_should_stop' [-Werror=implicit-function-declaration] > > Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/staging/media/meson/vdec/vdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c > index 0a1a04fd5d13..eb335a0f2bdd 100644 > --- a/drivers/staging/media/meson/vdec/vdec.c > +++ b/drivers/staging/media/meson/vdec/vdec.c > @@ -8,6 +8,7 @@ > #include <linux/clk.h> > #include <linux/io.h> > #include <linux/module.h> > +#include <linux/kthread.h> > #include <linux/platform_device.h> > #include <linux/mfd/syscon.h> > #include <linux/slab.h> > -- > 2.20.0 > Thanks for the patch, a similar one has already been sent by Yue Haibing and is sitting in media/master at the moment [0]. My apologies for this oversight. Regards, Maxime [0] https://git.linuxtv.org/media_tree.git/commit/?id=3510c68d32bf3a188c077b5fb87339379f4e6b43
diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c index 0a1a04fd5d13..eb335a0f2bdd 100644 --- a/drivers/staging/media/meson/vdec/vdec.c +++ b/drivers/staging/media/meson/vdec/vdec.c @@ -8,6 +8,7 @@ #include <linux/clk.h> #include <linux/io.h> #include <linux/module.h> +#include <linux/kthread.h> #include <linux/platform_device.h> #include <linux/mfd/syscon.h> #include <linux/slab.h>
Without this header, we get a compilation error in some configurations: drivers/staging/media/meson/vdec/vdec.c: In function 'vdec_recycle_thread': drivers/staging/media/meson/vdec/vdec.c:59:10: error: implicit declaration of function 'kthread_should_stop' [-Werror=implicit-function-declaration] Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/media/meson/vdec/vdec.c | 1 + 1 file changed, 1 insertion(+)