From patchwork Fri Apr 3 09:13:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tang Bin X-Patchwork-Id: 11472219 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AB0C5913 for ; Fri, 3 Apr 2020 09:12:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8921D20737 for ; Fri, 3 Apr 2020 09:12:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JOZ0ggcC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8921D20737 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cmss.chinamobile.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=XRgkQJxEabavn38aV/mwSmj8a0KvwdGlKfK159/gXVc=; b=JOZ0ggcC0Sdx7L h+48AwEspXCVfuQJ5twsXuxglxSnsH5/lM+BeZ8JlmhZYbz+5kXqro6oxtRpofh8uhtIPmlJFxWdd jAHmG5dykCgDfPryWN/AfvVULTJnTXy74mSwuUsFQH9ICqqHs0Do9JMqQSzf40Y71jo/4Jck5eKiP aYOKN1+TfuVm/CezrDXqYkuKMaBjTNes6bjk47Fw971JpV3DhlfziN8il/yv8WLIihwucU4zyKD14 yuRESAETLzhx9yhMgBxfZtbI+X66fVazAU4H9YUZUazMeJisnO6nqDST949cbdPmjVSJ5s+vq0A5O mpB4H6BQxg7EzBxyIWag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKINN-0004XG-9Q; Fri, 03 Apr 2020 09:12:33 +0000 Received: from cmccmta3.chinamobile.com ([221.176.66.81]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKINK-0004W7-LW for linux-amlogic@lists.infradead.org; Fri, 03 Apr 2020 09:12:32 +0000 Received: from spf.mail.chinamobile.com (unknown[172.16.121.7]) by rmmx-syy-dmz-app10-12010 (RichMail) with SMTP id 2eea5e86fde4b05-74c43; Fri, 03 Apr 2020 17:12:04 +0800 (CST) X-RM-TRANSID: 2eea5e86fde4b05-74c43 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.25.154.146]) by rmsmtp-syy-appsvr04-12004 (RichMail) with SMTP id 2ee45e86fde287d-479a0; Fri, 03 Apr 2020 17:12:04 +0800 (CST) X-RM-TRANSID: 2ee45e86fde287d-479a0 From: Tang Bin To: narmstrong@baylibre.com, clabbe@baylibre.com, herbert@gondor.apana.org.au, davem@davemloft.net Subject: [PATCH v4]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe() Date: Fri, 3 Apr 2020 17:13:32 +0800 Message-Id: <20200403091332.12100-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200403_021231_188146_A0FE50A2 X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [221.176.66.81 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, Tang Bin , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org When something goes wrong, platform_get_irq() will print an error message, so in order to avoid the situation of repeat output，we should remove dev_err here. Changes form v3: - fix the theme writing error. Changes from v2: - modify the theme format and content description. - reformat the patch, it's the wrong way to resubmit a new patch that should be modified on top of the original. The original piece is: https://lore.kernel.org/patchwork/patch/1219611/ Changes from v1: - the title has changed, because the description is not very detailed. - the code has been modified, because it needs to match the theme. Signed-off-by: Tang Bin --- drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c index 37901bd81..c2fa442c5 100644 --- a/drivers/crypto/amlogic/amlogic-gxl-core.c +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c @@ -253,10 +253,8 @@ static int meson_crypto_probe(struct platform_device *pdev) mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL); for (i = 0; i < MAXFLOW; i++) { mc->irqs[i] = platform_get_irq_optional(pdev, i); - if (mc->irqs[i] < 0) { - dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i); + if (mc->irqs[i] < 0) return mc->irqs[i]; - } err = devm_request_irq(&pdev->dev, mc->irqs[i], meson_irq_handler, 0, "gxl-crypto", mc);