| Message ID | 20200925033017.1790973-2-art@khadas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dts updates and fixes for Khadas VIM1 VIM2 VIM3 VIML boards | expand |
On 25/09/2020 05:30, Artem Lapkin wrote: > 1) The VIM2 Boards use w25q128 spi chip only not w25q32 or w25q16 > it's not really seriously becouse have 'jedec,spi-nor' which > have auto chips identifications > > 2) max-frequency is 104Mhz > > Signed-off-by: Artem Lapkin <art@khadas.com> > --- > arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts > index bff8ec2c1c7..a6baf865aa2 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts > @@ -336,12 +336,12 @@ &spifc { > pinctrl-0 = <&nor_pins>; > pinctrl-names = "default"; > > - w25q32: spi-flash@0 { > + w25q128: spi-flash@0 { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "winbond,w25q16", "jedec,spi-nor"; > + compatible = "winbond,w25q128fw", "jedec,spi-nor"; > reg = <0>; > - spi-max-frequency = <3000000>; > + spi-max-frequency = <104000000>; > }; > }; > > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Hi Artem, On Fri, Sep 25, 2020 at 5:30 AM Artem Lapkin <email2tema@gmail.com> wrote: > > 1) The VIM2 Boards use w25q128 spi chip only not w25q32 or w25q16 > it's not really seriously becouse have 'jedec,spi-nor' which > have auto chips identifications according to the "VIM2 - Transitioning From v1.2 to v1.4" document [0] (page 7) both board revisions are using different SPI flash sizes for which board revision are your changes? > 2) max-frequency is 104Mhz (note to self: according to the w25q16 datasheet it supports a maximum clock frequency of 104MHz, so this is fine) Best regards, Martin
On 25/09/2020 09:51, Martin Blumenstingl wrote: > Hi Artem, > > On Fri, Sep 25, 2020 at 5:30 AM Artem Lapkin <email2tema@gmail.com> wrote: >> >> 1) The VIM2 Boards use w25q128 spi chip only not w25q32 or w25q16 >> it's not really seriously becouse have 'jedec,spi-nor' which >> have auto chips identifications > according to the "VIM2 - Transitioning From v1.2 to v1.4" document [0] > (page 7) both board revisions are using different SPI flash sizes > for which board revision are your changes? Indeed, if you changed the flash for the v14 VIM2 board, please: - move arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts into meson-gxm-khadas-vim2.dtsi leaving only the root compatible, model and the v12 spi flash model&size into the meson-gxm-khadas-vim2.dts file - add "khadas,vim2-v14" to amlogic board bindings - introduce a arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2-v14.dts file adding the changes (spi flash change, MCU) with a different root compatible & model Neil > >> 2) max-frequency is 104Mhz > (note to self: according to the w25q16 datasheet it supports a maximum > clock frequency of 104MHz, so this is fine) > > > Best regards, > Martin >
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts index bff8ec2c1c7..a6baf865aa2 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts @@ -336,12 +336,12 @@ &spifc { pinctrl-0 = <&nor_pins>; pinctrl-names = "default"; - w25q32: spi-flash@0 { + w25q128: spi-flash@0 { #address-cells = <1>; #size-cells = <1>; - compatible = "winbond,w25q16", "jedec,spi-nor"; + compatible = "winbond,w25q128fw", "jedec,spi-nor"; reg = <0>; - spi-max-frequency = <3000000>; + spi-max-frequency = <104000000>; }; };
1) The VIM2 Boards use w25q128 spi chip only not w25q32 or w25q16 it's not really seriously becouse have 'jedec,spi-nor' which have auto chips identifications 2) max-frequency is 104Mhz Signed-off-by: Artem Lapkin <art@khadas.com> --- arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)