| Message ID | 20200925033017.1790973-5-art@khadas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dts updates and fixes for Khadas VIM1 VIM2 VIM3 VIML boards | expand |
Hi Artem, On Fri, Sep 25, 2020 at 5:31 AM Artem Lapkin <email2tema@gmail.com> wrote: > > no need force setup memory size! > VIM3 boards have 2Gb and 4Gb variants > memory size will be automatically defined > > mainline uboot works properly in any case > but old vendor uboot works not properly for 4Gb variants can you be more specific with what "does not work properly"? is Linux then only able to use 2GB or is there any other problem? overall this sounds like a bug in the vendor u-boot to me I don't see that we have any other Amlogic .dts which needs this hack, so I'd like to hear the feedback from the device-tree maintainers (for example Rob) as well Best regards, Martin
On 25/09/2020 09:37, Martin Blumenstingl wrote: > Hi Artem, > > On Fri, Sep 25, 2020 at 5:31 AM Artem Lapkin <email2tema@gmail.com> wrote: >> >> no need force setup memory size! >> VIM3 boards have 2Gb and 4Gb variants >> memory size will be automatically defined >> >> mainline uboot works properly in any case >> but old vendor uboot works not properly for 4Gb variants > can you be more specific with what "does not work properly"? is Linux > then only able to use 2GB or is there any other problem? > > overall this sounds like a bug in the vendor u-boot to me > I don't see that we have any other Amlogic .dts which needs this hack, > so I'd like to hear the feedback from the device-tree maintainers (for > example Rob) as well AFAIK the vendor u-boot updates the memory correctly, what it doesn't is adding the reserved memory zones. Neil > > > Best regards, > Martin >
diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi index 7e137399257..3111bf35c0f 100644 --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi @@ -20,10 +20,15 @@ chosen { stdout-path = "serial0:115200n8"; }; +/* no need force setup memory size! + VIM3 boards have 2Gb and 4Gb variants + memory size will be automatically defined + memory@0 { device_type = "memory"; reg = <0x0 0x0 0x0 0x80000000>; }; +*/ adc-keys { compatible = "adc-keys";
no need force setup memory size! VIM3 boards have 2Gb and 4Gb variants memory size will be automatically defined mainline uboot works properly in any case but old vendor uboot works not properly for 4Gb variants Signed-off-by: Artem Lapkin <art@khadas.com> --- arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 5 +++++ 1 file changed, 5 insertions(+)