| Message ID | 20210520073136.272925-1-jbrunet@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Neil Armstrong |
| Headers | show |
| Series | clk: meson: axg-audio: improve deferral handling | expand |
On Thu, May 20, 2021 at 9:32 AM Jerome Brunet <jbrunet@baylibre.com> wrote: > > Use dev_err_probe() for clock and reset resources to indicate the deferral > reason through sysfs when waiting for the resource to come up. > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
On Thu 20 May 2021 at 22:18, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > On Thu, May 20, 2021 at 9:32 AM Jerome Brunet <jbrunet@baylibre.com> wrote: >> >> Use dev_err_probe() for clock and reset resources to indicate the deferral >> reason through sysfs when waiting for the resource to come up. >> >> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Applied
Quoting Jerome Brunet (2021-05-20 00:31:36) > Use dev_err_probe() for clock and reset resources to indicate the deferral > reason through sysfs when waiting for the resource to come up. > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c index 7c8d02164443..bfe36bd41339 100644 --- a/drivers/clk/meson/axg-audio.c +++ b/drivers/clk/meson/axg-audio.c @@ -1665,8 +1665,7 @@ static int devm_clk_get_enable(struct device *dev, char *id) clk = devm_clk_get(dev, id); if (IS_ERR(clk)) { ret = PTR_ERR(clk); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get %s", id); + dev_err_probe(dev, ret, "failed to get %s", id); return ret; } @@ -1811,7 +1810,7 @@ static int axg_audio_clkc_probe(struct platform_device *pdev) ret = device_reset(dev); if (ret) { - dev_err(dev, "failed to reset device\n"); + dev_err_probe(dev, ret, "failed to reset device\n"); return ret; }
Use dev_err_probe() for clock and reset resources to indicate the deferral reason through sysfs when waiting for the resource to come up. Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- This is a follow up on https://lore.kernel.org/r/20210429090516.61085-1-jbrunet@baylibre.com drivers/clk/meson/axg-audio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)