Message ID | 20220210100638.19130-2-christianshewitt@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | arm64: dts: meson: remove CPU opps below 1GHz for G12B/SM1 | expand |
On 10/02/2022 11:06, Christian Hewitt wrote: > Amlogic G12B devices experience CPU stalls and random board wedges when > the system idles and CPU cores clock down to lower opp points. Recent > vendor kernels include a change to remove 100-250MHz and other distro > sources also remove the 500/667MHz points. Unless all 100-667Mhz opps > are removed or the CPU governor forced to performance stalls are still > observed, so let's remove them to improve stability and uptime. > > Fixes: b96d4e92709b ("arm64: dts: meson-g12b: support a311d and s922x cpu operating points") > Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> > --- > .../boot/dts/amlogic/meson-g12b-a311d.dtsi | 40 ------------------- > .../boot/dts/amlogic/meson-g12b-s922x.dtsi | 40 ------------------- > 2 files changed, 80 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi > index d61f43052a34..8e9ad1e51d66 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi > @@ -11,26 +11,6 @@ > compatible = "operating-points-v2"; > opp-shared; > > - opp-100000000 { > - opp-hz = /bits/ 64 <100000000>; > - opp-microvolt = <731000>; > - }; > - > - opp-250000000 { > - opp-hz = /bits/ 64 <250000000>; > - opp-microvolt = <731000>; > - }; > - > - opp-500000000 { > - opp-hz = /bits/ 64 <500000000>; > - opp-microvolt = <731000>; > - }; > - > - opp-667000000 { > - opp-hz = /bits/ 64 <667000000>; > - opp-microvolt = <731000>; > - }; > - > opp-1000000000 { > opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <761000>; > @@ -71,26 +51,6 @@ > compatible = "operating-points-v2"; > opp-shared; > > - opp-100000000 { > - opp-hz = /bits/ 64 <100000000>; > - opp-microvolt = <731000>; > - }; > - > - opp-250000000 { > - opp-hz = /bits/ 64 <250000000>; > - opp-microvolt = <731000>; > - }; > - > - opp-500000000 { > - opp-hz = /bits/ 64 <500000000>; > - opp-microvolt = <731000>; > - }; > - > - opp-667000000 { > - opp-hz = /bits/ 64 <667000000>; > - opp-microvolt = <731000>; > - }; > - > opp-1000000000 { > opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <731000>; > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi > index 1e5d0ee5d541..44c23c984034 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi > @@ -11,26 +11,6 @@ > compatible = "operating-points-v2"; > opp-shared; > > - opp-100000000 { > - opp-hz = /bits/ 64 <100000000>; > - opp-microvolt = <731000>; > - }; > - > - opp-250000000 { > - opp-hz = /bits/ 64 <250000000>; > - opp-microvolt = <731000>; > - }; > - > - opp-500000000 { > - opp-hz = /bits/ 64 <500000000>; > - opp-microvolt = <731000>; > - }; > - > - opp-667000000 { > - opp-hz = /bits/ 64 <667000000>; > - opp-microvolt = <731000>; > - }; > - > opp-1000000000 { > opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <731000>; > @@ -76,26 +56,6 @@ > compatible = "operating-points-v2"; > opp-shared; > > - opp-100000000 { > - opp-hz = /bits/ 64 <100000000>; > - opp-microvolt = <751000>; > - }; > - > - opp-250000000 { > - opp-hz = /bits/ 64 <250000000>; > - opp-microvolt = <751000>; > - }; > - > - opp-500000000 { > - opp-hz = /bits/ 64 <500000000>; > - opp-microvolt = <751000>; > - }; > - > - opp-667000000 { > - opp-hz = /bits/ 64 <667000000>; > - opp-microvolt = <751000>; > - }; > - > opp-1000000000 { > opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <771000>; Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi index d61f43052a34..8e9ad1e51d66 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi @@ -11,26 +11,6 @@ compatible = "operating-points-v2"; opp-shared; - opp-100000000 { - opp-hz = /bits/ 64 <100000000>; - opp-microvolt = <731000>; - }; - - opp-250000000 { - opp-hz = /bits/ 64 <250000000>; - opp-microvolt = <731000>; - }; - - opp-500000000 { - opp-hz = /bits/ 64 <500000000>; - opp-microvolt = <731000>; - }; - - opp-667000000 { - opp-hz = /bits/ 64 <667000000>; - opp-microvolt = <731000>; - }; - opp-1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <761000>; @@ -71,26 +51,6 @@ compatible = "operating-points-v2"; opp-shared; - opp-100000000 { - opp-hz = /bits/ 64 <100000000>; - opp-microvolt = <731000>; - }; - - opp-250000000 { - opp-hz = /bits/ 64 <250000000>; - opp-microvolt = <731000>; - }; - - opp-500000000 { - opp-hz = /bits/ 64 <500000000>; - opp-microvolt = <731000>; - }; - - opp-667000000 { - opp-hz = /bits/ 64 <667000000>; - opp-microvolt = <731000>; - }; - opp-1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <731000>; diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi index 1e5d0ee5d541..44c23c984034 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi @@ -11,26 +11,6 @@ compatible = "operating-points-v2"; opp-shared; - opp-100000000 { - opp-hz = /bits/ 64 <100000000>; - opp-microvolt = <731000>; - }; - - opp-250000000 { - opp-hz = /bits/ 64 <250000000>; - opp-microvolt = <731000>; - }; - - opp-500000000 { - opp-hz = /bits/ 64 <500000000>; - opp-microvolt = <731000>; - }; - - opp-667000000 { - opp-hz = /bits/ 64 <667000000>; - opp-microvolt = <731000>; - }; - opp-1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <731000>; @@ -76,26 +56,6 @@ compatible = "operating-points-v2"; opp-shared; - opp-100000000 { - opp-hz = /bits/ 64 <100000000>; - opp-microvolt = <751000>; - }; - - opp-250000000 { - opp-hz = /bits/ 64 <250000000>; - opp-microvolt = <751000>; - }; - - opp-500000000 { - opp-hz = /bits/ 64 <500000000>; - opp-microvolt = <751000>; - }; - - opp-667000000 { - opp-hz = /bits/ 64 <667000000>; - opp-microvolt = <751000>; - }; - opp-1000000000 { opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <771000>;
Amlogic G12B devices experience CPU stalls and random board wedges when the system idles and CPU cores clock down to lower opp points. Recent vendor kernels include a change to remove 100-250MHz and other distro sources also remove the 500/667MHz points. Unless all 100-667Mhz opps are removed or the CPU governor forced to performance stalls are still observed, so let's remove them to improve stability and uptime. Fixes: b96d4e92709b ("arm64: dts: meson-g12b: support a311d and s922x cpu operating points") Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> --- .../boot/dts/amlogic/meson-g12b-a311d.dtsi | 40 ------------------- .../boot/dts/amlogic/meson-g12b-s922x.dtsi | 40 ------------------- 2 files changed, 80 deletions(-)