| Message ID | 20220310074059.12269-1-hanyihao@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: meson-ir-tx: fix platform_get_irq.cocci warning | expand |
On 10/03/2022 08:40, Yihao Han wrote: > Remove dev_err() messages after platform_get_irq*() failures. > platform_get_irq() already prints an error. > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > > Signed-off-by: Yihao Han <hanyihao@vivo.com> > --- > drivers/media/rc/meson-ir-tx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/rc/meson-ir-tx.c b/drivers/media/rc/meson-ir-tx.c > index 63e1dbf0a4e9..abdb62b16e98 100644 > --- a/drivers/media/rc/meson-ir-tx.c > +++ b/drivers/media/rc/meson-ir-tx.c > @@ -323,10 +323,8 @@ static int __init meson_irtx_probe(struct platform_device *pdev) > return PTR_ERR(ir->reg_base); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "no irq resource found\n"); > + if (irq < 0) > return -ENODEV; > - } > > ir->dev = dev; > ir->carrier = MIRTX_DEFAULT_CARRIER; Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
diff --git a/drivers/media/rc/meson-ir-tx.c b/drivers/media/rc/meson-ir-tx.c index 63e1dbf0a4e9..abdb62b16e98 100644 --- a/drivers/media/rc/meson-ir-tx.c +++ b/drivers/media/rc/meson-ir-tx.c @@ -323,10 +323,8 @@ static int __init meson_irtx_probe(struct platform_device *pdev) return PTR_ERR(ir->reg_base); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "no irq resource found\n"); + if (irq < 0) return -ENODEV; - } ir->dev = dev; ir->carrier = MIRTX_DEFAULT_CARRIER;
Remove dev_err() messages after platform_get_irq*() failures. platform_get_irq() already prints an error. Generated by: scripts/coccinelle/api/platform_get_irq.cocci Signed-off-by: Yihao Han <hanyihao@vivo.com> --- drivers/media/rc/meson-ir-tx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)