diff mbox series

[v2,2/2] arm64: dts: meson-sm1-sei610: Remove 'enable-active-low'

Message ID 20220827203813.1742715-2-festevam@denx.de (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] arm64: dts: meson-g12a: Remove 'enable-active-low' | expand

Commit Message

Fabio Estevam Aug. 27, 2022, 8:38 p.m. UTC
The 'enable-active-low' property is not a valid one. 

Only 'enable-active-high' is valid, and when this property is absent
the gpio regulator will act as active low by default.

Remove the invalid 'enable-active-low' property.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
Changes since v1:
- Put linux-amlogic on Cc and added Martin's Reviewed-by tag.

 arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 1 -
 1 file changed, 1 deletion(-)

Comments

Neil Armstrong Aug. 29, 2022, 7:37 a.m. UTC | #1
On 27/08/2022 22:38, Fabio Estevam wrote:
> The 'enable-active-low' property is not a valid one.
> 
> Only 'enable-active-high' is valid, and when this property is absent
> the gpio regulator will act as active low by default.
> 
> Remove the invalid 'enable-active-low' property.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> Changes since v1:
> - Put linux-amlogic on Cc and added Martin's Reviewed-by tag.
> 
>   arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> index 603337ca5608..9068a334ea57 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> @@ -171,7 +171,6 @@ vddao_3v3_t: regulator-vddao_3v3_t {
>   		regulator-max-microvolt = <3300000>;
>   		vin-supply = <&vddao_3v3>;
>   		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
> -		enable-active-low;
>   		regulator-always-on;
>   	};
>   

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
index 603337ca5608..9068a334ea57 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
@@ -171,7 +171,6 @@  vddao_3v3_t: regulator-vddao_3v3_t {
 		regulator-max-microvolt = <3300000>;
 		vin-supply = <&vddao_3v3>;
 		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
-		enable-active-low;
 		regulator-always-on;
 	};