| Message ID | 20220922040807.1409540-1-weiyongjun@huaweicloud.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static | expand |
On 22/09/2022 06:08, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > The sparse tool complains as follows: > > drivers/spi/spi-meson-spicc.c:570:22: warning: > symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static? > > This symbol is not used outside of spi-meson-spicc.c, so marks it static. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/spi/spi-meson-spicc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c > index e4cb52e1fe26..85b4b9b267b1 100644 > --- a/drivers/spi/spi-meson-spicc.c > +++ b/drivers/spi/spi-meson-spicc.c > @@ -567,7 +567,7 @@ static int meson_spicc_pow2_set_rate(struct clk_hw *hw, unsigned long rate, > return clk_divider_ops.set_rate(hw, rate, parent_rate); > } > > -const struct clk_ops meson_spicc_pow2_clk_ops = { > +static const struct clk_ops meson_spicc_pow2_clk_ops = { > .recalc_rate = meson_spicc_pow2_recalc_rate, > .determine_rate = meson_spicc_pow2_determine_rate, > .set_rate = meson_spicc_pow2_set_rate, > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Thu, 22 Sep 2022 04:08:07 +0000, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > The sparse tool complains as follows: > > drivers/spi/spi-meson-spicc.c:570:22: warning: > symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static? > > [...] Applied to broonie/spi.git for-next Thanks! [1/1] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static commit: 077dac343b54babfd56b1a52cf1f091518118957 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index e4cb52e1fe26..85b4b9b267b1 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -567,7 +567,7 @@ static int meson_spicc_pow2_set_rate(struct clk_hw *hw, unsigned long rate, return clk_divider_ops.set_rate(hw, rate, parent_rate); } -const struct clk_ops meson_spicc_pow2_clk_ops = { +static const struct clk_ops meson_spicc_pow2_clk_ops = { .recalc_rate = meson_spicc_pow2_recalc_rate, .determine_rate = meson_spicc_pow2_determine_rate, .set_rate = meson_spicc_pow2_set_rate,