diff mbox series

[v2,1/2] drm/tiny: rpi-lcd-35: Enable driver module autoloading

Message ID 20221116-s905x_spi_ili9486-v2-1-084c6e3cd930@baylibre.com (mailing list archive)
State Superseded
Delegated to: Neil Armstrong
Headers show
Series Make ILI9486 driver working with 16-bits SPI controllers | expand

Commit Message

Carlo Caione Nov. 21, 2022, 9:42 a.m. UTC
SPI devices use the spi_device_id for module autoloading even on
systems using device tree.

Add the spi_device_id entry to enable autoloading for the 3.5inch RPi
Display (rpi-lcd-35).

Signed-off-by: Carlo Caione <ccaione@baylibre.com>
---
 drivers/gpu/drm/tiny/ili9486.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Neil Armstrong Nov. 29, 2022, 8:38 a.m. UTC | #1
On 21/11/2022 10:42, Carlo Caione wrote:
> SPI devices use the spi_device_id for module autoloading even on
> systems using device tree.
> 
> Add the spi_device_id entry to enable autoloading for the 3.5inch RPi
> Display (rpi-lcd-35).
> 
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
>   drivers/gpu/drm/tiny/ili9486.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
> index 1bb847466b10..bd37dfe8dd05 100644
> --- a/drivers/gpu/drm/tiny/ili9486.c
> +++ b/drivers/gpu/drm/tiny/ili9486.c
> @@ -183,6 +183,7 @@ MODULE_DEVICE_TABLE(of, ili9486_of_match);
>   
>   static const struct spi_device_id ili9486_id[] = {
>   	{ "ili9486", 0 },
> +	{ "rpi-lcd-35", 0 },

It should also contain "piscreen" then.

Anyway:

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

>   	{ }
>   };
>   MODULE_DEVICE_TABLE(spi, ili9486_id);
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
index 1bb847466b10..bd37dfe8dd05 100644
--- a/drivers/gpu/drm/tiny/ili9486.c
+++ b/drivers/gpu/drm/tiny/ili9486.c
@@ -183,6 +183,7 @@  MODULE_DEVICE_TABLE(of, ili9486_of_match);
 
 static const struct spi_device_id ili9486_id[] = {
 	{ "ili9486", 0 },
+	{ "rpi-lcd-35", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ili9486_id);