| Message ID | 20221201225703.6507-9-ddrokosov@sberdevices.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | add Amlogic A1 clock controller drivers | expand |
On 01/12/2022 23:57, Dmitry Rokosov wrote: > During running dtbs_check and dt_binding_check checkers the following > problems were found and resolved: > - $id is not correct, it has wrong url path > - CLKIDs aren't applied by names, just magic int constants there > - address and size cells are required for long reg definition > - wrong indentations > > Also this patch adds new A1 clk controllers dt bindings to MAINTAINERS. > > Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru> > --- > .../bindings/clock/amlogic,a1-pll-clkc.yaml | 27 ++++++++++++------- > MAINTAINERS | 1 + > 2 files changed, 18 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml > index d67250fbeece..83f98a73c04e 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml > +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > %YAML 1.2 > --- > -$id: "http://devicetree.org/schemas/amlogic,a1-pll-clkc.yaml#" > +$id: "http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml#" > $schema: "http://devicetree.org/meta-schemas/core.yaml#" > > title: Amlogic Meson A/C serials PLL Clock Control Unit Device Tree Bindings NAK. This must be squashed. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml index d67250fbeece..83f98a73c04e 100644 --- a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: "http://devicetree.org/schemas/amlogic,a1-pll-clkc.yaml#" +$id: "http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml#" $schema: "http://devicetree.org/meta-schemas/core.yaml#" title: Amlogic Meson A/C serials PLL Clock Control Unit Device Tree Bindings @@ -10,6 +10,7 @@ maintainers: - Neil Armstrong <narmstrong@baylibre.com> - Jerome Brunet <jbrunet@baylibre.com> - Jian Hu <jian.hu@jian.hu.com> + - Dmitry Rokosov <ddrokosov@sberdevices.ru> properties: compatible: @@ -23,8 +24,8 @@ properties: clocks: items: - - description: input xtal_fixpll - - description: input xtal_hifipll + - description: input xtal_fixpll + - description: input xtal_hifipll clock-names: items: @@ -42,11 +43,17 @@ additionalProperties: false examples: - | - clkc_pll: pll-clock-controller@7c80 { - compatible = "amlogic,a1-pll-clkc"; - reg = <0 0x7c80 0 0x18c>; - #clock-cells = <1>; - clocks = <&clkc_periphs 1>, - <&clkc_periphs 4>; - clock-names = "xtal_fixpll", "xtal_hifipll"; + #include <dt-bindings/clock/a1-clkc.h> + apb { + #address-cells = <2>; + #size-cells = <2>; + + clkc_pll: pll-clock-controller@7c80 { + compatible = "amlogic,a1-pll-clkc"; + reg = <0 0x7c80 0 0x18c>; + #clock-cells = <1>; + clocks = <&clkc_periphs CLKID_XTAL_FIXPLL>, + <&clkc_periphs CLKID_XTAL_HIFIPLL>; + clock-names = "xtal_fixpll", "xtal_hifipll"; + }; }; diff --git a/MAINTAINERS b/MAINTAINERS index e04d944005ba..a02d81edeb4b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1837,6 +1837,7 @@ L: linux-amlogic@lists.infradead.org S: Maintained F: Documentation/devicetree/bindings/clock/amlogic* F: drivers/clk/meson/ +F: include/dt-bindings/clock/a1* F: include/dt-bindings/clock/gxbb* F: include/dt-bindings/clock/meson*
During running dtbs_check and dt_binding_check checkers the following problems were found and resolved: - $id is not correct, it has wrong url path - CLKIDs aren't applied by names, just magic int constants there - address and size cells are required for long reg definition - wrong indentations Also this patch adds new A1 clk controllers dt bindings to MAINTAINERS. Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru> --- .../bindings/clock/amlogic,a1-pll-clkc.yaml | 27 ++++++++++++------- MAINTAINERS | 1 + 2 files changed, 18 insertions(+), 10 deletions(-)