| Message ID | 20221205151845.21618-9-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: dt-bindings: common CEC properties | expand |
On Mon, 05 Dec 2022 16:18:44 +0100, Krzysztof Kozlowski wrote: > Convert Nvidia Tegra HDMI CEC bindings to DT schema. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> > --- > .../bindings/media/cec/nvidia,tegra-cec.yaml | 58 +++++++++++++++++++ > .../devicetree/bindings/media/tegra-cec.txt | 27 --------- > MAINTAINERS | 2 +- > 3 files changed, 59 insertions(+), 28 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml > delete mode 100644 Documentation/devicetree/bindings/media/tegra-cec.txt > Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, Dec 05, 2022 at 04:18:44PM +0100, Krzysztof Kozlowski wrote: > Convert Nvidia Tegra HDMI CEC bindings to DT schema. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> > --- > .../bindings/media/cec/nvidia,tegra-cec.yaml | 58 +++++++++++++++++++ > .../devicetree/bindings/media/tegra-cec.txt | 27 --------- > MAINTAINERS | 2 +- > 3 files changed, 59 insertions(+), 28 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml > delete mode 100644 Documentation/devicetree/bindings/media/tegra-cec.txt > > diff --git a/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml b/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml > new file mode 100644 > index 000000000000..9a4025ff7fad > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml For consistency with other DT bindings on Tegra, it'd be good to name this nvidia,tegra114-cec.yaml since that's the first generation where this IP was added. Not a big deal, though. > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/cec/nvidia,tegra-cec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nvidia Tegra HDMI CEC Again, for consistency with other bindings, NVIDIA is the preferred spelling. It's not a big deal and could be fixed up in a subsequent patch, there are a few other cases where the alternative spelling has been used. The rest looks okay, so either way: Acked-by: Thierry Reding <treding@nvidia.com>
On 06/12/2022 17:36, Thierry Reding wrote: > On Mon, Dec 05, 2022 at 04:18:44PM +0100, Krzysztof Kozlowski wrote: >> Convert Nvidia Tegra HDMI CEC bindings to DT schema. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> >> --- >> .../bindings/media/cec/nvidia,tegra-cec.yaml | 58 +++++++++++++++++++ >> .../devicetree/bindings/media/tegra-cec.txt | 27 --------- >> MAINTAINERS | 2 +- >> 3 files changed, 59 insertions(+), 28 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml >> delete mode 100644 Documentation/devicetree/bindings/media/tegra-cec.txt >> >> diff --git a/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml b/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml >> new file mode 100644 >> index 000000000000..9a4025ff7fad >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml > > For consistency with other DT bindings on Tegra, it'd be good to name > this nvidia,tegra114-cec.yaml since that's the first generation where > this IP was added. Not a big deal, though. Sure, I can rename it. > >> @@ -0,0 +1,58 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/cec/nvidia,tegra-cec.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Nvidia Tegra HDMI CEC > > Again, for consistency with other bindings, NVIDIA is the preferred > spelling. It's not a big deal and could be fixed up in a subsequent > patch, there are a few other cases where the alternative spelling has > been used. > > The rest looks okay, so either way: > > Acked-by: Thierry Reding <treding@nvidia.com> OK Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml b/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml new file mode 100644 index 000000000000..9a4025ff7fad --- /dev/null +++ b/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/cec/nvidia,tegra-cec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nvidia Tegra HDMI CEC + +maintainers: + - Hans Verkuil <hverkuil-cisco@xs4all.nl> + +allOf: + - $ref: cec-common.yaml# + +properties: + compatible: + enum: + - nvidia,tegra114-cec + - nvidia,tegra124-cec + - nvidia,tegra210-cec + + clocks: + maxItems: 1 + + clock-names: + items: + - const: cec + + interrupts: + maxItems: 1 + + reg: + maxItems: 1 + +required: + - compatible + - clocks + - clock-names + - hdmi-phandle + - interrupts + - reg + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/tegra124-car.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + cec@70015000 { + compatible = "nvidia,tegra124-cec"; + reg = <0x70015000 0x00001000>; + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&tegra_car TEGRA124_CLK_CEC>; + clock-names = "cec"; + status = "disabled"; + hdmi-phandle = <&hdmi>; + }; diff --git a/Documentation/devicetree/bindings/media/tegra-cec.txt b/Documentation/devicetree/bindings/media/tegra-cec.txt deleted file mode 100644 index c503f06f3b84..000000000000 --- a/Documentation/devicetree/bindings/media/tegra-cec.txt +++ /dev/null @@ -1,27 +0,0 @@ -* Tegra HDMI CEC hardware - -The HDMI CEC module is present in Tegra SoCs and its purpose is to -handle communication between HDMI connected devices over the CEC bus. - -Required properties: - - compatible : value should be one of the following: - "nvidia,tegra114-cec" - "nvidia,tegra124-cec" - "nvidia,tegra210-cec" - - reg : Physical base address of the IP registers and length of memory - mapped region. - - interrupts : HDMI CEC interrupt number to the CPU. - - clocks : from common clock binding: handle to HDMI CEC clock. - - clock-names : from common clock binding: must contain "cec", - corresponding to the entry in the clocks property. - - hdmi-phandle : phandle to the HDMI controller, see also cec.txt. - -Example: - -cec@70015000 { - compatible = "nvidia,tegra124-cec"; - reg = <0x0 0x70015000 0x0 0x00001000>; - interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&tegra_car TEGRA124_CLK_CEC>; - clock-names = "cec"; -}; diff --git a/MAINTAINERS b/MAINTAINERS index 197351d3bb57..dee3f776be32 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2999,7 +2999,7 @@ M: Hans Verkuil <hverkuil-cisco@xs4all.nl> L: linux-tegra@vger.kernel.org L: linux-media@vger.kernel.org S: Maintained -F: Documentation/devicetree/bindings/media/tegra-cec.txt +F: Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml F: drivers/media/cec/platform/tegra/ ARM/TESLA FSD SoC SUPPORT