| Message ID | 20230327211351.686831-2-mmkurbanov@sberdevices.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | add support for Meson A1 SPI Flash Controller | expand |
On Tue, 28 Mar 2023 00:13:50 +0300, Martin Kurbanov wrote: > Add YAML devicetree Amlogic Meson A113L (A1 family) SPIFC Driver. > > This patch has dependencies on the A1 clock series which is still under > review - https://lore.kernel.org/all/20230321193014.26349-1-ddrokosov@sberdevices.ru/ > > Signed-off-by: Martin Kurbanov <mmkurbanov@sberdevices.ru> > --- > .../bindings/spi/amlogic,meson-a1-spifc.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.example.dts:18:18: fatal error: dt-bindings/clock/amlogic,a1-clkc.h: No such file or directory 18 | #include <dt-bindings/clock/amlogic,a1-clkc.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1512: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230327211351.686831-2-mmkurbanov@sberdevices.ru The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 27/03/2023 23:13, Martin Kurbanov wrote: > Add YAML devicetree Amlogic Meson A113L (A1 family) SPIFC Driver. Don't add drivers to DT bindings. > > This patch has dependencies on the A1 clock series which is still under > review - https://lore.kernel.org/all/20230321193014.26349-1-ddrokosov@sberdevices.ru/ This is not part of commit msg. > > Signed-off-by: Martin Kurbanov <mmkurbanov@sberdevices.ru> > --- > .../bindings/spi/amlogic,meson-a1-spifc.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.yaml > Best regards, Krzysztof
Hi, On 27/03/2023 23:13, Martin Kurbanov wrote: > Add YAML devicetree Amlogic Meson A113L (A1 family) SPIFC Driver. > > This patch has dependencies on the A1 clock series which is still under > review - https://lore.kernel.org/all/20230321193014.26349-1-ddrokosov@sberdevices.ru/ > > Signed-off-by: Martin Kurbanov <mmkurbanov@sberdevices.ru> > --- > .../bindings/spi/amlogic,meson-a1-spifc.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.yaml I think it's time to drop "Meson" from bindings, please drop Meson here and in all the file down to the compatible which should be "amlogic,a1-spifc" > > diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.yaml > new file mode 100644 > index 000000000000..d2b1c754a6e1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/amlogic,meson-a1-spifc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Meson A1 SPI Flash Controller > + > +maintainers: > + - Martin Kurbanov <mmkurbanov@sberdevices.ru> > + > +allOf: > + - $ref: spi-controller.yaml# > + > +properties: > + compatible: > + enum: > + - amlogic,meson-a1-spifc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/amlogic,a1-clkc.h> > + spi@fd000400 { > + compatible = "amlogic,meson-a1-spifc"; > + reg = <0xfd000400 0x290>; > + clocks = <&clkc_periphs CLKID_SPIFC>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; Drop the include and use fake label phandles instead. Thanks, Neil
diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.yaml new file mode 100644 index 000000000000..d2b1c754a6e1 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/amlogic,meson-a1-spifc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic Meson A1 SPI Flash Controller + +maintainers: + - Martin Kurbanov <mmkurbanov@sberdevices.ru> + +allOf: + - $ref: spi-controller.yaml# + +properties: + compatible: + enum: + - amlogic,meson-a1-spifc + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - clocks + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/amlogic,a1-clkc.h> + spi@fd000400 { + compatible = "amlogic,meson-a1-spifc"; + reg = <0xfd000400 0x290>; + clocks = <&clkc_periphs CLKID_SPIFC>; + #address-cells = <1>; + #size-cells = <0>; + };
Add YAML devicetree Amlogic Meson A113L (A1 family) SPIFC Driver. This patch has dependencies on the A1 clock series which is still under review - https://lore.kernel.org/all/20230321193014.26349-1-ddrokosov@sberdevices.ru/ Signed-off-by: Martin Kurbanov <mmkurbanov@sberdevices.ru> --- .../bindings/spi/amlogic,meson-a1-spifc.yaml | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/amlogic,meson-a1-spifc.yaml