From patchwork Sat Apr 1 16:19:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13197150 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79A38C77B62 for ; Sat, 1 Apr 2023 16:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=twIxhr69QXe5JRg99pVlnNtPoY8sSBud21dbji3+ufI=; b=J1A2u8brMM/bZj MGtj14QevwPekRb/57LOWEOrPJhzqwGQbpMxzmhqi1R7yLWk+o1a3EVi4C8aJ1NXXb5+k0waZ85DA xQHA2i1CHV5XZCndTfacj6SSdq6qZ7dsM9nGskwDN0ld1ZfhXu6ycemsue7jcbvYSPV6NpFLbZWsO i/N9RxdfzVglXgj+6nfqBGYYFRJ+iRBmeL3j2Oki4rd6ErmiPu30k36Y8+8yReCJfO4GU+QpCvI4R PABgXvsNfm8oyceffLJ9RkfWyPh1wqDCQYjCdbkr9sK2bJTSLEcq59WjghZBC3SUlFqBNdCE5dH0K sMNRgBp1SkGAVzsJ+QvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEI-00AwTE-1A; Sat, 01 Apr 2023 16:37:26 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEG-00AwRk-1r for linux-amlogic@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=DLAmKykExcbO0JzUBYJlHYgvFIZhTW7HXMdbM8jxP00=; b=Je30Q56fqMRzqYrd5PuIFvvddW wdxyg2sLfJCxIlIqHnKs4npUACVWulzqcOI+f1erxQVm2Yj4DOykugWVWLWcYsenP0Z/C2iKTdz5H cuxAbaDO0LkcSFkCljWcYdTIvJjqR43oJUNFQ4OUBiSu4Faes+oDeY2pwk4uE9o0SaBqTyDJz1dei xUNrMQazQFW+Du8pAyPBZ8eNf3lO75e5JjmtcFoThmZC6odFFw2x+f5HdlPPujVJAxnwIJbf7laZB EIay6ZPXyEzvk1OZTuWn/Gp26jY65F4jnfAaG5wlC5w7Q1aB3bJhVKqTMWjxCV7jmUCnEUbqjKIO4 ZpSfUvQA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxZ-00CYOW-F6 for linux-amlogic@lists.infradead.org; Sat, 01 Apr 2023 16:20:15 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxJ-0008N9-PW; Sat, 01 Apr 2023 18:19:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxI-008GRc-La; Sat, 01 Apr 2023 18:19:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxH-009kgc-G9; Sat, 01 Apr 2023 18:19:51 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liang Yang , Miquel Raynal , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman Cc: Richard Weinberger , Jerome Brunet , Martin Blumenstingl , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 25/49] mtd: rawnand: meson: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:14 +0200 Message-Id: <20230401161938.2503204-26-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1569; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=1PHui4ayscbjWOMu4Uq3reeTu+VKa/h2YMHVa3mMo4E=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhSNSNUOl7hP66SrrV2+lljt0Hb/xmVvatC+pN1NjO/oN tNZatqdjMYsDIxcDLJiiiz2jWsyrarkIjvX/rsMM4iVCWQKAxenAEykNYODoX17UEXF9pg3/Xa7 L92WelVlb8fmtq7FvPwTT3hqtXx2nHjAUu81ve3b7l4WzJt0xSRgUeTN/5vZeC4s2PmiMHWV0fb Q185bPpiJpbPWveUL8Qk2fryksHr/wV6tuBqt2WfktWPUdxXUtZ1W6TfaK5F3umXWzNlHX5wteb m8o6AgjH/Ru4Uuc4zsKmNTTVdv2SnxNu5W7NyXJ7eWtU+f+eaWdPpJ1efH5GUOzJE8njfxfUd85 5SC6gmbWzrK8nfrlNipGYequ6yUTdw5e/aG/PAol3V2Rd8Kqk5xrRDLt9qk9zVTPf+i1SaHMu9l z3o/O63+/SnGIj+bNfrunmSu1rl3N8cHn1xT9EZC518vAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-amlogic@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172009_531363_32B6CF36 X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Martin Blumenstingl --- drivers/mtd/nand/raw/meson_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c index 5ee01231ac4c..24f1ad025cda 100644 --- a/drivers/mtd/nand/raw/meson_nand.c +++ b/drivers/mtd/nand/raw/meson_nand.c @@ -1434,20 +1434,18 @@ static int meson_nfc_probe(struct platform_device *pdev) return ret; } -static int meson_nfc_remove(struct platform_device *pdev) +static void meson_nfc_remove(struct platform_device *pdev) { struct meson_nfc *nfc = platform_get_drvdata(pdev); meson_nfc_nand_chip_cleanup(nfc); meson_nfc_disable_clk(nfc); - - return 0; } static struct platform_driver meson_nfc_driver = { .probe = meson_nfc_probe, - .remove = meson_nfc_remove, + .remove_new = meson_nfc_remove, .driver = { .name = "meson-nand", .of_match_table = meson_nfc_id_table,