diff mbox series

reset: meson: remove unneeded call to platform_set_drvdata()

Message ID 20230807105400.11560-1-aboutphysycs@gmail.com (mailing list archive)
State New, archived
Headers show
Series reset: meson: remove unneeded call to platform_set_drvdata() | expand

Commit Message

Andrei Coardos Aug. 7, 2023, 10:54 a.m. UTC 
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/reset/reset-meson.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Philipp Zabel Aug. 8, 2023, 1:47 p.m. UTC | #1 
On Mo, 2023-08-07 at 13:54 +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
> 
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>

Thank you, applied to reset/next.

regards
Philipp
diff mbox series

Patch

diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
index 13878ca2779d..e35c3364e722 100644
--- a/drivers/reset/reset-meson.c
+++ b/drivers/reset/reset-meson.c
@@ -129,8 +129,6 @@  static int meson_reset_probe(struct platform_device *pdev)
 	if (!data->param)
 		return -ENODEV;
 
-	platform_set_drvdata(pdev, data);
-
 	spin_lock_init(&data->lock);
 
 	data->rcdev.owner = THIS_MODULE;