From patchwork Wed Sep 27 19:37:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13401559 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C8C9E82CC3 for ; Wed, 27 Sep 2023 19:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bsP7J5H/W0u5d0yK95pLK+neDX5bI+sJnmExM5q80G0=; b=4bsR+R9AjCdUm0 VQXCGVkyLpU807U9c/34/uRtuXaD9FroxbBmyKVcjwZzd9GrBbHPWiwnfm+y5nJNafRRfSv1onUk5 MNKX70rhBV14FHGHAELdnMxdA+RfJBTwWbao8sfhqkNAuCK2bEsjr1CnjfuZZkqNKFjFhIPJbsbV4 JnOMn1meoEShNR0ZXgI9fgc82srdQCpKfbFiZgf/KWsID6BDdqzSHUMk6HSwIBzBGzbH+W+nWNb1N GI7hZXc/CZBa3YjDBWLhYHoCFAMf34GHyzE3DRvenGmiCtYAFoq8nDsGdDmh4n7LQjgkYtaXZH/G+ +PiRWXtprMPVbvRVpBWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlaMB-001fJc-2g; Wed, 27 Sep 2023 19:37:59 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qlaM8-001fHV-2i for linux-amlogic@lists.infradead.org; Wed, 27 Sep 2023 19:37:58 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qlaLt-00026h-H9; Wed, 27 Sep 2023 21:37:41 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlaLs-009PZC-RF; Wed, 27 Sep 2023 21:37:40 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qlaLs-005RfO-Ht; Wed, 27 Sep 2023 21:37:40 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: "Rafael J. Wysocki" , Daniel Lezcano Cc: Guillaume La Roque , Amit Kucheria , Zhang Rui , linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 01/31] thermal: amlogic: Convert to platform remove callback returning void Date: Wed, 27 Sep 2023 21:37:06 +0200 Message-Id: <20230927193736.2236447-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230927193736.2236447-1-u.kleine-koenig@pengutronix.de> References: <20230927193736.2236447-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2461; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=KxL8aBbxeG861TkwND8mWyXQYKx1VJQ+ig1ZgxFPaLE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlFIRalZDbOoWWsVvgInsGRLaQoIOvEjn79XJqE Owea3jLoz+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRSEWgAKCRCPgPtYfRL+ Tui2CACKbQGRijUIxoCyJCojT3AqP+lOQDd9LzPQ/2t6lYKyiESE/O/CO7WzHbxyWh7XJWr0FpG 3SQS5HOXhfVXGggOqdQSdEERNpKZgdp+6m8KMbejXJwM3DZJdsvTOrF69Gq4akfa7onMCP/XfsW RyqQ0axmobLx7Ez7vKVFWK1eR9zgyjCC4daAytV1Wyc/YzecAB4a0Kw5wDPcdzF+XDHKAenZa4R X/GvYke2HN/ffw4f1OgiRtkdkDo9DVuOk3CWN0vxFIH3E0BAthid87UZImtjwuVtnrydzWDAyL8 1ACUuqRXEazp9lD2/dFtqKj1Ga0t0H5Jp+EIMr3JwATUfF4h X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-amlogic@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230927_123756_890602_99905AA4 X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). amlogic_thermal_disable() always returned zero. Change it to return no value and then trivially convert the driver to .remove_new() and fix a whitespace inconsitency en passant. Signed-off-by: Uwe Kleine-König --- drivers/thermal/amlogic_thermal.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c index 81ebbf6de0de..1426f1eb4ac6 100644 --- a/drivers/thermal/amlogic_thermal.c +++ b/drivers/thermal/amlogic_thermal.c @@ -167,13 +167,11 @@ static int amlogic_thermal_enable(struct amlogic_thermal *data) return 0; } -static int amlogic_thermal_disable(struct amlogic_thermal *data) +static void amlogic_thermal_disable(struct amlogic_thermal *data) { regmap_update_bits(data->regmap, TSENSOR_CFG_REG1, TSENSOR_CFG_REG1_ENABLE, 0); clk_disable_unprepare(data->clk); - - return 0; } static int amlogic_thermal_get_temp(struct thermal_zone_device *tz, int *temp) @@ -291,11 +289,11 @@ static int amlogic_thermal_probe(struct platform_device *pdev) return ret; } -static int amlogic_thermal_remove(struct platform_device *pdev) +static void amlogic_thermal_remove(struct platform_device *pdev) { struct amlogic_thermal *data = platform_get_drvdata(pdev); - return amlogic_thermal_disable(data); + amlogic_thermal_disable(data); } static int __maybe_unused amlogic_thermal_suspend(struct device *dev) @@ -321,8 +319,8 @@ static struct platform_driver amlogic_thermal_driver = { .pm = &amlogic_thermal_pm_ops, .of_match_table = of_amlogic_thermal_match, }, - .probe = amlogic_thermal_probe, - .remove = amlogic_thermal_remove, + .probe = amlogic_thermal_probe, + .remove_new = amlogic_thermal_remove, }; module_platform_driver(amlogic_thermal_driver);