| Message ID | 20240124130623.3471236-1-avromanov@salutedevices.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] arch: arm64: dts: meson: a1: add assigned-clocks for usb node | expand |
Hello! Ping. On Wed, Jan 24, 2024 at 04:06:23PM +0300, Alexey Romanov wrote: > To ensure proper functionality of USB, it is necessary to use > the rate of 64000000 for CLKID_USB_BUS. For instance, adb may > not function correctly without this setting. This information > has been derived from the vendor SDK. > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index cf150f568335..b9fd69112535 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -668,6 +668,8 @@ usb: usb@fe004400 { > <&clkc_periphs CLKID_USB_BUS>, > <&clkc_periphs CLKID_USB_CTRL_IN>; > clock-names = "usb_ctrl", "usb_bus", "xtal_usb_ctrl"; > + assigned-clocks = <&clkc_periphs CLKID_USB_BUS>; > + assigned-clock-rates = <64000000>; > resets = <&reset RESET_USBCTRL>; > reset-name = "usb_ctrl"; > > -- > 2.34.1 >
On 24/01/2024 14:06, Alexey Romanov wrote: > To ensure proper functionality of USB, it is necessary to use > the rate of 64000000 for CLKID_USB_BUS. For instance, adb may > not function correctly without this setting. This information > has been derived from the vendor SDK. > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index cf150f568335..b9fd69112535 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -668,6 +668,8 @@ usb: usb@fe004400 { > <&clkc_periphs CLKID_USB_BUS>, > <&clkc_periphs CLKID_USB_CTRL_IN>; > clock-names = "usb_ctrl", "usb_bus", "xtal_usb_ctrl"; > + assigned-clocks = <&clkc_periphs CLKID_USB_BUS>; > + assigned-clock-rates = <64000000>; > resets = <&reset RESET_USBCTRL>; > reset-name = "usb_ctrl"; > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Hi, On Wed, 24 Jan 2024 16:06:23 +0300, Alexey Romanov wrote: > To ensure proper functionality of USB, it is necessary to use > the rate of 64000000 for CLKID_USB_BUS. For instance, adb may > not function correctly without this setting. This information > has been derived from the vendor SDK. > > Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.9/arm64-dt) [1/1] arch: arm64: dts: meson: a1: add assigned-clocks for usb node https://git.kernel.org/amlogic/c/d1159418fbd5880d3285f4797d3f11eeaf6d0d42 These changes has been applied on the intermediate git tree [1]. The v6.9/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers for inclusion in their intermediate git branches in order to be sent to Linus during the next merge window, or sooner if it's a set of fixes. In the cases of fixes, those will be merged in the current release candidate kernel and as soon they appear on the Linux master branch they will be backported to the previous Stable and Long-Stable kernels [2]. The intermediate git branches are merged daily in the linux-next tree [3], people are encouraged testing these pre-release kernels and report issues on the relevant mailing-lists. If problems are discovered on those changes, please submit a signed-off-by revert patch followed by a corrective changeset. [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi index cf150f568335..b9fd69112535 100644 --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi @@ -668,6 +668,8 @@ usb: usb@fe004400 { <&clkc_periphs CLKID_USB_BUS>, <&clkc_periphs CLKID_USB_CTRL_IN>; clock-names = "usb_ctrl", "usb_bus", "xtal_usb_ctrl"; + assigned-clocks = <&clkc_periphs CLKID_USB_BUS>; + assigned-clock-rates = <64000000>; resets = <&reset RESET_USBCTRL>; reset-name = "usb_ctrl";