diff mbox series

[3/4] dt-bindings: thermal: amlogic,thermal: add power-domains

Message ID 20240708194808.1819185-4-gnstark@salutedevices.com (mailing list archive)
State Superseded
Headers show
Series amlogic SoC's power-domains fixes | expand

Commit Message

George Stark July 8, 2024, 7:48 p.m. UTC
On newer SoCs, the thermal hardware can require a power domain to
operate so add corresponding property as optional by default and as
required for Meson A1 due to it's temperature sensor has dedicated
power domain.

Signed-off-by: George Stark <gnstark@salutedevices.com>
---
 .../bindings/thermal/amlogic,thermal.yaml          | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Krzysztof Kozlowski July 8, 2024, 7:52 p.m. UTC | #1
On 08/07/2024 21:48, George Stark wrote:
> On newer SoCs, the thermal hardware can require a power domain to
> operate so add corresponding property as optional by default and as
> required for Meson A1 due to it's temperature sensor has dedicated
> power domain.
> 

That's again ABI break with a reason "there is power domain", so not
really sufficient.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
index 01fccdfc4178..5c9147e3b734 100644
--- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
@@ -30,6 +30,9 @@  properties:
   clocks:
     maxItems: 1
 
+  power-domains:
+    maxItems: 1
+
   amlogic,ao-secure:
     description: phandle to the ao-secure syscon
     $ref: /schemas/types.yaml#/definitions/phandle
@@ -44,6 +47,17 @@  required:
   - clocks
   - amlogic,ao-secure
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - amlogic,a1-cpu-thermal
+    then:
+      required:
+        - power-domains
+
 additionalProperties: false
 
 examples: