| Message ID | 20241007-topic-amlogic-arm32-upstream-bindings-fixes-meson8-pinctrl-v1-1-d3d838540033@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: pinctrl: amlogic,meson8-pinctrl-cbus/aobus: add reg for cbus/aobus pinctrl nodes | expand |
On Mon, 07 Oct 2024 16:16:25 +0200, Neil Armstrong wrote: > While converting the Amlogic Meson pinctrl binding to dt-schema, the mandatory > reg property for Meson8/b aobus pinctrl node was ommited, fix this to finally > pass all bindings checks. > > Fixes: 94df03a45276 ("dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding") > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../pinctrl/amlogic,meson8-pinctrl-aobus.yaml | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/amlogic,meson8-pinctrl-aobus.example.dtb: pinctrl: 'reg' is a required property from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-aobus.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241007-topic-amlogic-arm32-upstream-bindings-fixes-meson8-pinctrl-v1-1-d3d838540033@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 07/10/2024 18:02, Rob Herring (Arm) wrote: > > On Mon, 07 Oct 2024 16:16:25 +0200, Neil Armstrong wrote: >> While converting the Amlogic Meson pinctrl binding to dt-schema, the mandatory >> reg property for Meson8/b aobus pinctrl node was ommited, fix this to finally >> pass all bindings checks. >> >> Fixes: 94df03a45276 ("dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding") >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> .../pinctrl/amlogic,meson8-pinctrl-aobus.yaml | 22 +++++++++++++++++++--- >> 1 file changed, 19 insertions(+), 3 deletions(-) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/amlogic,meson8-pinctrl-aobus.example.dtb: pinctrl: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-aobus.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241007-topic-amlogic-arm32-upstream-bindings-fixes-meson8-pinctrl-v1-1-d3d838540033@linaro.org > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Right, I thought I tested those bindings, but seems I missed something... Thanks, Neil
diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,meson8-pinctrl-aobus.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,meson8-pinctrl-aobus.yaml index add83c676327..76c02c6af645 100644 --- a/Documentation/devicetree/bindings/pinctrl/amlogic,meson8-pinctrl-aobus.yaml +++ b/Documentation/devicetree/bindings/pinctrl/amlogic,meson8-pinctrl-aobus.yaml @@ -9,9 +9,6 @@ title: Amlogic Meson8 AOBUS pinmux controller maintainers: - Neil Armstrong <neil.armstrong@linaro.org> -allOf: - - $ref: amlogic,meson-pinctrl-common.yaml# - properties: compatible: oneOf: @@ -25,6 +22,25 @@ properties: - const: amlogic,meson8m2-aobus-pinctrl - const: amlogic,meson8-aobus-pinctrl + reg: + maxItems: 1 + +allOf: + - $ref: amlogic,meson-pinctrl-common.yaml# + - if: + properties: + compatible: + contains: + enum: + - amlogic,meson8-aobus-pinctrl + - amlogic,meson8b-aobus-pinctrl + then: + required: + - reg + else: + properties: + reg: false + required: - compatible
While converting the Amlogic Meson pinctrl binding to dt-schema, the mandatory reg property for Meson8/b aobus pinctrl node was ommited, fix this to finally pass all bindings checks. Fixes: 94df03a45276 ("dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding") Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- .../pinctrl/amlogic,meson8-pinctrl-aobus.yaml | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-)