From patchwork Fri Feb 28 14:07:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996451 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78A63C19776 for ; Fri, 28 Feb 2025 14:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bUV1yTqDeHPfV5uD2/nfl0oDY+7MDFc9tsIudcw4Q/E=; b=R08/bKbnm8q4fQ wzj4Wk5mqiXczzZ6IkJELKgdO0Nj0mW3GrGgZaXUMSoeesrToT/JMOUXPab6RHl/2rgTGFtnRNFeb Aa8M7MVMq7wXKcSBFvUn9zZgKuNop1AtkBdRLFbYLsNVyS3SfZA2b30vfiKIRUXDffYRQi+c9pqwX RI+ysZ62MTBjuvl0An9Q8OX2NiYa7tl/Cy/8+mmrHrT29Ts/2uTaXz85Il9xRTpTai6wbF6YZUACg dlvzr+59rnmQlYNLFmu5w3SwqF00Z9SknUKaSplpucN3v24zj95Mnr9lIfjbpZrr92hRz6JYHA0O1 2iiml9roGK2CvQN5EvcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to13D-0000000BBlR-4ABZ; Fri, 28 Feb 2025 14:09:15 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11Q-0000000BB3C-2UFz for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:26 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5e033c2f106so2449561a12.3 for ; Fri, 28 Feb 2025 06:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751643; x=1741356443; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PxV5ubkQILRDTTOOiWiVBaTKuCWcjZ1klG/odToLNLU=; b=GNwV7WePBwGhEVUrY8wkOq3dzITnF6bXyqJEur34Z1CIW6s4R9vz3QrmoEhjsA04eg 7kbBYDcHmMpkZ3JLtdArC03chuByeVy/vLIRGi7eZfpNV70nu6O3sdU6h5YDnemgokMK dT0q24KtC5t2eUsgOPzFWhSPAjNpkjhXEYvoT+g8bNDBoRzfm592WkRpnWNNAxVTPD2d D+5n/qz/PdRNzu6HlbjGIVW08hDsvXXfv2MHhEBVKhDMZSnlGGtlYYnydpY0jp41vELK eEvnZrF7mM8WY5uj2u8cSCmlVzD4DrV2uK+5bWMpLfnz0L4q0zFdGInPZZtEY429l41d HZMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751643; x=1741356443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PxV5ubkQILRDTTOOiWiVBaTKuCWcjZ1klG/odToLNLU=; b=xD5nkP9V6y7OyzaMuuN9fzQKAYiMuNA4zVtTeEhkTPzoi2/LcQU5lLt7nVL4dOWpgw bFPhEMa68iNNbEcaHqCjvsJfDF6cPktVUPUzsIqHK3CwtzjEps7nl24EJmRbofxt47gQ x4/qo/cP3qbDearM1sTKqMuTBdTueKnTUFlQwNYhnRquOG4GgL4Peg0AXULjiTUETiVi KBSA4BqPwtPfn0wwM129O/xaTsxbTuDqTLKElRDMb7pZHNt1HZzrCJ6ZXC1qxCpdRfEO 1AxOahZj/Rf6nR5m0KMJnDH4Dat+9wUY+z8Tq2jWuoYKC4lyPk1u+hutuuGW5qDNUFQM cbgA== X-Forwarded-Encrypted: i=1; AJvYcCVqLfMMibzks1LuzfMcoVkDEhyOKVTRh2yql61kZd1xWVK/Ac+XpFxb38gK7/I1DdkNuaVvWCGsT0nUZzmA@lists.infradead.org X-Gm-Message-State: AOJu0YwUPU8m+W8ta3623aCq8cm2aBMpL0EM7qo3HdOu0+1WfEINFOVW pqmUkiCbjkuIz7PLHU4nnrqxfrrDwWey0492TdJ0uaQRaYTpo9L6C3CnmkTeAg4= X-Gm-Gg: ASbGncskYMl/7ZszHLqRZn3/6MbYxa0+D/HL93nBzH0qOLIlf9T8PGiC1/6VJi+7fTW zvpVK3rM7Yr1lpzsYzkDgn6YnpQGeagFq6n29rJxq0xetf6h7XD6nSAoDowwcjG5Y3GGJfqjpa6 frVj25lZ8jrguEY2bWOphXRQlzX8MEe+K37YD5x45YMHO8xCmUxacOjwIXElcy9h8FnItiCSlSL HRAHVJ+dYp9VBgeTLJf2G/9Ugtu/Ld/N20YgvGVy1T4ybWzGXhpJFl/bL06G4N8nyJcxq36sOaL DNksK0/xMpRFgF9wq+jNYxmurL3nUJrQ6eYfY1TKFAtYfNqhzg8muBdBeeSQ4+BWRvLf006HEkw KqQqUQv22Cg== X-Google-Smtp-Source: AGHT+IFUL7DUuq/VqTU9dmynPShF+8aK2RXF+k+UR0pl4bWqZxWvS8VoSsjq66EWlcydyD7uTG7tww== X-Received: by 2002:a05:6402:1d4d:b0:5dc:796f:fc86 with SMTP id 4fb4d7f45d1cf-5e4d6af436amr7325207a12.16.1740751642551; Fri, 28 Feb 2025 06:07:22 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:21 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:14 +0000 Subject: [PATCH 01/18] rtc: max77686: drop needless struct max77686_rtc_info::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-1-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060724_631262_2A2D1747 X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org When this driver was converted to using the devres managed i2c device in commit 59a7f24fceb3 ("rtc: max77686: convert to devm_i2c_new_dummy_device()"), struct max77686_rtc_info::rtc became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-max77686.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 7bb044d2ac25aeaaf2404b47b7e7bd485ae3d39e..6b0d02b44c8097453f704cbec9f02580fb869ca3 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -85,7 +85,6 @@ struct max77686_rtc_driver_data { struct max77686_rtc_info { struct device *dev; - struct i2c_client *rtc; struct rtc_device *rtc_dev; struct mutex lock; @@ -691,6 +690,7 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) { struct device *parent = info->dev->parent; struct i2c_client *parent_i2c = to_i2c_client(parent); + struct i2c_client *client; int ret; if (info->drv_data->rtc_irq_from_platform) { @@ -714,14 +714,14 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) goto add_rtc_irq; } - info->rtc = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, - info->drv_data->rtc_i2c_addr); - if (IS_ERR(info->rtc)) { + client = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, + info->drv_data->rtc_i2c_addr); + if (IS_ERR(client)) { dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(info->rtc); + return PTR_ERR(client); } - info->rtc_regmap = devm_regmap_init_i2c(info->rtc, + info->rtc_regmap = devm_regmap_init_i2c(client, info->drv_data->regmap_config); if (IS_ERR(info->rtc_regmap)) { ret = PTR_ERR(info->rtc_regmap);