From patchwork Fri Feb 28 14:07:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996509 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7831FC19776 for ; Fri, 28 Feb 2025 14:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HZ9E/tYiSXFAfGwVx4cfk5cQiNGThrehz3hqLTFApNA=; b=YYfBt1gaQ09YCr b2iUIPC/zgQHIOQwy8y/8YRvdA+l0cOE0lNemb3wxWKEei5YkJbqfdDBGJ4VEkOSbnj/0cT0OuXdi KPKaXBezT7Bd5y9qFCsCoh7ffYKMc+cLHqpi9NlC8US05W82GTm3J7+DaUz9bLfgXfnK/ih4h3PpR aMrFZs/jCd/Iq5yNYoFPdDFLcKy3tZwQKcJF+b6C2bwvafW6603pSUy+QLV5T14U14V6Q+ZS0I62r OC2nkF553G8UqkArvxZU30vC+ZmMJyFPWLnsxGBWv8ymPvEchQ5sQWN960IoBJZKQ37ABZ7MbbkAR ITwzEYqwG8S+bDIWkcnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Ld-0000000BGQu-0cX2; Fri, 28 Feb 2025 14:28:17 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11W-0000000BBA6-0kOj for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:31 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5e04064af07so3923190a12.0 for ; Fri, 28 Feb 2025 06:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751649; x=1741356449; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=I2QDvE9wN+g16Z7rKZjQU/K6ZyJAh05OKQtvnHRRZ/NX7Qo60eGE+dm8BKfzrU9iKF H4VtWcTaPRD6eL+CY91buxH7GcwnUrBJZ1sOvxJMOMk8bNMMlsPmkuULMQYZ8SfeDwAh YgMjP+C0daE8bbGNhggoSugyqhKMATjHZjaqz0aakz1z7gaFYEelDwo2P+Hk1MMenrlT BLN9w8ax0XNQ/NJGxcVsK2GrHXMq+tqrqKdG0uHBUg0Ylrs8u4l2Gr/qGb0VWM0hsO1n avp4lz4rxyTa1oxLElHNz+pDNz2jCIaGgtuNpqbUP7228REVsO3bsVrsDOdwKr46u5NJ B/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751649; x=1741356449; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=UD8xjMXcrSjSErYwCVLsyzy8I2+NE48ZuM151Z4gcmXRizGh7itgc3zCskzvmY7eUH pJwU6x5TjK5AB8kZYoRtZU8N4oirHzqfSclk/M79oc0vLr9031p7wK24WtU0tb6ndTft naTihqqIIQAVsum1JFBHdsusFVFlXwi87CQbaqtG+Jcg1kkoXBzYT86ICe6RCTNMvsc4 c4Uvc0lWauZjiKuepNY7D/dRanqMyXrfTuaHL4paoHBpWn0xsRgKSnojqRdcW1N2qndE XqbUFKJw/Vz0SjHuPbfhelIk32l7iTa4YNfwDK3Fx/V/gEAWDTKk6/6D0dCcxfDX2exI mpMg== X-Forwarded-Encrypted: i=1; AJvYcCUh6szUGan2JqewTl5+l65pMLp6BrQ7jYYib4teWA+oQmeDg6QT7uRG+Gze9RYy9vJy36OE2NzCQ4JaxEsc@lists.infradead.org X-Gm-Message-State: AOJu0YyMw7sRp61SQpCXgnDwlMnYu64ErJm+QXHDomo3HO2VQYTyaEvj Q/05aFNN5HDiLZ0eD6UVq56p2yP0ZJKDJl1X7BiUC+DqWfY/kxdNMkYcqZfIZ1c= X-Gm-Gg: ASbGncuYFvm6xsH3AOeR69SnHHrcZfJ6OfsEjIH9/rxlTTl4TbuhDmuwKN283+xZ7r5 kJAnH2JdjxvR6iGwAoAG8xZE8NW7WRLrsxumoRHZGkfXEEptl67IOLJVBmwM+qTIA030PjLFBZp Ei/BGvOtM3Kka+eOqIJPvh0ged3G3FY/FHmFFN/GXqTfvc0RI+44A6b5tuc7YX2VSmiTScYB/1s rm5D5IE88KX29eRh4ier66IHIZq3QNqJLaGxXgXgfrVlSeyj63mOXeU5N1t3hTv2PZ4c9fYYK2W FDv4BEuA5QkAlwVuZ/ds0CPHTbhns4lv5rW6mtRnXT2vhBlMm3NTqedqTA2vO++Gf9MbmEU0KtW 9Ze/2XWx+iA== X-Google-Smtp-Source: AGHT+IF1zdUSX6ZhtbedenD60jZMcHzIIU2NhAe4k+oRQ6Wt3d6uE7nze1qy/Ap2/A6npGSF7Q9PVw== X-Received: by 2002:a05:6402:348a:b0:5d1:f009:925e with SMTP id 4fb4d7f45d1cf-5e4d6b1869bmr2990380a12.16.1740751648743; Fri, 28 Feb 2025 06:07:28 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:25 +0000 Subject: [PATCH 12/18] rtc: s35390a: drop needless struct s35390a::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-12-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060730_216173_7F2CBCC0 X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-s35390a.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c index e3dc18882f41445c41fbea56edbd5c869514880c..3408d2ab274194e39cde38a83567d37bd53f6632 100644 --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -63,7 +63,6 @@ MODULE_DEVICE_TABLE(of, s35390a_of_match); struct s35390a { struct i2c_client *client[8]; - struct rtc_device *rtc; int twentyfourhour; }; @@ -422,6 +421,7 @@ static int s35390a_probe(struct i2c_client *client) int err, err_read; unsigned int i; struct s35390a *s35390a; + struct rtc_device *rtc; char buf, status1; struct device *dev = &client->dev; @@ -447,9 +447,9 @@ static int s35390a_probe(struct i2c_client *client) } } - s35390a->rtc = devm_rtc_allocate_device(dev); - if (IS_ERR(s35390a->rtc)) - return PTR_ERR(s35390a->rtc); + rtc = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); err_read = s35390a_read_status(s35390a, &status1); if (err_read < 0) { @@ -480,17 +480,17 @@ static int s35390a_probe(struct i2c_client *client) device_set_wakeup_capable(dev, 1); - s35390a->rtc->ops = &s35390a_rtc_ops; - s35390a->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - s35390a->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &s35390a_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; - set_bit(RTC_FEATURE_ALARM_RES_MINUTE, s35390a->rtc->features); - clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, s35390a->rtc->features ); + set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features); if (status1 & S35390A_FLAG_INT2) - rtc_update_irq(s35390a->rtc, 1, RTC_AF); + rtc_update_irq(rtc, 1, RTC_AF); - return devm_rtc_register_device(s35390a->rtc); + return devm_rtc_register_device(rtc); } static struct i2c_driver s35390a_driver = {