From patchwork Fri Feb 28 14:07:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996511 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2252C19776 for ; Fri, 28 Feb 2025 14:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JthkRTW1yUhrJAt4EcFWebKqVByFcoFtNeYuyKteFBg=; b=Qe5rE6AQW+SLKR 8BFtWX+1zcA12WTBgvhteDgsS+NocoUHrD0X6QbfEJXH32oHaD270p1I5SoP1TtTQ5F+MbuNC7hCS 5AhSbFTK+vzvJ0XNMmyyDTV7CwxSDlPjnO177ePQY2ZrmntZ6VO9OwpE/2z1B72C8kij9VTCzpxYD LgEnc1TjPlgIm4FlaFsuto0WGz/VMftJ8OawyNDH9z/bLThwQeMFeN7Oz0WSJVKq6TzX+OGT7V20u 3v4bNMQYukuDcG1ukly2jxZ5b8Ypm6ss9ZOlvAuDDGN0VLEN+mcdsSHsoNCcBmLZVvIAUeGFMWani 1nqMSZRp9AJ/FYLZ2iGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1N9-0000000BGe2-2366; Fri, 28 Feb 2025 14:29:51 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11X-0000000BBBe-1YDY for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:32 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5dee07e51aaso3821085a12.3 for ; Fri, 28 Feb 2025 06:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751650; x=1741356450; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wVgVdQhbC2YyNwH7K95+EhEh/kAvax64uDHN7A2amTM=; b=Tbt1ZyYbw0fhZvWj/Jp6/ghf3SHPTn23gLzNSV4wEwbD4MLfoCMmkkjoOMhnXsetx+ p4WxGnqMOt9LaAsXXzXbhW/r7TKvzMiZlxhnOe3cQ0U4/LUH8ulUHahrMp5tNuRunADt u1pclU0GQJ0X/T0tLk/8vlhl/E1j91woQDuRjb6x4r8i7fxsFtogFncr/FA5W6WTY3Ai 0nJOTx2ta57oFenNKDSD++kiyyRT1AVE5YuYs2j1JpsqAK6a9TPDdi2I7jFj9IQU/F4C PC+OnA92/AYvqX3TYmE0rWpPieJiWp/5N8lW/Tx7NXLclt8NHCDMP0Buolk2Zx4DPkys be9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751650; x=1741356450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wVgVdQhbC2YyNwH7K95+EhEh/kAvax64uDHN7A2amTM=; b=ir1YYlfkVJqga4kzwFIQ3RXBR3e5HVy8HpKPB4qHxy2WGG+txIPoevvhyzcg66zUwY NUa1p91jWARU+dVzaiztcMSFAMNCtnccVRUfr3ddFKFDvEJagVD2C9vnBPxTRgjxLmoY QRvgRlbOJBoYihsk1b3qI19sJvhcxnYqTDPQ++4lB0AlBa1ZVGiBxU/7Atdh1sHnuy4T mbMlonpDKKqs3zRPpv5wvxs66wDBIXTq4sRGNXsItQzMc3EJZKdkQ6XFmMUYhY4iEXEl bRCYv3Vo2qJAHaOAFe2ohjEz0Pn9n7tPiKKPubNdiheXoHL5OvaNcgbC+yHcYImR+ymG PIhw== X-Forwarded-Encrypted: i=1; AJvYcCWicBmuAQWkFdCRXHcYL16NiW8+oqD+tx9aD/7xX/C836o5uabwQUELeNFra8667m2NxaySJd0J335tqXFb@lists.infradead.org X-Gm-Message-State: AOJu0Yx9NVmpqmXC0o99ERd2079br3KPcJYhQB/JzyUoatYyD1FKBiYM wqGM6YICaFfE9s08bUPCv4c27f60o1md7L5uDsvDWdOIWhpyRRi/dgzf/lR7T4c= X-Gm-Gg: ASbGncuQ0WpFY+waSWw8liiaoptp/s+UmmwzT+EakdS/n9/g0ukbSQ3S/VvMxlC9X+9 g0KaK+BHYyI/mzcNgJ1UpqQrOGExgSTauFjORokVxnvwR8zv8q/cPqziHJMyWX2llBYyyEb1ERc fqqbxuRpravQAGIUI9MEoWx3ryYt7GKJtccY2bz3beiPF9a2dBU/DSDlusXWlhy00zBiOMBFtpg ub/o3slpRJsdLg2gSwNn7VhzJIJxqx1Bgu4zQDvemA4OL3ia0J2D3aIqfi/6da7BX30KR1SfJb5 Hsy8DDmW6ErvbxHrGysMjNiw9wCe/cX7C3WJuMaZSgS+5xoIgVDPnoPNOKtiakUJYQI2O7FY5Ie Q8Eujo324CA== X-Google-Smtp-Source: AGHT+IHCyDQzEJ6kBhW3v4N+pYx5F1W3SqfuZOszPC9Ixk4jqjoqtVWckx72H2jiEWEF9nyPWj82Qw== X-Received: by 2002:a05:6402:254d:b0:5e4:cfe8:3502 with SMTP id 4fb4d7f45d1cf-5e4d6afa314mr2938285a12.17.1740751649850; Fri, 28 Feb 2025 06:07:29 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:29 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:27 +0000 Subject: [PATCH 14/18] rtc: sd3078: drop needless struct sd3078::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-14-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060731_413247_0D4FAD4A X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-sd3078.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c index fe27b54beaad1c06b70bf7f22e44c3f6da087267..ebb4d45ce2409982880affbc7a85d5e7410c8f42 100644 --- a/drivers/rtc/rtc-sd3078.c +++ b/drivers/rtc/rtc-sd3078.c @@ -37,7 +37,6 @@ #define WRITE_PROTECT_EN 0 struct sd3078 { - struct rtc_device *rtc; struct regmap *regmap; }; @@ -167,6 +166,7 @@ static int sd3078_probe(struct i2c_client *client) { int ret; struct sd3078 *sd3078; + struct rtc_device *rtc; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; @@ -183,15 +183,15 @@ static int sd3078_probe(struct i2c_client *client) i2c_set_clientdata(client, sd3078); - sd3078->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd3078->rtc)) - return PTR_ERR(sd3078->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - sd3078->rtc->ops = &sd3078_rtc_ops; - sd3078->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - sd3078->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &sd3078_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; - ret = devm_rtc_register_device(sd3078->rtc); + ret = devm_rtc_register_device(rtc); if (ret) return ret;