From patchwork Fri Feb 28 14:07:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996489 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FC02C19776 for ; Fri, 28 Feb 2025 14:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3YUs05DhFs+LgAiWCc16LXWwILhsHrllKlQ8YfVHzKU=; b=y9m18JkR5VeRoI 2AIbpBwSG9DAvYAWZ2osP7X6zHTIpTafB+/ztfYgbgeLqdMsNhaP24F11uT7eSPVkTROIdKxWGiRt wkl+goCZlYM5P51dLWAcJMOJUlXjMEFnuicHgo/Z+zurFcMgyoelroyRiFvFo+Y4lx6PQwFGGmQOw LE5zXksg1b2kJZZRJ0npGBTCBxJEESOxSJGrsAMVR18MYLJ6AXRNlkjU42hdPdAL2aNESamOLdqRI vzjD1wwh9C1dP+iftPvgpix5IFLPg6UgaN0AT7J4m9iCxTXX7/aC7X9L7wggZkE+oy7/hcMXiV0Wx P+m4Nw8eC32CinNamkzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1At-0000000BDqy-3P9y; Fri, 28 Feb 2025 14:17:11 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11T-0000000BB5L-05IE for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:28 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5dedd4782c6so3925584a12.3 for ; Fri, 28 Feb 2025 06:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751645; x=1741356445; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=jeU2JtskMdAYZtNYJ8cEX2hQiiFRABy15ZOpG+7C3G+2Brg3oejPx1FemRGjnRXTyc 3G5Q0LpfOvREynm1O7rtv9W7qI/CLpTONiHzThsbP7FmYuTWPy29Kh7N94ezawSEEXMh hd3oljXol9S1QIasSrTRyappJOVYuONc6uAwL2iknvlJCW4ypE87hKuncG+ui1i4TEQf uhPH2T56QzfZyHYLqvN/6wc3WPsEBxZ/sX+gEoUO9SQhrflkdO7XOuetK8F91hgxtzQ2 BwNGPu2ikkxKOPYHVclXI1spoVBWtHfH/fLnq2mdeOkHJlEGz+gq3EyUQvXBSxZ5UVE3 IKiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751645; x=1741356445; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=jOr/7tR0Myv60gqda95AoMcA1ozDmhaki/+DLfGHwuWT1XWUj1C30xJKuJerahCi9s mmdF5rgW0j7Qpqu4ocjhl5+1I0UPL68Jd+NzUPEw3QJvRGS7vwjyIpcw71e4of/ffDHQ 1RvH/76M3h+JxIwcbJobC9fDbkhLc86mi1EIeRQ1etsXrWsk8GmmpGwBXJLqkphY9kL1 Xkpai676ut5xdSUn860JDS/fgj8dYb5Hs4YEIlMZ9SGjb3kS9S02Vus0pJG72cFeQMHY vD8Gnhzy/hTg8zNUFzkO7REZ/nMfEQNLkXkZsKqyRrZQu2NloCbwAgSt7tSdGXbZj1pc Qmzg== X-Forwarded-Encrypted: i=1; AJvYcCVeiYzX4NEB4m6rvJYOxjhukgyWe+bk0fKiYt1ryzLeR4Zt/I2Bt19auObrxuCVq9eou0Et+rlNpkO6OmJt@lists.infradead.org X-Gm-Message-State: AOJu0Ywpses8nYimsBO70VEg0UB0A/ViT13KrjRYx4p7W1Ew9Ha31VAt A+P47uZOUOBKv66+wqt1VOZtAp6+mALTtHI+4jAm2MiuORcpFTUFUg2rTl4rHfY= X-Gm-Gg: ASbGnctUvXKop+w7ZtYleJkNxFArqLiJ1AZjt6K1KWI4HUg59eP/Z1+LsLAv6dKtbtY unk0+Lh5Yo+sPGdeHvMh8rG++Ffrh8658X9nUGkHjJ7Nf1GbQ6gVrxD6LW2mQW2rIIZDgb/G5WX JXsaylaYZLzuNaDC+RncYxppUcvvKXFU8dEMDhB+g1VkWkBlmHrQbf9gycOEueDsagUe84rxbYs d5sukBRDjSVZNYgOZAY6EoTVPINy/loio2aA6iURHQChJAIR111EJCII9vBSgZmnvYkuoTqBFHL 9Jxu+qg0rk9qc5fRM9/riY9eQsnfAb5z135sqIUfcv2ty3aI8B/PBcOTkxT6q57TFreS9qw/uDw HVsPrZBSO/A== X-Google-Smtp-Source: AGHT+IFjP5A5it0oOhAqjGMiq+zBlLn6/wyStXZ9TEpg3CsfQx18Ux73fzaAw5ZlIGleu7roV3QB1Q== X-Received: by 2002:a05:6402:84d:b0:5df:5188:11cc with SMTP id 4fb4d7f45d1cf-5e4d6b702a7mr2552045a12.20.1740751645245; Fri, 28 Feb 2025 06:07:25 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:24 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:18 +0000 Subject: [PATCH 05/18] rtc: ep93xx: drop needless struct ep93xx_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-5-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060727_055885_5F024762 X-CRM114-Status: GOOD ( 13.32 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-ep93xx.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-ep93xx.c b/drivers/rtc/rtc-ep93xx.c index 1fdd20d01560ef4fae2b996cf366b4f812329225..dcdcdd06f30d1ff6d0939f6bcad2c17c03c5a65e 100644 --- a/drivers/rtc/rtc-ep93xx.c +++ b/drivers/rtc/rtc-ep93xx.c @@ -28,7 +28,6 @@ struct ep93xx_rtc { void __iomem *mmio_base; - struct rtc_device *rtc; }; static int ep93xx_rtc_get_swcomp(struct device *dev, unsigned short *preload, @@ -123,6 +122,7 @@ static const struct attribute_group ep93xx_rtc_sysfs_files = { static int ep93xx_rtc_probe(struct platform_device *pdev) { struct ep93xx_rtc *ep93xx_rtc; + struct rtc_device *rtc; int err; ep93xx_rtc = devm_kzalloc(&pdev->dev, sizeof(*ep93xx_rtc), GFP_KERNEL); @@ -135,18 +135,18 @@ static int ep93xx_rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, ep93xx_rtc); - ep93xx_rtc->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(ep93xx_rtc->rtc)) - return PTR_ERR(ep93xx_rtc->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - ep93xx_rtc->rtc->ops = &ep93xx_rtc_ops; - ep93xx_rtc->rtc->range_max = U32_MAX; + rtc->ops = &ep93xx_rtc_ops; + rtc->range_max = U32_MAX; - err = rtc_add_group(ep93xx_rtc->rtc, &ep93xx_rtc_sysfs_files); + err = rtc_add_group(rtc, &ep93xx_rtc_sysfs_files); if (err) return err; - return devm_rtc_register_device(ep93xx_rtc->rtc); + return devm_rtc_register_device(rtc); } static const struct of_device_id ep93xx_rtc_of_ids[] = {