From patchwork Fri Feb 28 14:07:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996490 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45DEDC282C1 for ; Fri, 28 Feb 2025 14:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FQNc7jsOxspIZyBnQi4vNnsDnVZv4mH2lW7IFI5pJHY=; b=S70rCqTDsFlzMD H2qHHVMEhxkml+K+xfi+0hUiN19FSZFX98lI+LfLa8BM+ogb1EUUtcOkjMJNNit2BLaF433troT7q G1mv1uQ4KGJRJ9HcSG7+o4nwrgYDHNkWyX3PEeVpk5MvRc6gQefNSPxCn3emFMc+MP8LNRqgg5gC5 kWTO8EKVSPUNo/y6rWmIk9roS2gN75Ezp40539clvd1BDTVzEJtvr2GbMVZ1vmTmo+gWq4gOeQJqw GwwxEBjUHEKiJSuwzFb7WiV8UjgSbrL7xI2zkDwToTwC45Jya+Mj7l6X93tvrvAIic/+TKsSA3HqH AJFV5JPVK4Q2KsC66HVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1CQ-0000000BEJv-3qjJ; Fri, 28 Feb 2025 14:18:46 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11T-0000000BB5l-149o for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:28 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5e4ad1d67bdso3214419a12.2 for ; Fri, 28 Feb 2025 06:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751646; x=1741356446; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dZH0eiBnc3WyY94yEis5FUZqmpsbyvfcyDb3myV5OX0=; b=Tete8FJrRmJOVMYDzdfO7FOg3YK6B8VAh+fDA3yTBC6G623oCWjYNz4cNn6uxg9GeS Y7kq2HgqXo7qFWMXM7O2RaY35+/Zz0tqKDWBQYBrUwJ3AUVmzjlqXk8uCZgskXhzyjII m0ssSIwhTxK3EW6e7seGS6Y+2NuQIznXJ7CWX2DPDnB3Cc+VrYgMwfBUsG/zNJby6CDC Rr7PsmHPYGZuL9//Z+2Jd0edzBWRA0pf7UiZZKK0o7tV+iB8lFLGsfXRhtYWhjkPEHUL kLD4vMhKR8OGzxGk6C+FG8zLcDTmgyM0w0cpDxBL/NOmZvaeNpyFkIucf6R3jVjdSmb3 TarA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751646; x=1741356446; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dZH0eiBnc3WyY94yEis5FUZqmpsbyvfcyDb3myV5OX0=; b=tBYvnWxl9wW0xMGR6b4uZCf0rQ1zWpPHHUjzbmz7QAWv0bxNMjSEsiHwJiwIobQXVw ArHVjRs/pfTxuJIbGoScXf39HUAyt5KFjXlOtc1OpudMyGEILnqbtjpVu0yUvNutv+Kp FIxYI/lTcKOve7PtiPahBNX571dWw/PyfgVcZe7RViyO0Sbo0V/8t78+OxhHy6KG5DaE l+BHoYME+sAAonwRFXITg9dpgQYAf7BiZnj4gKdr1xr/0BeYv3/y+NlGM+qEfki+MF6c 2y5GQcb7neVJF0EtePlZUHJAByxrx7xd+7tWWUz+qFjK2n5ZxaHRMWJInEqIdT/hEuEG 0Czw== X-Forwarded-Encrypted: i=1; AJvYcCXyKGeGvocU5GRiSGcP5t4tWaJSkFUZFuQzCYyfgvX4gOifzidckQ6EjrlvVRMpvRaB3EibJBOPSv7lvmF9@lists.infradead.org X-Gm-Message-State: AOJu0YwNy/4Ek7l0SO/ADha11Zv+nAzG5sUMHStiQ7TLZ2k+MZBIe1rl MRZlbD2YM1L6+Oj+TtiK35WqfsXYfNyEjq2hSKrWN1gz/tbx5qgH/uM09DjaJ44= X-Gm-Gg: ASbGncs6yYDq02a940E7KMZh6b3J9TR/ky+Xf0TbHvJoFu6Yhnp7C0wT2Ps/SM8wz1e Ke80XwZztD4P0BAnNvb3fKH4tb0cMmDDMlEWqAJc30hyIjbX73qTJysPwwFUWOFWyWlZyacrDU7 GWxNP9V0dXMooIg6gznlDOa+Pl27XW2KhLEeEeBTVpja78N045F1thwtWpNKJjK7iGBNg0ivYpp Dk80kN5Uj7DvIxLD1Y8y8pEc4OCZqlwuWegPkcknuMBfvuQljpWhyi14DLLacfZ05f9Y84lJRVY sePDBtPWmX41LaTFVsXJTPtJ7nOYhlydfzkLFsjNGraixqW0cUIEsivagRCL3kg8Tv/sjEXHR5l cDsUcJHpH6w== X-Google-Smtp-Source: AGHT+IFbzXWayjdSMfWjy9cwjYueSFy4YBp7IQ8OjzR2IKI5f4QLOeDnV9cvNi5W4D61UevFMTrZwA== X-Received: by 2002:a05:6402:239a:b0:5e5:552:32a8 with SMTP id 4fb4d7f45d1cf-5e5055238efmr931950a12.8.1740751645786; Fri, 28 Feb 2025 06:07:25 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:25 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:19 +0000 Subject: [PATCH 06/18] rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-6-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060727_330100_CA64A186 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Reviewed-by: Linus Walleij --- drivers/rtc/rtc-ftrtc010.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ftrtc010.c b/drivers/rtc/rtc-ftrtc010.c index cb4a5d101f537e20a685bb022e6f6516b0df8271..02608d3784958e69ec0ecbdb9fcc8b333b19e7cc 100644 --- a/drivers/rtc/rtc-ftrtc010.c +++ b/drivers/rtc/rtc-ftrtc010.c @@ -28,7 +28,6 @@ MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:" DRV_NAME); struct ftrtc010_rtc { - struct rtc_device *rtc_dev; void __iomem *rtc_base; int rtc_irq; struct clk *pclk; @@ -113,6 +112,7 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) struct ftrtc010_rtc *rtc; struct device *dev = &pdev->dev; struct resource *res; + struct rtc_device *rtc_dev; int ret; rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); @@ -160,29 +160,28 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) goto err_disable_extclk; } - rtc->rtc_dev = devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc_dev)) { - ret = PTR_ERR(rtc->rtc_dev); + rtc_dev = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) { + ret = PTR_ERR(rtc_dev); goto err_disable_extclk; } - rtc->rtc_dev->ops = &ftrtc010_rtc_ops; + rtc_dev->ops = &ftrtc010_rtc_ops; sec = readl(rtc->rtc_base + FTRTC010_RTC_SECOND); min = readl(rtc->rtc_base + FTRTC010_RTC_MINUTE); hour = readl(rtc->rtc_base + FTRTC010_RTC_HOUR); days = readl(rtc->rtc_base + FTRTC010_RTC_DAYS); - rtc->rtc_dev->range_min = (u64)days * 86400 + hour * 3600 + - min * 60 + sec; - rtc->rtc_dev->range_max = U32_MAX + rtc->rtc_dev->range_min; + rtc_dev->range_min = (u64)days * 86400 + hour * 3600 + min * 60 + sec; + rtc_dev->range_max = U32_MAX + rtc_dev->range_min; ret = devm_request_irq(dev, rtc->rtc_irq, ftrtc010_rtc_interrupt, IRQF_SHARED, pdev->name, dev); if (unlikely(ret)) goto err_disable_extclk; - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); err_disable_extclk: clk_disable_unprepare(rtc->extclk);