From patchwork Fri Feb 28 14:07:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996492 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7A50C19776 for ; Fri, 28 Feb 2025 14:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UOnYn67i7kGRJPmH/AAZGgDfaBJkjIWhqsy5ZITOdOA=; b=fwxIIePohyBc1V KuG3tCTvddMaSFU8PanXlRMQUdPRFO5c+jAuGG/3L5hhWnk/WK0Uy9OdNTAAI7eqDY/LkB6IvIT9S h3aKq69s9ceqhOyIhMZqmqF3m6TkzQNOoz7KrlD969O3gpi7nEnSGdA01laL0d/JvHt3MYxP6Yrig fxqD+tl5t5XGgQ5eRBERkhLfnKcoPtX4MPo0SxtZCvhHLhCN+NinrtIjmAFQPdf9HDPmtPdqcCPkQ TiFZZ2zEWJIlgjwxc384JznXi5OE1dPrcLx9bxBJNZ/8/il6bWZkBlavWYRwMMeFG9C8qjPINxOaA YFjFNIQ7yLTfoNfFIU1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Dx-0000000BEeq-15yR; Fri, 28 Feb 2025 14:20:21 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11U-0000000BB7J-0uTR for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:29 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-abf3d64849dso62140966b.3 for ; Fri, 28 Feb 2025 06:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751647; x=1741356447; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=aVcetOIQHsUcyIeSUA7ovu5xYQAymhLIBjvDdHoVM4DkeqHws9LSRYQFQLjDA2RxDI 0lAMT0wfcc0y8jYudqXaZUGp3QIGN7gEkoKxUgA1F+wJik1kNXEiklFkzzD0h6MgZeLN 13mGxVQ0JEMOBsdjCuews3QsPBzwWyzo06O013+An7I5FMoaAzc4gUhPd/UYJnhFLy1c Ef30Q6cQzE+nrLNB5sSrhNateSfrbGOFsmuEI4FbofAhbx8Avk1jWarjAOrHGIW2EjTd /Lob8Uviw9gas12/0pCMA9MJFNfxWcIgjBGk1ECjHR/C8MNVp0u/aexZpBaZUPalOMvM 74/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751647; x=1741356447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=RVJPQiWkG65L2WbDor4x16uoVv5Pu6XzDdvyvxegVYOe/swLTm0M8oE3VWAyiIGh96 VRLPrb3WGs5e4xaHRmuZGaUwmzRcZEf7+WTfsz1l6AIMLexUq9UFE4/xsbKW9BS3FCQi e5m3wX7wzjU5zavLPfrxTy64lnlfg/xZF1/ChgcVhXkrLxy1BWPfp9RbonNFtUY9doKB 4p5xnjMITiVXECIQLPYY9QsOWDl3Ws59UyGFGX5ECQcpLKPR31AfiJHFuPAY8ai6cQBb 9LwlaLqR6BlT8mrwrqUMlwRZYVMh2KFOMS/R85mptRiCAg/xssqN5+y7Ro4BWaYMnXA/ wiDQ== X-Forwarded-Encrypted: i=1; AJvYcCWIKwi3zL+EVQOJ36MHun3V5EzFosvFG5ZCReCdbC13ue565LO4yfb2RA1o1XiLxrH4Nuvuz4DXWVi5924d@lists.infradead.org X-Gm-Message-State: AOJu0YxNGuwHaKy9wxSEWqUssep9ECpac/7H/iOr/bo7sufgwxbF97EQ q2cKI43oEn1qUKmtzNkhMpQJHjOf4IwB8f5y8uEXTbcBgZNyOthgBL0XR+2epwZdru4PSCfMptL Fczk= X-Gm-Gg: ASbGncvzOXTDeHMazHrjnfupfbA7C31TeWTV/wKG2RiQRzAK+oTucXm18sxTYuibr9/ e/iuMpJwRjhCIOu6ahlyr0cyWxB7sWFTpgIez14kzXBbkdweebcGBVA0X+5q792t22VeruaHz6b mjT2r6p2VC5IY+ZwfsvwV+7/Xz3Dm2SfyxmeNtxV5r7icBLCfEGPJSn2IMXZ1wlm6QhrXTJLZWU GATrFmpwUH0sWl77KhPv2jobV/9TfMlZ8r+9Riy2aUeB4tPQDfRRQFqPrg2RZ6PZOyJkE2lEztG NwmCE1xTq2fdZN2iL0RxkEoFdtSfd31UvMpwYooGG/RfYUcVy+Ia3xIvaqopn/2mJRAWYleadwu FkM8VtiptsQ== X-Google-Smtp-Source: AGHT+IELhJPOd4W0qPAgNgABcD5moXsKlcKW8ZKlMd0/6RuVXfSWqRkHz67gqaNmak1AZcnDjWmnpg== X-Received: by 2002:a05:6402:50d0:b0:5e0:818a:5f4d with SMTP id 4fb4d7f45d1cf-5e4d6b628aamr8322653a12.28.1740751646827; Fri, 28 Feb 2025 06:07:26 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:26 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:21 +0000 Subject: [PATCH 08/18] rtc: meson: drop needless struct meson_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-8-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060728_269937_3AB75358 X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-meson.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c index db1d626edca5fbb590f26c1cdd0774d350244a99..47e9ebf58ffc2f2b6c65932f8ec3773a213a62ef 100644 --- a/drivers/rtc/rtc-meson.c +++ b/drivers/rtc/rtc-meson.c @@ -59,7 +59,6 @@ #define MESON_STATIC_DEFAULT (MESON_STATIC_BIAS_CUR | MESON_STATIC_VOLTAGE) struct meson_rtc { - struct rtc_device *rtc; /* rtc device we created */ struct device *dev; /* device we bound from */ struct reset_control *reset; /* reset source */ struct regulator *vdd; /* voltage input */ @@ -292,6 +291,7 @@ static int meson_rtc_probe(struct platform_device *pdev) }; struct device *dev = &pdev->dev; struct meson_rtc *rtc; + struct rtc_device *rtc_dev; void __iomem *base; int ret; u32 tm; @@ -300,16 +300,16 @@ static int meson_rtc_probe(struct platform_device *pdev) if (!rtc) return -ENOMEM; - rtc->rtc = devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc)) - return PTR_ERR(rtc->rtc); + rtc_dev = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); platform_set_drvdata(pdev, rtc); rtc->dev = dev; - rtc->rtc->ops = &meson_rtc_ops; - rtc->rtc->range_max = U32_MAX; + rtc_dev->ops = &meson_rtc_ops; + rtc_dev->range_max = U32_MAX; base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) @@ -365,11 +365,11 @@ static int meson_rtc_probe(struct platform_device *pdev) } meson_rtc_nvmem_config.priv = rtc; - ret = devm_rtc_nvmem_register(rtc->rtc, &meson_rtc_nvmem_config); + ret = devm_rtc_nvmem_register(rtc_dev, &meson_rtc_nvmem_config); if (ret) goto out_disable_vdd; - ret = devm_rtc_register_device(rtc->rtc); + ret = devm_rtc_register_device(rtc_dev); if (ret) goto out_disable_vdd;