| Message ID | 5b83767e-c53d-316f-df10-45a39dbd9c88@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: amlogic: switch bindings to yaml and adjust some dtbs's | expand |
Hello, On Wed, Feb 01, 2023 at 09:00:21PM +0100, Heiner Kallweit wrote: > Convert Amlogic Meson PWM binding to yaml. > > Reviewed-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> How is supposed to pick up this patch? Does it go in together with the other patches in this series via amlogic/arm; or is there an expectation that it enters via PWM? Best regards Uwe
Hello, On Wed, Feb 01, 2023 at 09:00:21PM +0100, Heiner Kallweit wrote: > Convert Amlogic Meson PWM binding to yaml. > > Reviewed-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> this is effectively v4 of https://lore.kernel.org/linux-pwm/c92b9e51-bb69-0712-0b29-3db3c9a29f8b@gmail.com and the ony change compared to v3 is that you dropped "items:" (and reindented). I'll mark above v3 as superseeded in our patchwork, please scream if I got that wrong. Other than that: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
On 06.02.2023 09:23, Uwe Kleine-König wrote: > Hello, > > On Wed, Feb 01, 2023 at 09:00:21PM +0100, Heiner Kallweit wrote: >> Convert Amlogic Meson PWM binding to yaml. >> >> Reviewed-by: Rob Herring <robh+dt@kernel.org> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > How is supposed to pick up this patch? Does it go in together with the > other patches in this series via amlogic/arm; or is there an expectation > that it enters via PWM? > Neil, are you going to take this via the amlogic tree? > Best regards > Uwe > Heiner
Hi, On 06/02/2023 09:23, Uwe Kleine-König wrote: > Hello, > > On Wed, Feb 01, 2023 at 09:00:21PM +0100, Heiner Kallweit wrote: >> Convert Amlogic Meson PWM binding to yaml. >> >> Reviewed-by: Rob Herring <robh+dt@kernel.org> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > How is supposed to pick up this patch? Does it go in together with the > other patches in this series via amlogic/arm; or is there an expectation > that it enters via PWM? I expect Thierry to pick it, if he can't I can take with his ack. Neil > > Best regards > Uwe >
diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml new file mode 100644 index 000000000..527864a4d --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/pwm-amlogic.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic PWM + +maintainers: + - Heiner Kallweit <hkallweit1@gmail.com> + +allOf: + - $ref: pwm.yaml# + +properties: + compatible: + oneOf: + - enum: + - amlogic,meson8b-pwm + - amlogic,meson-gxbb-pwm + - amlogic,meson-gxbb-ao-pwm + - amlogic,meson-axg-ee-pwm + - amlogic,meson-axg-ao-pwm + - amlogic,meson-g12a-ee-pwm + - amlogic,meson-g12a-ao-pwm-ab + - amlogic,meson-g12a-ao-pwm-cd + - amlogic,meson-s4-pwm + - items: + - const: amlogic,meson-gx-pwm + - const: amlogic,meson-gxbb-pwm + - items: + - const: amlogic,meson-gx-ao-pwm + - const: amlogic,meson-gxbb-ao-pwm + - items: + - const: amlogic,meson8-pwm + - const: amlogic,meson8b-pwm + + reg: + maxItems: 1 + + clocks: + minItems: 1 + maxItems: 2 + + clock-names: + oneOf: + - items: + - enum: [clkin0, clkin1] + - items: + - const: clkin0 + - const: clkin1 + + "#pwm-cells": + const: 3 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + pwm@8550 { + compatible = "amlogic,meson-gxbb-pwm"; + reg = <0x08550 0x10>; + clocks = <&xtal>, <&xtal>; + clock-names = "clkin0", "clkin1"; + #pwm-cells = <3>; + }; diff --git a/Documentation/devicetree/bindings/pwm/pwm-meson.txt b/Documentation/devicetree/bindings/pwm/pwm-meson.txt deleted file mode 100644 index bd02b0a14..000000000 --- a/Documentation/devicetree/bindings/pwm/pwm-meson.txt +++ /dev/null @@ -1,29 +0,0 @@ -Amlogic Meson PWM Controller -============================ - -Required properties: -- compatible: Shall contain "amlogic,meson8b-pwm" - or "amlogic,meson-gxbb-pwm" - or "amlogic,meson-gxbb-ao-pwm" - or "amlogic,meson-axg-ee-pwm" - or "amlogic,meson-axg-ao-pwm" - or "amlogic,meson-g12a-ee-pwm" - or "amlogic,meson-g12a-ao-pwm-ab" - or "amlogic,meson-g12a-ao-pwm-cd" -- #pwm-cells: Should be 3. See pwm.yaml in this directory for a description of - the cells format. - -Optional properties: -- clocks: Could contain one or two parents clocks phandle for each of the two - PWM channels. -- clock-names: Could contain at least the "clkin0" and/or "clkin1" names. - -Example: - - pwm_ab: pwm@8550 { - compatible = "amlogic,meson-gxbb-pwm"; - reg = <0x0 0x08550 0x0 0x10>; - #pwm-cells = <3>; - clocks = <&xtal>, <&xtal>; - clock-names = "clkin0", "clkin1"; - }