| Message ID | f3370a0619d40c40676ed029cc04a3ed1c12b991.1553914418.git.chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/4] phy: phy-mtk-tphy: get optional clock by devm_clk_get_optional() | expand |
Hi, This looks good to me. Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Thanks, On Sat, 30 Mar 2019 17:11:37 +0800 Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > Use devm_clk_get_optional() to get optional clock > > Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > drivers/phy/socionext/phy-uniphier-usb3hs.c | 10 +++------- > drivers/phy/socionext/phy-uniphier-usb3ss.c | 10 +++------- > 2 files changed, 6 insertions(+), 14 deletions(-) > > diff --git a/drivers/phy/socionext/phy-uniphier-usb3hs.c b/drivers/phy/socionext/phy-uniphier-usb3hs.c > index b1b048be6166..50f379fc4e06 100644 > --- a/drivers/phy/socionext/phy-uniphier-usb3hs.c > +++ b/drivers/phy/socionext/phy-uniphier-usb3hs.c > @@ -335,13 +335,9 @@ static int uniphier_u3hsphy_probe(struct platform_device *pdev) > if (IS_ERR(priv->clk_parent)) > return PTR_ERR(priv->clk_parent); > > - priv->clk_ext = devm_clk_get(dev, "phy-ext"); > - if (IS_ERR(priv->clk_ext)) { > - if (PTR_ERR(priv->clk_ext) == -ENOENT) > - priv->clk_ext = NULL; > - else > - return PTR_ERR(priv->clk_ext); > - } > + priv->clk_ext = devm_clk_get_optional(dev, "phy-ext"); > + if (IS_ERR(priv->clk_ext)) > + return PTR_ERR(priv->clk_ext); > > priv->rst = devm_reset_control_get_shared(dev, "phy"); > if (IS_ERR(priv->rst)) > diff --git a/drivers/phy/socionext/phy-uniphier-usb3ss.c b/drivers/phy/socionext/phy-uniphier-usb3ss.c > index 4be95679c7d8..ec231e40ef2a 100644 > --- a/drivers/phy/socionext/phy-uniphier-usb3ss.c > +++ b/drivers/phy/socionext/phy-uniphier-usb3ss.c > @@ -238,13 +238,9 @@ static int uniphier_u3ssphy_probe(struct platform_device *pdev) > if (IS_ERR(priv->clk)) > return PTR_ERR(priv->clk); > > - priv->clk_ext = devm_clk_get(dev, "phy-ext"); > - if (IS_ERR(priv->clk_ext)) { > - if (PTR_ERR(priv->clk_ext) == -ENOENT) > - priv->clk_ext = NULL; > - else > - return PTR_ERR(priv->clk_ext); > - } > + priv->clk_ext = devm_clk_get_optional(dev, "phy-ext"); > + if (IS_ERR(priv->clk_ext)) > + return PTR_ERR(priv->clk_ext); > > priv->rst = devm_reset_control_get_shared(dev, "phy"); > if (IS_ERR(priv->rst)) > -- > 2.20.1 --- Best Regards, Kunihiko Hayashi
diff --git a/drivers/phy/socionext/phy-uniphier-usb3hs.c b/drivers/phy/socionext/phy-uniphier-usb3hs.c index b1b048be6166..50f379fc4e06 100644 --- a/drivers/phy/socionext/phy-uniphier-usb3hs.c +++ b/drivers/phy/socionext/phy-uniphier-usb3hs.c @@ -335,13 +335,9 @@ static int uniphier_u3hsphy_probe(struct platform_device *pdev) if (IS_ERR(priv->clk_parent)) return PTR_ERR(priv->clk_parent); - priv->clk_ext = devm_clk_get(dev, "phy-ext"); - if (IS_ERR(priv->clk_ext)) { - if (PTR_ERR(priv->clk_ext) == -ENOENT) - priv->clk_ext = NULL; - else - return PTR_ERR(priv->clk_ext); - } + priv->clk_ext = devm_clk_get_optional(dev, "phy-ext"); + if (IS_ERR(priv->clk_ext)) + return PTR_ERR(priv->clk_ext); priv->rst = devm_reset_control_get_shared(dev, "phy"); if (IS_ERR(priv->rst)) diff --git a/drivers/phy/socionext/phy-uniphier-usb3ss.c b/drivers/phy/socionext/phy-uniphier-usb3ss.c index 4be95679c7d8..ec231e40ef2a 100644 --- a/drivers/phy/socionext/phy-uniphier-usb3ss.c +++ b/drivers/phy/socionext/phy-uniphier-usb3ss.c @@ -238,13 +238,9 @@ static int uniphier_u3ssphy_probe(struct platform_device *pdev) if (IS_ERR(priv->clk)) return PTR_ERR(priv->clk); - priv->clk_ext = devm_clk_get(dev, "phy-ext"); - if (IS_ERR(priv->clk_ext)) { - if (PTR_ERR(priv->clk_ext) == -ENOENT) - priv->clk_ext = NULL; - else - return PTR_ERR(priv->clk_ext); - } + priv->clk_ext = devm_clk_get_optional(dev, "phy-ext"); + if (IS_ERR(priv->clk_ext)) + return PTR_ERR(priv->clk_ext); priv->rst = devm_reset_control_get_shared(dev, "phy"); if (IS_ERR(priv->rst))
Use devm_clk_get_optional() to get optional clock Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/phy/socionext/phy-uniphier-usb3hs.c | 10 +++------- drivers/phy/socionext/phy-uniphier-usb3ss.c | 10 +++------- 2 files changed, 6 insertions(+), 14 deletions(-)