mbox series

[V2,0/3] ARM: dts: add Raspberry Pi 3 A+

Message ID 1542322805-6211-1-git-send-email-stefan.wahren@i2se.com (mailing list archive)
Headers show
Series ARM: dts: add Raspberry Pi 3 A+ | expand

Message

Stefan Wahren Nov. 15, 2018, 11 p.m. UTC
This patch series adds support for the brand new Raspberry Pi 3 A+ .

Changes in V2:
- add missing Makefile change for arm64

Stefan Wahren (3):
  dt-bindings: bcm: Add Raspberry Pi 3 A+
  ARM: dts: add Raspberry Pi 3 A+
  arm64: dts: broadcom: Add reference to RPi 3 A+

 .../devicetree/bindings/arm/bcm/brcm,bcm2835.txt   |   4 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts         | 107 +++++++++++++++++++++
 arch/arm64/boot/dts/broadcom/Makefile              |   3 +-
 .../boot/dts/broadcom/bcm2837-rpi-3-a-plus.dts     |   2 +
 5 files changed, 116 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
 create mode 100644 arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dts

Comments

Stefan Wahren Nov. 15, 2018, 11 p.m. UTC | #1
This patch series adds support for the brand new Raspberry Pi 3 A+ .

Stefan Wahren (3):
  dt-bindings: bcm: Add Raspberry Pi 3 A+
  ARM: dts: add Raspberry Pi 3 A+
  arm64: dts: broadcom: Add reference to RPi 3 A+

 .../devicetree/bindings/arm/bcm/brcm,bcm2835.txt   |   4 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts         | 107 +++++++++++++++++++++
 .../boot/dts/broadcom/bcm2837-rpi-3-a-plus.dts     |   2 +
 4 files changed, 114 insertions(+)
 create mode 100644 arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
 create mode 100644 arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dts
Eric Anholt Nov. 16, 2018, 9:23 p.m. UTC | #2
Stefan Wahren <stefan.wahren@i2se.com> writes:

> This patch series adds support for the brand new Raspberry Pi 3 A+ .
>
> Changes in V2:
> - add missing Makefile change for arm64
>
> Stefan Wahren (3):
>   dt-bindings: bcm: Add Raspberry Pi 3 A+
>   ARM: dts: add Raspberry Pi 3 A+
>   arm64: dts: broadcom: Add reference to RPi 3 A+

Looks pretty reasonable, but I couldn't verify any of the contents --
the firmware repo doesn't have a DT file for it, and the published
schematics don't show most of the GPIO connections (sigh).  How did you
write/test this?
Stefan Wahren Nov. 16, 2018, 10:43 p.m. UTC | #3
Hi Eric,

> Eric Anholt <eric@anholt.net> hat am 16. November 2018 um 22:23 geschrieben:
> 
> 
> Stefan Wahren <stefan.wahren@i2se.com> writes:
> 
> > This patch series adds support for the brand new Raspberry Pi 3 A+ .
> >
> > Changes in V2:
> > - add missing Makefile change for arm64
> >
> > Stefan Wahren (3):
> >   dt-bindings: bcm: Add Raspberry Pi 3 A+
> >   ARM: dts: add Raspberry Pi 3 A+
> >   arm64: dts: broadcom: Add reference to RPi 3 A+
> 
> Looks pretty reasonable, but I couldn't verify any of the contents --
> the firmware repo doesn't have a DT file for it, and the published
> schematics don't show most of the GPIO connections (sigh).  How did you
> write/test this?

i have a Raspberry Pi 3 A+ and the firmware seems to use a runtime generated DT. So i dumped the DTS of a 3 A+ and a 3 B+ from procfs. Based on the procfs diff i modified the upstream 3B+ source to get a 3A+ .

Please consider this series as optional for 5.0. I won't submit any further patch for the next release cycle.

But maybe Phil can provide some feedback.

Regards
Stefan
Eric Anholt Nov. 19, 2018, 10:49 p.m. UTC | #4
Stefan Wahren <stefan.wahren@i2se.com> writes:

> Hi Eric,
>
>> Eric Anholt <eric@anholt.net> hat am 16. November 2018 um 22:23 geschrieben:
>> 
>> 
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>> 
>> > This patch series adds support for the brand new Raspberry Pi 3 A+ .
>> >
>> > Changes in V2:
>> > - add missing Makefile change for arm64
>> >
>> > Stefan Wahren (3):
>> >   dt-bindings: bcm: Add Raspberry Pi 3 A+
>> >   ARM: dts: add Raspberry Pi 3 A+
>> >   arm64: dts: broadcom: Add reference to RPi 3 A+
>> 
>> Looks pretty reasonable, but I couldn't verify any of the contents --
>> the firmware repo doesn't have a DT file for it, and the published
>> schematics don't show most of the GPIO connections (sigh).  How did you
>> write/test this?
>
> i have a Raspberry Pi 3 A+ and the firmware seems to use a runtime
> generated DT. So i dumped the DTS of a 3 A+ and a 3 B+ from
> procfs. Based on the procfs diff i modified the upstream 3B+ source to
> get a 3A+ .

Sounds good to me.  Comparing to the pi3b+, it looks like the changes I
would expect for the board, so the series is:

Reviewed-by: Eric Anholt <eric@anholt.net>