From patchwork Fri Apr 26 08:05:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Gong X-Patchwork-Id: 10918775 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 869531390 for ; Fri, 26 Apr 2019 08:06:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76B0128AB0 for ; Fri, 26 Apr 2019 08:06:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6AF6328AE3; Fri, 26 Apr 2019 08:06:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0394F28AB0 for ; Fri, 26 Apr 2019 08:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=nGS1TcfCpklQvdZdW4YU5MgEknBabCRIV13Ja0Kzn1Q=; b=q7XKjh8V9+nZ33 zjmDwnwwhDlIbyMDj2Ttm43E4905i+ym4WW87Wnmuh2UMabLbZIogbdzVDQT8JmzGO+JV/+pB03Zd n1rrCGyu0ciY4RvbrRzSL0etknHPetT3FbNJaEs59eJ5KdkAAF5pMesuaPWn6Tc4CMOQhz4XeS3QE 1rEqe9krOxy7aVsV899CCtJb3sz7Dc0tvYMke6X6j4N+IBb5qV1T+Rh5p/8XzGl1nIcx2fr/a2mzf TlGdytR7deIlvUDM040cKaW1H8S83dSQJIcrIIGqhvME0xfLrqsK+BdvuYsBb3uEdrGRojGDXXQK8 +UmtdYHsIoznDIXSl3Gw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJvrs-0007FM-B8; Fri, 26 Apr 2019 08:06:00 +0000 Received: from mail-eopbgr50079.outbound.protection.outlook.com ([40.107.5.79] helo=EUR03-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJvr4-0005tL-1S for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2019 08:05:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RRmNkvpROONlPBDJwxg4o2EtJfp3heGsQs2qS0IW7os=; b=xpNzyT0DEDq0dHLDXp/ebULupZ453yGufwtj3b4ERJ4Exi/WtzGVLyM1c6xc6IcT4uLuaBWtT+QWRG54IVZxsVlxeKRMOMWOUqEnvoE0ne3pCpx2IdaFuprcd9RbRh5WVqChg+WR5J9sqBn+ThzmeF4BUuTq6qCcdqYbS9cXe/Q= Received: from VI1PR04MB4543.eurprd04.prod.outlook.com (20.177.55.90) by VI1PR04MB6109.eurprd04.prod.outlook.com (20.179.26.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13; Fri, 26 Apr 2019 08:05:05 +0000 Received: from VI1PR04MB4543.eurprd04.prod.outlook.com ([fe80::5d07:911b:18e1:1525]) by VI1PR04MB4543.eurprd04.prod.outlook.com ([fe80::5d07:911b:18e1:1525%4]) with mapi id 15.20.1835.010; Fri, 26 Apr 2019 08:05:05 +0000 From: Robin Gong To: "broonie@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "u.kleine-koenig@pengutronix.de" , "plyatov@gmail.com" , "dan.j.williams@intel.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" Subject: [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family Thread-Topic: [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family Thread-Index: AQHU/AbBy202P2j5a0C7BDmMWU+Kfw== Date: Fri, 26 Apr 2019 08:05:04 +0000 Message-ID: <1556265512-9130-1-git-send-email-yibin.gong@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0PR01CA0024.apcprd01.prod.exchangelabs.com (2603:1096:203:92::36) To VI1PR04MB4543.eurprd04.prod.outlook.com (2603:10a6:803:6d::26) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yibin.gong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9f1e9d2d-8823-41b7-2bc1-08d6ca1de3de x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB6109; x-ms-traffictypediagnostic: VI1PR04MB6109: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-forefront-prvs: 001968DD50 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(346002)(366004)(376002)(39860400002)(189003)(199004)(68736007)(478600001)(110136005)(99286004)(186003)(53936002)(102836004)(25786009)(386003)(6506007)(2501003)(4326008)(6306002)(52116002)(6512007)(97736004)(26005)(486006)(316002)(2616005)(476003)(966005)(7736002)(54906003)(71190400001)(305945005)(71200400001)(14444005)(256004)(14454004)(2906002)(7416002)(8676002)(81156014)(81166006)(36756003)(6486002)(8936002)(50226002)(66946007)(66476007)(66556008)(64756008)(66066001)(66446008)(2201001)(6436002)(86362001)(6116002)(5660300002)(3846002)(73956011)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB6109; H:VI1PR04MB4543.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ahHf5ShBGcG3+t6NHMPzXMDr9RWaQuTIGU9XWheNUajdXVyGjZthtnnui+JSnVVqNwfq9gsi2mqmEp5clYnGtzfNAL3NMFFty8Li+svTk4jKR/DPJUFSRLVB+x7Q4zf6vmocrJ2hc/GCG0rvfJp3mOptAviRhHy6wxsEHsLKezjQObEQD+eyWvCiu7bkBDNVtAfFEhL5ggLTcCo1Q1CXvsgpdK5CcptS0nj0BBSO/ww1gp1sGcp0HnhI8E0OoeIp1GUzSRtcN08SLMEaRdKCMeWX0R6T0mR/okBjDJ7pfKOHkwxF5JOpTqDqdgUAqPVVX/umsURCJaFJPc8XzJBacll6HNfn6uEkgXrZJBbWTadu5JCTdcFyrO6bC1vegzXqFadTAvDg4mENLsAus1wKAruQmSkcS31BeSpMqF24fuc= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f1e9d2d-8823-41b7-2bc1-08d6ca1de3de X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2019 08:05:04.9357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6109 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_010510_245248_CD3C2909 X-CRM114-Status: GOOD ( 14.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO transfer to be send twice in DMA mode. Please get more information from: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding new sdma ram script which works in XCH mode as PIO inside sdma instead of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0. The issue should be exist on all legacy i.mx6/7 soc family before i.mx6ul, NXP fix this design issue from i.mx6ul, so newer chips such as i.mx6ull/ i.mx8mq/i.mx8mm, don't need this workaroud anymore. This patch set add new 'fsl,imx6ul-ecspi' for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need errata or not. The first two reverted patches should be the same issue, though, it seems 'fixed' by changing to other shp script. Hope Sean or Sascha could have the chance to test this patch set if could fix their issues. Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work on i.mx8mm because the event id is zero. PS: Please get sdma firmware from below linux-firmware and copy it to your local rootfs /lib/firmware/imx/sdma. https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma v2: 1. add commit log for reverted patches. 2. add comment for 'ecspi_fixed' in sdma driver. 3. add 'fsl,imx6sll-ecspi' compatible instead of 'fsl,imx6ul-ecspi' rather than remove. Robin Gong (15): Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Revert "dmaengine: imx-sdma: refine to load context only once" dmaengine: imx-sdma: remove dupilicated sdma_load_context dma: engine: imx-sdma: add mcu_2_ecspi script spi: imx: fix ERR009165 spi: imx: remove ERR009165 workaround on i.mx6ul dt-bindings: spi: imx: add i.mx6ul to state errata fixed dmaengine: imx-sdma: remove ERR009165 on i.mx6ul dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm ARM64: dts: freescale: imx8mm/8mq: update new compatible name for ecspi and sdma ARM: dts: imx6ul: add dma support on ecspi ARM: dts: imx6sll: correct ecspi/sdma compatible arm64: defconfig: Enable SDMA on i.mx8mq/8mm .../devicetree/bindings/dma/fsl-imx-sdma.txt | 2 + .../devicetree/bindings/spi/fsl-imx-cspi.txt | 2 + arch/arm/boot/dts/imx6q.dtsi | 2 +- arch/arm/boot/dts/imx6qdl.dtsi | 8 +-- arch/arm/boot/dts/imx6sll.dtsi | 10 ++-- arch/arm/boot/dts/imx6ul.dtsi | 8 +++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 14 ++--- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 +- arch/arm64/configs/defconfig | 3 + drivers/dma/imx-sdma.c | 67 ++++++++++++++++------ drivers/spi/spi-imx.c | 46 ++++++++++++--- include/linux/platform_data/dma-imx-sdma.h | 1 + 12 files changed, 124 insertions(+), 45 deletions(-)