From patchwork Tue Jun 11 09:38:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Thierry X-Patchwork-Id: 10986333 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 246EB76 for ; Tue, 11 Jun 2019 09:38:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 14D2D286A2 for ; Tue, 11 Jun 2019 09:38:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 06BCD286A8; Tue, 11 Jun 2019 09:38:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7607F286A2 for ; Tue, 11 Jun 2019 09:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=kvLc4cVYf1wEW8QbOL+magrFPxqgzs+j6187z1VIv0o=; b=W3h q/9E+NNSRloly94m1xx0iRgphzNwwteOmmU2qH5z8fO2okNG5NlZzJISHW9fu1Q0sqyKZzzvvSe9j XbNRS489ZFhfCoksKn7f2ntwKzMvNXlK1VOjXzuVbkR/7KWpFYx4aH3rhDoHChiVIYLaFCFzoqoBC Y8Y57QwDBzATum3VYoR+Hzc76LKYo6V3m/3ZC7rbLof5Ok+0uLwMo6ccva07Td5vdR9kM0w9qqO5g Dr2gNiMhv2+PMnp0r0/AOc8Y9jQt1ws7UzWoEUgCbQSoB58Kl6OrrQi0rVuDpXnZVXMpYbOgQ77nw 7YDJzxE7SKzrNTlBM3oftEsrA0dv1RA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hadEs-0007tU-5N; Tue, 11 Jun 2019 09:38:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hadEX-0007as-9O for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2019 09:38:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4CBD7337; Tue, 11 Jun 2019 02:38:21 -0700 (PDT) Received: from e112298-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B4FF13F73C; Tue, 11 Jun 2019 02:38:19 -0700 (PDT) From: Julien Thierry To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 0/8] arm64: IRQ priority masking and Pseudo-NMI fixes Date: Tue, 11 Jun 2019 10:38:05 +0100 Message-Id: <1560245893-46998-1-git-send-email-julien.thierry@arm.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_023825_436911_7960702B X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Julien Thierry , marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, james.morse@arm.com, yuzenghui@huawei.com, wanghaibin.wang@huawei.com, liwei391@huawei.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Version one[1] of this series attempted to fix the issue reported by Zenghui[2] when using the function_graph tracer with IRQ priority masking. Since then, I realized that priority masking and the use of Pseudo-NMIs was more broken than I thought. * Patch 1-2 are just some cleanup * Patch 3 fixes a potential issue with not clobbering condition flags in irqflags operations * Patch 4 fixes an issue where calling C code in Pseudo-NMI before entering NMI enter could lead to potential races * Patch 5 fixes the function_graph issue when using priority masking * Patch 6 introduces some debug to hopefully avoid breaking things in the future * Patch 7 is a rebased version of the patch sent by Wei Li[3] fixing an error that can happen during on some platform using the priority masking feature * Patch 8 re-enables the Pseudo-NMI selection Changes since V3 [4]: - Rebase on v5.2-rc4 - Fix comments/typos/missed updates - Use single condition evalution for nmi_enter and nmi_exit Changes since V2 [5]: - Rebase on v5.2-rc3 - clobber conditions flags for asm that needs it as pointed out by Marc Z. and Robin M. - Fix the naming of the new PMR bit value - Introduce some helper for the debug conditions - use WARN_ONCE for debug that might be very noisy - Reenable pseudo NMI. Changes since V1 [1]: - Fix possible race condition between NMI and trace irqflags - Simplify the representation of PSR.I in the PMR value - Include Wei Li's fix - Rebase on v5.1-rc7 [1] https://marc.info/?l=linux-arm-kernel&m=155542458004480&w=2 [2] https://www.spinics.net/lists/arm-kernel/msg716956.html [3] https://www.spinics.net/lists/arm-kernel/msg722171.html [4] https://lkml.org/lkml/2019/6/6/280 [5] https://lkml.org/lkml/2019/4/29/643 Cheers, Julien --> Julien Thierry (7): arm64: Do not enable IRQs for ct_user_exit arm64: irqflags: Pass flags as readonly operand to restore instruction arm64: irqflags: Add condition flags to inline asm clobber list arm64: Fix interrupt tracing in the presence of NMIs arm64: Fix incorrect irqflag restore for priority masking arm64: irqflags: Introduce explicit debugging for IRQ priorities arm64: Allow selecting Pseudo-NMI again Wei Li (1): arm64: fix kernel stack overflow in kdump capture kernel arch/arm64/Kconfig | 12 +++++- arch/arm64/include/asm/arch_gicv3.h | 4 +- arch/arm64/include/asm/cpufeature.h | 6 +++ arch/arm64/include/asm/daifflags.h | 75 +++++++++++++++++++++------------ arch/arm64/include/asm/irqflags.h | 79 +++++++++++++++++----------------- arch/arm64/include/asm/kvm_host.h | 7 ++-- arch/arm64/include/asm/ptrace.h | 10 ++++- arch/arm64/kernel/entry.S | 84 +++++++++++++++++++++++++++++-------- arch/arm64/kernel/irq.c | 26 ++++++++++++ arch/arm64/kernel/process.c | 2 +- arch/arm64/kernel/smp.c | 6 +-- arch/arm64/kvm/hyp/switch.c | 2 +- drivers/irqchip/irq-gic-v3.c | 7 ++++ kernel/irq/irqdesc.c | 8 +++- 14 files changed, 228 insertions(+), 100 deletions(-) Reviewed-by: Marc Zyngier --- 1.9.1