[V3,net-next,0/7] ARM: Enable GENET support for RPi 4

Message

Stefan Wahren Nov. 9, 2019, 7 p.m. UTC

Raspberry Pi 4 uses the broadcom genet chip in version five.
This chip has a dma controller integrated. Up to now the maximal
burst size was hard-coded to 0x10. But it turns out that Raspberry Pi 4
does only work with the smaller maximal burst size of 0x8.

This series based on Matthias Brugger's V1 series [1].

[1] - https://patchwork.kernel.org/cover/11186193/

Changes in V3:
- introduce SoC-specific compatibles for GENET (incl. dt-binding)
- use platform_get_irq_optional for optional IRQ
- remove Fixes tag from IRQ error handling change
- move most of MDIO stuff to bcm2711.dtsi

Changes in V2:
- add 2 fixes for IRQ retrieval
- add support for missing PHY modes
- declare PHY mode RGMII RXID based on the default settings
- add alias to allow firmware append the MAC address

Stefan Wahren (7):
  net: bcmgenet: Avoid touching non-existent interrupt
  net: bcmgenet: Fix error handling on IRQ retrieval
  dt-bindings: net: bcmgenet: Add BCM2711 support
  net: bcmgenet: Add BCM2711 support
  net: bcmgenet: Refactor register access in bcmgenet_mii_config
  net: bcmgenet: Add RGMII_RXID and RGMII_ID support
  ARM: dts: bcm2711-rpi-4: Enable GENET support

 .../devicetree/bindings/net/brcm,bcmgenet.txt      |  2 +-
 arch/arm/boot/dts/bcm2711-rpi-4-b.dts              | 17 +++++
 arch/arm/boot/dts/bcm2711.dtsi                     | 26 ++++++++
 drivers/net/ethernet/broadcom/genet/bcmgenet.c     | 74 ++++++++++++++++++----
 drivers/net/ethernet/broadcom/genet/bcmgenet.h     |  1 +
 drivers/net/ethernet/broadcom/genet/bcmmii.c       | 51 ++++++++-------
 6 files changed, 133 insertions(+), 38 deletions(-)

--
2.7.4

Comments

Florian Fainelli Nov. 10, 2019, 8:26 p.m. UTC | #1

Hi David,

On 11/9/2019 11:00 AM, Stefan Wahren wrote:
> Raspberry Pi 4 uses the broadcom genet chip in version five.
> This chip has a dma controller integrated. Up to now the maximal
> burst size was hard-coded to 0x10. But it turns out that Raspberry Pi 4
> does only work with the smaller maximal burst size of 0x8.
> 
> This series based on Matthias Brugger's V1 series [1].
> 
> [1] - https://patchwork.kernel.org/cover/11186193/
> 
> Changes in V3:
> - introduce SoC-specific compatibles for GENET (incl. dt-binding)
> - use platform_get_irq_optional for optional IRQ
> - remove Fixes tag from IRQ error handling change
> - move most of MDIO stuff to bcm2711.dtsi
> 
> Changes in V2:
> - add 2 fixes for IRQ retrieval
> - add support for missing PHY modes
> - declare PHY mode RGMII RXID based on the default settings
> - add alias to allow firmware append the MAC address

Do you want to merge patches 1-6 through net-next and I will take patch
7 through the Broadcom ARM SoC pull request since this depends on the
Device Tree files being present?

> 
> Stefan Wahren (7):
>   net: bcmgenet: Avoid touching non-existent interrupt
>   net: bcmgenet: Fix error handling on IRQ retrieval
>   dt-bindings: net: bcmgenet: Add BCM2711 support
>   net: bcmgenet: Add BCM2711 support
>   net: bcmgenet: Refactor register access in bcmgenet_mii_config
>   net: bcmgenet: Add RGMII_RXID and RGMII_ID support
>   ARM: dts: bcm2711-rpi-4: Enable GENET support
> 
>  .../devicetree/bindings/net/brcm,bcmgenet.txt      |  2 +-
>  arch/arm/boot/dts/bcm2711-rpi-4-b.dts              | 17 +++++
>  arch/arm/boot/dts/bcm2711.dtsi                     | 26 ++++++++
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c     | 74 ++++++++++++++++++----
>  drivers/net/ethernet/broadcom/genet/bcmgenet.h     |  1 +
>  drivers/net/ethernet/broadcom/genet/bcmmii.c       | 51 ++++++++-------
>  6 files changed, 133 insertions(+), 38 deletions(-)
> 
> --
> 2.7.4
>