mbox series

[V2,0/5] clk: imx: fix bus critical clk registration

Message ID 1603285820-30196-1-git-send-email-peng.fan@nxp.com (mailing list archive)
Headers show
Series clk: imx: fix bus critical clk registration | expand

Message

Peng Fan Oct. 21, 2020, 1:10 p.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

V2:
  Add missed Reported-by tag
  Add R-b tag

The issue is exposed by
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/
linux.git/commit/?h=for-next&id=936c383673b9e3007432f17140ac62de53d87db9

Since the upper patch not in Linus tree, I not add Fixed tag.

The issue is bus clk should be registered using bus composite api, not
peripheral api. Otherwise we will met failed to assigned clock parents error log.
Because peripheral critical clk has CLK_SET_PARENT_GATE and CLK_IS_CRITICAL,
you will not able to set clk parents.

We need use bus critical clk api to register the clks, so introduce
a new helper and use it.

Peng Fan (5):
  clk: imx: add imx8m_clk_hw_composite_bus_critical
  clk: imx8mq: fix noc and noc_io registration
  clk: imx8mm: fix bus critical clk registration
  clk: imx8mn: fix bus critical clk registration
  clk: imx8mp: fix bus critical clk registration

 drivers/clk/imx/clk-imx8mm.c | 10 +++++-----
 drivers/clk/imx/clk-imx8mn.c |  6 +++---
 drivers/clk/imx/clk-imx8mp.c | 10 +++++-----
 drivers/clk/imx/clk-imx8mq.c |  8 ++++----
 drivers/clk/imx/clk.h        |  5 +++++
 5 files changed, 22 insertions(+), 17 deletions(-)

Comments

Shawn Guo Nov. 1, 2020, 7:54 a.m. UTC | #1 
On Wed, Oct 21, 2020 at 09:10:15PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> V2:
>   Add missed Reported-by tag
>   Add R-b tag

I do not see either tag on any of the patches.

> 
> The issue is exposed by
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/
> linux.git/commit/?h=for-next&id=936c383673b9e3007432f17140ac62de53d87db9
> 
> Since the upper patch not in Linus tree, I not add Fixed tag.

It should be landed now.

Shawn

> 
> The issue is bus clk should be registered using bus composite api, not
> peripheral api. Otherwise we will met failed to assigned clock parents error log.
> Because peripheral critical clk has CLK_SET_PARENT_GATE and CLK_IS_CRITICAL,
> you will not able to set clk parents.
> 
> We need use bus critical clk api to register the clks, so introduce
> a new helper and use it.
> 
> Peng Fan (5):
>   clk: imx: add imx8m_clk_hw_composite_bus_critical
>   clk: imx8mq: fix noc and noc_io registration
>   clk: imx8mm: fix bus critical clk registration
>   clk: imx8mn: fix bus critical clk registration
>   clk: imx8mp: fix bus critical clk registration
> 
>  drivers/clk/imx/clk-imx8mm.c | 10 +++++-----
>  drivers/clk/imx/clk-imx8mn.c |  6 +++---
>  drivers/clk/imx/clk-imx8mp.c | 10 +++++-----
>  drivers/clk/imx/clk-imx8mq.c |  8 ++++----
>  drivers/clk/imx/clk.h        |  5 +++++
>  5 files changed, 22 insertions(+), 17 deletions(-)
> 
> -- 
> 2.28.0
>