mbox series

[v5,0/4] DCMI BT656 parallel bus mode support

Message ID 1604511132-4014-1-git-send-email-hugues.fruchet@st.com (mailing list archive)
Headers show
Series DCMI BT656 parallel bus mode support | expand

Message

Hugues FRUCHET Nov. 4, 2020, 5:32 p.m. UTC
Add support of BT656 embedded synchronization bus.
This mode allows to save hardware synchro lines hsync & vsync
by replacing them with synchro codes embedded in data stream.
Add "bus-type" property and make it required so that there is no
ambiguity between parallel mode (bus-type=5) and BT656 mode (bus-type=6).

===========
= history =
===========
version 5:
  - Add revisited bindings and devicetree with explicit use of "bus-type"

version 4:
  - Fix typo in commit message

version 3:
  - Fix bus_width print to %u as per Sakari comment

version 2:
  - As per Sakari remark, revisit commit message and document
    BT656 parallel bus mode in bindings

version 1:
  - Initial submission

Hugues Fruchet (4):
  media: stm32-dcmi: add support of BT656 bus
  media: dt-bindings: media: st,stm32-dcmi: add support of BT656 bus
  ARM: dts: stm32: set bus-type in DCMI endpoint for stm32mp157c-ev1
    board
  ARM: dts: stm32: set bus-type in DCMI endpoint for stm32429i-eval
    board

 .../devicetree/bindings/media/st,stm32-dcmi.yaml   | 38 ++++++++++++++++++++++
 arch/arm/boot/dts/stm32429i-eval.dts               |  1 +
 arch/arm/boot/dts/stm32mp157c-ev1.dts              |  1 +
 drivers/media/platform/stm32/stm32-dcmi.c          | 37 +++++++++++++++++++--
 4 files changed, 75 insertions(+), 2 deletions(-)

Comments

Sakari Ailus Nov. 5, 2020, 8:29 a.m. UTC | #1
Hi Hugues,

On Wed, Nov 04, 2020 at 06:32:08PM +0100, Hugues Fruchet wrote:
> Add support of BT656 embedded synchronization bus.
> This mode allows to save hardware synchro lines hsync & vsync
> by replacing them with synchro codes embedded in data stream.
> Add "bus-type" property and make it required so that there is no
> ambiguity between parallel mode (bus-type=5) and BT656 mode (bus-type=6).

Thanks for the update.

Regarding the two last patches, which tree they're intended to go to?
Something else than media? I can also take them if it's ok for the
maintainer of the "right" tree.
Alexandre TORGUE Nov. 5, 2020, 9:26 a.m. UTC | #2
Hi Huges

On 11/4/20 6:32 PM, Hugues Fruchet wrote:
> Add support of BT656 embedded synchronization bus.
> This mode allows to save hardware synchro lines hsync & vsync
> by replacing them with synchro codes embedded in data stream.
> Add "bus-type" property and make it required so that there is no
> ambiguity between parallel mode (bus-type=5) and BT656 mode (bus-type=6).
> 
> ===========
> = history =
> ===========
> version 5:
>    - Add revisited bindings and devicetree with explicit use of "bus-type"
> 
> version 4:
>    - Fix typo in commit message
> 
> version 3:
>    - Fix bus_width print to %u as per Sakari comment
> 
> version 2:
>    - As per Sakari remark, revisit commit message and document
>      BT656 parallel bus mode in bindings
> 
> version 1:
>    - Initial submission
> 
> Hugues Fruchet (4):
>    media: stm32-dcmi: add support of BT656 bus
>    media: dt-bindings: media: st,stm32-dcmi: add support of BT656 bus
>    ARM: dts: stm32: set bus-type in DCMI endpoint for stm32mp157c-ev1
>      board
>    ARM: dts: stm32: set bus-type in DCMI endpoint for stm32429i-eval
>      board
> 
>   .../devicetree/bindings/media/st,stm32-dcmi.yaml   | 38 ++++++++++++++++++++++
>   arch/arm/boot/dts/stm32429i-eval.dts               |  1 +
>   arch/arm/boot/dts/stm32mp157c-ev1.dts              |  1 +
>   drivers/media/platform/stm32/stm32-dcmi.c          | 37 +++++++++++++++++++--
>   4 files changed, 75 insertions(+), 2 deletions(-)
> 

I'll take DT patches on stm32-next tree.

regards
alex
Sakari Ailus Nov. 6, 2020, 11:53 a.m. UTC | #3
Hi Alexandre,

On Thu, Nov 05, 2020 at 10:26:37AM +0100, Alexandre Torgue wrote:
> Hi Huges
> 
> On 11/4/20 6:32 PM, Hugues Fruchet wrote:
> > Add support of BT656 embedded synchronization bus.
> > This mode allows to save hardware synchro lines hsync & vsync
> > by replacing them with synchro codes embedded in data stream.
> > Add "bus-type" property and make it required so that there is no
> > ambiguity between parallel mode (bus-type=5) and BT656 mode (bus-type=6).
> > 
> > ===========
> > = history =
> > ===========
> > version 5:
> >    - Add revisited bindings and devicetree with explicit use of "bus-type"
> > 
> > version 4:
> >    - Fix typo in commit message
> > 
> > version 3:
> >    - Fix bus_width print to %u as per Sakari comment
> > 
> > version 2:
> >    - As per Sakari remark, revisit commit message and document
> >      BT656 parallel bus mode in bindings
> > 
> > version 1:
> >    - Initial submission
> > 
> > Hugues Fruchet (4):
> >    media: stm32-dcmi: add support of BT656 bus
> >    media: dt-bindings: media: st,stm32-dcmi: add support of BT656 bus
> >    ARM: dts: stm32: set bus-type in DCMI endpoint for stm32mp157c-ev1
> >      board
> >    ARM: dts: stm32: set bus-type in DCMI endpoint for stm32429i-eval
> >      board
> > 
> >   .../devicetree/bindings/media/st,stm32-dcmi.yaml   | 38 ++++++++++++++++++++++
> >   arch/arm/boot/dts/stm32429i-eval.dts               |  1 +
> >   arch/arm/boot/dts/stm32mp157c-ev1.dts              |  1 +
> >   drivers/media/platform/stm32/stm32-dcmi.c          | 37 +++++++++++++++++++--
> >   4 files changed, 75 insertions(+), 2 deletions(-)
> > 
> 
> I'll take DT patches on stm32-next tree.

Just checking: that is only the two last patches in the set, or also the
binding patch?
Alexandre TORGUE Nov. 9, 2020, 8:37 a.m. UTC | #4
Hi Sakari

On 11/6/20 12:53 PM, Sakari Ailus wrote:
> Hi Alexandre,
> 
> On Thu, Nov 05, 2020 at 10:26:37AM +0100, Alexandre Torgue wrote:
>> Hi Huges
>>
>> On 11/4/20 6:32 PM, Hugues Fruchet wrote:
>>> Add support of BT656 embedded synchronization bus.
>>> This mode allows to save hardware synchro lines hsync & vsync
>>> by replacing them with synchro codes embedded in data stream.
>>> Add "bus-type" property and make it required so that there is no
>>> ambiguity between parallel mode (bus-type=5) and BT656 mode (bus-type=6).
>>>
>>> ===========
>>> = history =
>>> ===========
>>> version 5:
>>>     - Add revisited bindings and devicetree with explicit use of "bus-type"
>>>
>>> version 4:
>>>     - Fix typo in commit message
>>>
>>> version 3:
>>>     - Fix bus_width print to %u as per Sakari comment
>>>
>>> version 2:
>>>     - As per Sakari remark, revisit commit message and document
>>>       BT656 parallel bus mode in bindings
>>>
>>> version 1:
>>>     - Initial submission
>>>
>>> Hugues Fruchet (4):
>>>     media: stm32-dcmi: add support of BT656 bus
>>>     media: dt-bindings: media: st,stm32-dcmi: add support of BT656 bus
>>>     ARM: dts: stm32: set bus-type in DCMI endpoint for stm32mp157c-ev1
>>>       board
>>>     ARM: dts: stm32: set bus-type in DCMI endpoint for stm32429i-eval
>>>       board
>>>
>>>    .../devicetree/bindings/media/st,stm32-dcmi.yaml   | 38 ++++++++++++++++++++++
>>>    arch/arm/boot/dts/stm32429i-eval.dts               |  1 +
>>>    arch/arm/boot/dts/stm32mp157c-ev1.dts              |  1 +
>>>    drivers/media/platform/stm32/stm32-dcmi.c          | 37 +++++++++++++++++++--
>>>    4 files changed, 75 insertions(+), 2 deletions(-)
>>>
>>
>> I'll take DT patches on stm32-next tree.
> 
> Just checking: that is only the two last patches in the set, or also the
> binding patch?

Usually I let drivers/subsystem maintainer taking dt-bindings patches 
with drivers patches.
(If binding changes come only with dts(i) patches I take them in my tree)

-->So yes I'll take only the last two patches.

Regards
alex
Alexandre TORGUE Nov. 9, 2020, 11:16 a.m. UTC | #5
Hi Hugues

On 11/4/20 6:32 PM, Hugues Fruchet wrote:
> Add support of BT656 embedded synchronization bus.
> This mode allows to save hardware synchro lines hsync & vsync
> by replacing them with synchro codes embedded in data stream.
> Add "bus-type" property and make it required so that there is no
> ambiguity between parallel mode (bus-type=5) and BT656 mode (bus-type=6).
> 
> ===========
> = history =
> ===========
> version 5:
>    - Add revisited bindings and devicetree with explicit use of "bus-type"
> 
> version 4:
>    - Fix typo in commit message
> 
> version 3:
>    - Fix bus_width print to %u as per Sakari comment
> 
> version 2:
>    - As per Sakari remark, revisit commit message and document
>      BT656 parallel bus mode in bindings
> 
> version 1:
>    - Initial submission
> 
> Hugues Fruchet (4):
>    media: stm32-dcmi: add support of BT656 bus
>    media: dt-bindings: media: st,stm32-dcmi: add support of BT656 bus
>    ARM: dts: stm32: set bus-type in DCMI endpoint for stm32mp157c-ev1
>      board
>    ARM: dts: stm32: set bus-type in DCMI endpoint for stm32429i-eval
>      board
> 
>   .../devicetree/bindings/media/st,stm32-dcmi.yaml   | 38 ++++++++++++++++++++++
>   arch/arm/boot/dts/stm32429i-eval.dts               |  1 +
>   arch/arm/boot/dts/stm32mp157c-ev1.dts              |  1 +
>   drivers/media/platform/stm32/stm32-dcmi.c          | 37 +++++++++++++++++++--
>   4 files changed, 75 insertions(+), 2 deletions(-)
> 

DT patches applied on stm32-next.

Cheers
Alex
Sakari Ailus Nov. 9, 2020, 11:46 p.m. UTC | #6
On Mon, Nov 09, 2020 at 09:37:51AM +0100, Alexandre Torgue wrote:
> Hi Sakari
> 
> On 11/6/20 12:53 PM, Sakari Ailus wrote:
> > Hi Alexandre,
> > 
> > On Thu, Nov 05, 2020 at 10:26:37AM +0100, Alexandre Torgue wrote:
> > > Hi Huges
> > > 
> > > On 11/4/20 6:32 PM, Hugues Fruchet wrote:
> > > > Add support of BT656 embedded synchronization bus.
> > > > This mode allows to save hardware synchro lines hsync & vsync
> > > > by replacing them with synchro codes embedded in data stream.
> > > > Add "bus-type" property and make it required so that there is no
> > > > ambiguity between parallel mode (bus-type=5) and BT656 mode (bus-type=6).
> > > > 
> > > > ===========
> > > > = history =
> > > > ===========
> > > > version 5:
> > > >     - Add revisited bindings and devicetree with explicit use of "bus-type"
> > > > 
> > > > version 4:
> > > >     - Fix typo in commit message
> > > > 
> > > > version 3:
> > > >     - Fix bus_width print to %u as per Sakari comment
> > > > 
> > > > version 2:
> > > >     - As per Sakari remark, revisit commit message and document
> > > >       BT656 parallel bus mode in bindings
> > > > 
> > > > version 1:
> > > >     - Initial submission
> > > > 
> > > > Hugues Fruchet (4):
> > > >     media: stm32-dcmi: add support of BT656 bus
> > > >     media: dt-bindings: media: st,stm32-dcmi: add support of BT656 bus
> > > >     ARM: dts: stm32: set bus-type in DCMI endpoint for stm32mp157c-ev1
> > > >       board
> > > >     ARM: dts: stm32: set bus-type in DCMI endpoint for stm32429i-eval
> > > >       board
> > > > 
> > > >    .../devicetree/bindings/media/st,stm32-dcmi.yaml   | 38 ++++++++++++++++++++++
> > > >    arch/arm/boot/dts/stm32429i-eval.dts               |  1 +
> > > >    arch/arm/boot/dts/stm32mp157c-ev1.dts              |  1 +
> > > >    drivers/media/platform/stm32/stm32-dcmi.c          | 37 +++++++++++++++++++--
> > > >    4 files changed, 75 insertions(+), 2 deletions(-)
> > > > 
> > > 
> > > I'll take DT patches on stm32-next tree.
> > 
> > Just checking: that is only the two last patches in the set, or also the
> > binding patch?
> 
> Usually I let drivers/subsystem maintainer taking dt-bindings patches with
> drivers patches.
> (If binding changes come only with dts(i) patches I take them in my tree)
> 
> -->So yes I'll take only the last two patches.

Ack, thanks!