mbox series

[v2,0/4] perf vendor events arm64: Some tidy-up/refactoring

Message ID 1611835236-34696-1-git-send-email-john.garry@huawei.com (mailing list archive)
Headers show
Series perf vendor events arm64: Some tidy-up/refactoring | expand

Message

John Garry Jan. 28, 2021, noon UTC
There is much event duplication in the common and uarch events for A76
and Ampere eMag support, so factor out into a common JSON.

Since the wording for events may differ between CPU datasheet and
the architecture reference manual, the current wording is kept. This
is unless there are minor differences. In addition, event names are
renamed to be same as architecture reference manual, to keep commonality.

Also a minor fix is included for the Ampere eMag JSON.

Differences to v1:
- tidy some ',' misplaced

John Garry (4):
  perf vendor events arm64: Fix Ampere eMag event typo
  perf vendor events arm64: Add common and uarch event JSON
  perf vendor events arm64: Reference common and uarch events for Ampere
    eMag
  perf vendor events arm64: Reference common and uarch events for A76

 .../arch/arm64/ampere/emag/branch.json        |   8 +-
 .../arch/arm64/ampere/emag/bus.json           |   5 +-
 .../arch/arm64/ampere/emag/cache.json         |  58 +---
 .../arch/arm64/ampere/emag/clock.json         |   4 +-
 .../arch/arm64/ampere/emag/exception.json     |  10 +-
 .../arch/arm64/ampere/emag/instruction.json   |  34 +--
 .../arch/arm64/ampere/emag/memory.json        |  11 +-
 .../arch/arm64/arm/cortex-a76-n1/branch.json  |  12 +-
 .../arch/arm64/arm/cortex-a76-n1/bus.json     |  19 +-
 .../arch/arm64/arm/cortex-a76-n1/cache.json   | 118 +++------
 .../arm64/arm/cortex-a76-n1/exception.json    |  10 +-
 .../arm64/arm/cortex-a76-n1/instruction.json  |  45 +---
 .../arch/arm64/arm/cortex-a76-n1/memory.json  |   6 +-
 .../arch/arm64/arm/cortex-a76-n1/other.json   |   4 +-
 .../arm64/arm/cortex-a76-n1/pipeline.json     |  12 +-
 .../arm64/armv8-common-and-microarch.json     | 248 ++++++++++++++++++
 16 files changed, 356 insertions(+), 248 deletions(-)
 create mode 100644 tools/perf/pmu-events/arch/arm64/armv8-common-and-microarch.json

Comments

Will Deacon Jan. 28, 2021, 8:18 p.m. UTC | #1
On Thu, Jan 28, 2021 at 08:00:32PM +0800, John Garry wrote:
> There is much event duplication in the common and uarch events for A76
> and Ampere eMag support, so factor out into a common JSON.
> 
> Since the wording for events may differ between CPU datasheet and
> the architecture reference manual, the current wording is kept. This
> is unless there are minor differences. In addition, event names are
> renamed to be same as architecture reference manual, to keep commonality.
> 
> Also a minor fix is included for the Ampere eMag JSON.
> 
> Differences to v1:
> - tidy some ',' misplaced
> 
> John Garry (4):
>   perf vendor events arm64: Fix Ampere eMag event typo
>   perf vendor events arm64: Add common and uarch event JSON
>   perf vendor events arm64: Reference common and uarch events for Ampere
>     eMag
>   perf vendor events arm64: Reference common and uarch events for A76

For the series:

Acked-by: Will Deacon <will@kernel.org>

Will