From patchwork Wed Sep 15 09:07:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 12495841 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89665C433F5 for ; Wed, 15 Sep 2021 09:15:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D91A6121E for ; Wed, 15 Sep 2021 09:15:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D91A6121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=XlnxSWlcJSiXah9Z1wMSqexKiECxEcY1x0RdnVMERUw=; b=rgN7x3Cd8OXSZn CKQlyWBtlmVlzV693ImcB3dnbIQIEm8twre2ZBxcogK5F5ivHERGurz8/c1Zc9poEUvNRWvgdTOLn KcQuiFrmte8F/+23k+Ip984mPuLAH+ehZ/cWM2UoBob5+AD4/K6NMutE91Qo3HFUA06JRrph1GAUe IHmwv5KpvRQLYFqVg/Hg4Lg/WbEniQ6e/cC+2RPrjGi19+5SlYEdYzcdTJeZEwwDfIemED9qSjyw6 VeaDEbhFc96cKdeL5A3fQi+AMhavOjauWI1uwTwMH1v24mUbMX+dDv6sLnb/bzTx/WD4A8s+4PyMT r2qjcOiSGMikcwDrP5YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQQyf-008ccF-1Q; Wed, 15 Sep 2021 09:13:13 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQQxp-008cNW-2w for linux-arm-kernel@lists.infradead.org; Wed, 15 Sep 2021 09:12:22 +0000 Received: from fraeml711-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4H8ZDD3L38z6H7hQ; Wed, 15 Sep 2021 17:09:48 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml711-chm.china.huawei.com (10.206.15.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 15 Sep 2021 11:12:12 +0200 Received: from localhost.localdomain (10.69.192.58) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 15 Sep 2021 10:12:10 +0100 From: John Garry To: , , , CC: , , , John Garry Subject: [PATCH v2 0/3] scsi: remove last references to scsi_cmnd.tag Date: Wed, 15 Sep 2021 17:07:12 +0800 Message-ID: <1631696835-136198-1-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 X-Originating-IP: [10.69.192.58] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210915_021221_303256_B09E35EE X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is v2 of Hannes' series to fix the build errors from removing scsi_cmnd.tag. Here is the original cover letter: "with commit 4c7b6ea336c1 ("scsi: core: Remove scsi_cmnd.tag") drivers cannot reference the SCSI command tag anymore. Arguably these drivers would have stopped working since 2010 with the switch to block layer tags in SCSI anyway, so chances are no-one had been using tagging in these drivers. This patchset fixes up these usage; for fas216 we're just switching to use the appropriate wrapper. For acornscsi the tagged queue handling is removed altogether as it was broken in the first place, and no-one since the switch to git could be bothered to fix it. And the patchset has the nice side-effect that we can remove the scsi_device.current_tag field." AFAIK, only the arm rpc_defconfig build was broken. I dropped the scsi_cmd_to_tag() patch as it was not strictly necessary here and there was some doubt on its need. The "scsi: remove 'current_tag'" patch is not needed as a fix. Baseline is v5.15-rc1 Hannes Reinecke (3): fas216: kill scmd->tag acornscsi: remove tagged queuing vestiges scsi: remove 'current_tag' drivers/scsi/arm/Kconfig | 11 ---- drivers/scsi/arm/acornscsi.c | 103 ++++++++--------------------------- drivers/scsi/arm/fas216.c | 31 +++-------- drivers/scsi/arm/queue.c | 2 +- include/scsi/scsi_device.h | 1 - 5 files changed, 31 insertions(+), 117 deletions(-)