mbox series

[0/2] Add rs485 support to uartps driver

Message ID 1682512187-8828-1-git-send-email-manikanta.guntupalli@amd.com (mailing list archive)
Headers show
Series Add rs485 support to uartps driver | expand

Message

Manikanta Guntupalli April 26, 2023, 12:29 p.m. UTC 
Add optional gpio property to uartps node to support rs485
Add rs485 support to uartps driver

Manikanta Guntupalli (2):
  dt-bindings: Add optional gpio property to uartps node to support
    rs485
  tty: serial: uartps: Add rs485 support to uartps driver

 .../devicetree/bindings/serial/cdns,uart.yaml |  5 +
 drivers/tty/serial/xilinx_uartps.c            | 96 ++++++++++++++++++-
 2 files changed, 100 insertions(+), 1 deletion(-)

Comments

Maarten Brock May 4, 2023, 12:22 p.m. UTC | #1 
Manikanta Guntupalli wrote 2023-04-26 14:29:
> Add optional gpio property to uartps node to support rs485
> Add rs485 support to uartps driver
> 
> Manikanta Guntupalli (2):
>   dt-bindings: Add optional gpio property to uartps node to support
>     rs485
>   tty: serial: uartps: Add rs485 support to uartps driver
> 
>  .../devicetree/bindings/serial/cdns,uart.yaml |  5 +
>  drivers/tty/serial/xilinx_uartps.c            | 96 ++++++++++++++++++-
>  2 files changed, 100 insertions(+), 1 deletion(-)

Why would you want to use a GPIO and not RTS for choosing the direction
as is more common in this case?
And have you thought about configuring the polarity?
How long will the signal be active before the real transmission begins
so the driver can settle?

Maarten