| Message ID | 1695621444-56530-1-git-send-email-renyu.zj@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add metrics for Arm CMN | expand |
On Sun, Sep 24, 2023 at 10:58 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > > Changes since v8: > - Add fully match identifier check as suggested by Ian. > - Link: https://lore.kernel.org/lkml/1695037955-107983-1-git-send-email-renyu.zj@linux.alibaba.com/ > > Jing Zhang (7): > perf pmu: "Compat" supports regular expression matching identifiers > perf metric: "Compat" supports regular expression matching identifiers > perf jevents: Support EventidCode and NodeType > perf test: Make matching_pmu effective > perf test: Add pmu-event test for "Compat" and new event_field. > perf jevents: Add support for Arm CMN PMU aliasing > perf vendor events: Add JSON metrics for Arm CMN Thanks for the patience with all the to and fro. I was able to test the series with "git am -3" to get around a merge issue on perf-tools-next. Reviewed-by: Ian Rogers <irogers@google.com> Tested-by: Ian Rogers <irogers@google.com> Thanks, Ian > .../pmu-events/arch/arm64/arm/cmn/sys/cmn.json | 266 +++++++++++++++++++++ > .../pmu-events/arch/arm64/arm/cmn/sys/metric.json | 74 ++++++ > .../pmu-events/arch/test/test_soc/sys/uncore.json | 8 + > tools/perf/pmu-events/empty-pmu-events.c | 8 + > tools/perf/pmu-events/jevents.py | 11 +- > tools/perf/tests/pmu-events.c | 65 ++++- > tools/perf/util/metricgroup.c | 2 +- > tools/perf/util/pmu.c | 27 ++- > tools/perf/util/pmu.h | 1 + > 9 files changed, 456 insertions(+), 6 deletions(-) > create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json > create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/metric.json > > -- > 1.8.3.1 >
在 2023/9/26 上午12:37, Ian Rogers 写道: > On Sun, Sep 24, 2023 at 10:58 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: >> >> Changes since v8: >> - Add fully match identifier check as suggested by Ian. >> - Link: https://lore.kernel.org/lkml/1695037955-107983-1-git-send-email-renyu.zj@linux.alibaba.com/ >> >> Jing Zhang (7): >> perf pmu: "Compat" supports regular expression matching identifiers >> perf metric: "Compat" supports regular expression matching identifiers >> perf jevents: Support EventidCode and NodeType >> perf test: Make matching_pmu effective >> perf test: Add pmu-event test for "Compat" and new event_field. >> perf jevents: Add support for Arm CMN PMU aliasing >> perf vendor events: Add JSON metrics for Arm CMN > > Thanks for the patience with all the to and fro. I was able to test > the series with "git am -3" to get around a merge issue on > perf-tools-next. > > Reviewed-by: Ian Rogers <irogers@google.com> > Tested-by: Ian Rogers <irogers@google.com> > Thank you for following this series and providing many valuable suggestions. Thanks, Jing > Thanks, > Ian > >> .../pmu-events/arch/arm64/arm/cmn/sys/cmn.json | 266 +++++++++++++++++++++ >> .../pmu-events/arch/arm64/arm/cmn/sys/metric.json | 74 ++++++ >> .../pmu-events/arch/test/test_soc/sys/uncore.json | 8 + >> tools/perf/pmu-events/empty-pmu-events.c | 8 + >> tools/perf/pmu-events/jevents.py | 11 +- >> tools/perf/tests/pmu-events.c | 65 ++++- >> tools/perf/util/metricgroup.c | 2 +- >> tools/perf/util/pmu.c | 27 ++- >> tools/perf/util/pmu.h | 1 + >> 9 files changed, 456 insertions(+), 6 deletions(-) >> create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json >> create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/metric.json >> >> -- >> 1.8.3.1 >>
Hello, On Mon, Sep 25, 2023 at 8:15 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > > > > 在 2023/9/26 上午12:37, Ian Rogers 写道: > > On Sun, Sep 24, 2023 at 10:58 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > >> > >> Changes since v8: > >> - Add fully match identifier check as suggested by Ian. > >> - Link: https://lore.kernel.org/lkml/1695037955-107983-1-git-send-email-renyu.zj@linux.alibaba.com/ > >> > >> Jing Zhang (7): > >> perf pmu: "Compat" supports regular expression matching identifiers > >> perf metric: "Compat" supports regular expression matching identifiers > >> perf jevents: Support EventidCode and NodeType > >> perf test: Make matching_pmu effective > >> perf test: Add pmu-event test for "Compat" and new event_field. > >> perf jevents: Add support for Arm CMN PMU aliasing > >> perf vendor events: Add JSON metrics for Arm CMN > > > > Thanks for the patience with all the to and fro. I was able to test > > the series with "git am -3" to get around a merge issue on > > perf-tools-next. > > > > Reviewed-by: Ian Rogers <irogers@google.com> > > Tested-by: Ian Rogers <irogers@google.com> > > > > Thank you for following this series and providing many valuable suggestions. It's not applied cleanly. Can you please rebase onto the current tmp.perf-tools-next branch in the following tree? git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git Thanks, Namhyung
在 2023/9/27 上午9:00, Namhyung Kim 写道: > Hello, > > On Mon, Sep 25, 2023 at 8:15 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: >> >> >> >> 在 2023/9/26 上午12:37, Ian Rogers 写道: >>> On Sun, Sep 24, 2023 at 10:58 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: >>>> >>>> Changes since v8: >>>> - Add fully match identifier check as suggested by Ian. >>>> - Link: https://lore.kernel.org/lkml/1695037955-107983-1-git-send-email-renyu.zj@linux.alibaba.com/ >>>> >>>> Jing Zhang (7): >>>> perf pmu: "Compat" supports regular expression matching identifiers >>>> perf metric: "Compat" supports regular expression matching identifiers >>>> perf jevents: Support EventidCode and NodeType >>>> perf test: Make matching_pmu effective >>>> perf test: Add pmu-event test for "Compat" and new event_field. >>>> perf jevents: Add support for Arm CMN PMU aliasing >>>> perf vendor events: Add JSON metrics for Arm CMN >>> >>> Thanks for the patience with all the to and fro. I was able to test >>> the series with "git am -3" to get around a merge issue on >>> perf-tools-next. >>> >>> Reviewed-by: Ian Rogers <irogers@google.com> >>> Tested-by: Ian Rogers <irogers@google.com> >>> >> >> Thank you for following this series and providing many valuable suggestions. > > It's not applied cleanly. Can you please rebase onto the current > tmp.perf-tools-next branch in the following tree? > > git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git > Hi Namhyung, I have sent v11[1] which rebase onto latest tmp.perf-tools-next branch. Please help to apply it, thanks. [1] https://lore.kernel.org/all/1695794391-34817-1-git-send-email-renyu.zj@linux.alibaba.com/ Thanks, Jing > Thanks, > Namhyung
On Tue, Sep 26, 2023 at 11:06 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > > > > 在 2023/9/27 上午9:00, Namhyung Kim 写道: > > Hello, > > > > On Mon, Sep 25, 2023 at 8:15 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > >> > >> > >> > >> 在 2023/9/26 上午12:37, Ian Rogers 写道: > >>> On Sun, Sep 24, 2023 at 10:58 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > >>>> > >>>> Changes since v8: > >>>> - Add fully match identifier check as suggested by Ian. > >>>> - Link: https://lore.kernel.org/lkml/1695037955-107983-1-git-send-email-renyu.zj@linux.alibaba.com/ > >>>> > >>>> Jing Zhang (7): > >>>> perf pmu: "Compat" supports regular expression matching identifiers > >>>> perf metric: "Compat" supports regular expression matching identifiers > >>>> perf jevents: Support EventidCode and NodeType > >>>> perf test: Make matching_pmu effective > >>>> perf test: Add pmu-event test for "Compat" and new event_field. > >>>> perf jevents: Add support for Arm CMN PMU aliasing > >>>> perf vendor events: Add JSON metrics for Arm CMN > >>> > >>> Thanks for the patience with all the to and fro. I was able to test > >>> the series with "git am -3" to get around a merge issue on > >>> perf-tools-next. > >>> > >>> Reviewed-by: Ian Rogers <irogers@google.com> > >>> Tested-by: Ian Rogers <irogers@google.com> > >>> > >> > >> Thank you for following this series and providing many valuable suggestions. > > > > It's not applied cleanly. Can you please rebase onto the current > > tmp.perf-tools-next branch in the following tree? > > > > git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git > > > > Hi Namhyung, > > I have sent v11[1] which rebase onto latest tmp.perf-tools-next branch. Please help to apply it, thanks. > > [1] https://lore.kernel.org/all/1695794391-34817-1-git-send-email-renyu.zj@linux.alibaba.com/ Yep, it looks good... testing now. Thanks, Namhyung