| Message ID | 20180724125238.14567-1-jbrunet@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: meson-axg: add audio support | expand |
Hi Jerome, On Tue, Jul 24, 2018 at 2:53 PM Jerome Brunet <jbrunet@baylibre.com> wrote: > > The main purpose of this patchset is to add the audio devices on amlogic's > AXG SoCs. > > Some codecs require some power supplies. This is why the 3 first patches > deal with the S400 power supplies, even if some are not related to audio. > > In term of dependency, apart from the clock bindings you have already > pulled for your second PR to arm-soc, this patchset requires the ARB > reset bindings [0] for patch 5. I don't know if Philip can make it > available somewhere ? > > Of course, if the dependencies make this patchset too complicated to > merge in this cycle, I'll resubmit once the next rc1 is out. > > Jerome Brunet (14): > arm64: dts: meson-axg: improve power supplies description > arm64: dts: meson-axg: add vcc 5v regulator on the s400 > arm64: dts: meson-axg: add usb power regulator > arm64: dts: meson-axg: add audio arb reset controller > arm64: dts: meson-axg: add audio fifos > arm64: dts: meson-axg: add spdifout > arm64: dts: meson-axg: add tdmin formatters > arm64: dts: meson-axg: add tdmout formatters > arm64: dts: meson-axg: add tdm interfaces > arm64: dts: meson-axg: add linein codec > arm64: dts: meson-axg: add lineout codec > arm64: dts: meson-axg: add spdif-dit codec > arm64: dts: meson-axg: s400: enable audio devices > arm64: dts: meson-axg: add s400 sound card nit-pick: one patch uses "arm64: dts: meson-axg: s400" in the subject while other patches that are touching the s400 board aren't if you have to re-send this series: can you please use the "arm64: dts: meson-axg: s400:" prefix for all patches touching the s400 board? Thank you! Regards Martin
On Wed, 2018-07-25 at 21:11 +0200, Martin Blumenstingl wrote: > nit-pick: one patch uses "arm64: dts: meson-axg: s400" in the subject > while other patches that are touching the s400 board aren't > if you have to re-send this series: can you please use the "arm64: > dts: meson-axg: s400:" prefix for all patches touching the s400 board? hum, do we really have such rule, or do you think we should add one ? Kevin, do you have opinion ? Not that I really mind either way, but prefixes rules are usually there to help maintainer filter the patches. Will such rule help in any way ?
Hi Jerome, On Wed, Jul 25, 2018 at 11:19 PM <jbrunet@baylibre.com> wrote: > > On Wed, 2018-07-25 at 21:11 +0200, Martin Blumenstingl wrote: > > nit-pick: one patch uses "arm64: dts: meson-axg: s400" in the subject > > while other patches that are touching the s400 board aren't > > if you have to re-send this series: can you please use the "arm64: > > dts: meson-axg: s400:" prefix for all patches touching the s400 board? > > hum, do we really have such rule, or do you think we should add one ? looking at the git history in arch/arm64/boot/dts/amlogic: it seems that we don't have a rule yet, even though some (some of your's/Neil's/my) patches were using that naming schema in the past > Kevin, do you have opinion ? > > Not that I really mind either way, but prefixes rules are usually there to help > maintainer filter the patches. Will such rule help in any way ? maybe it's just a problem of a false initial impression I read "arm64: dts: meson-axg: add usb power regulator" in the cover-letter and came to the conclusion that this patch must be wrong since meson-axg.dtsi should not have any regulators (unless they're built into the SoC). only when looking at the patch itself I realized that it's fine because it patches the s400.dts Regards Martin
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > Hi Jerome, > > On Wed, Jul 25, 2018 at 11:19 PM <jbrunet@baylibre.com> wrote: >> >> On Wed, 2018-07-25 at 21:11 +0200, Martin Blumenstingl wrote: >> > nit-pick: one patch uses "arm64: dts: meson-axg: s400" in the subject >> > while other patches that are touching the s400 board aren't >> > if you have to re-send this series: can you please use the "arm64: >> > dts: meson-axg: s400:" prefix for all patches touching the s400 board? >> >> hum, do we really have such rule, or do you think we should add one ? > looking at the git history in arch/arm64/boot/dts/amlogic: it seems > that we don't have a rule yet, even though some (some of > your's/Neil's/my) patches were using that naming schema in the past > >> Kevin, do you have opinion ? >> >> Not that I really mind either way, but prefixes rules are usually there to help >> maintainer filter the patches. Will such rule help in any way ? > maybe it's just a problem of a false initial impression > I read "arm64: dts: meson-axg: add usb power regulator" in the > cover-letter and came to the conclusion that this patch must be wrong > since meson-axg.dtsi should not have any regulators (unless they're > built into the SoC). only when looking at the patch itself I realized > that it's fine because it patches the s400.dts I actually had the same first impression problem. At first glance, it looks like all the patches are AXG-generic, and only the 2 that mention s400 apply to the board. So, if this needs a respin, I'd prefer the board name where appropriate, but it's not something I'm going to be picky about. Kevin