[v2,0/6] PCI: mvebu: cleanup and improvements

Message

Thomas Petazzoni Aug. 3, 2018, 2:38 p.m. UTC

Hello,

This is the v2 of the pci-mvebu cleanup and improvements, mainly
aiming at using pci_host_bridge.

Since v1, the changes are:

 - Rebase on v4.18-rc1 to make sure the patches apply

 - Add a patch fixing the I/O space end calculation (using
   resource_size() as the .end address of a resource is not correct)

 - Only remap the I/O space if there is a PCI I/O aperture described
   in the DT.

 - Use resource_size() in the loop mapping the I/O space, as suggested
   by Lorenzo.

 - Use pci_add_resource() instead of pci_add_resource_offset(), as
   suggested by Lorenzo.

 - Revert to using pci_ioremap_io(), since we need to map with a
   special memory type on Armada platforms, and pci_remap_iospace()
   doesn't allow to do that. Noticed by Lorenzo.

Thanks!

Thomas

Thomas Petazzoni (6):
  PCI: mvebu: Remove redundant platform_set_drvdata() call
  PCI: mvebu: fix I/O space end address calculation
  PCI: mvebu: only remap I/O space if configured
  PCI: mvebu: use resource_size() to remap I/O space
  PCI: mvebu: Convert to use pci_host_bridge directly
  PCI: mvebu: Drop bogus comment above mvebu_pcie_map_registers()

 drivers/pci/controller/pci-mvebu.c | 153 +++++++++++++++++--------------------
 1 file changed, 68 insertions(+), 85 deletions(-)

Comments

Lorenzo Pieralisi Aug. 8, 2018, 3:40 p.m. UTC | #1

On Fri, Aug 03, 2018 at 04:38:42PM +0200, Thomas Petazzoni wrote:
> Hello,
> 
> This is the v2 of the pci-mvebu cleanup and improvements, mainly
> aiming at using pci_host_bridge.
> 
> Since v1, the changes are:
> 
>  - Rebase on v4.18-rc1 to make sure the patches apply
> 
>  - Add a patch fixing the I/O space end calculation (using
>    resource_size() as the .end address of a resource is not correct)
> 
>  - Only remap the I/O space if there is a PCI I/O aperture described
>    in the DT.
> 
>  - Use resource_size() in the loop mapping the I/O space, as suggested
>    by Lorenzo.
> 
>  - Use pci_add_resource() instead of pci_add_resource_offset(), as
>    suggested by Lorenzo.
> 
>  - Revert to using pci_ioremap_io(), since we need to map with a
>    special memory type on Armada platforms, and pci_remap_iospace()
>    doesn't allow to do that. Noticed by Lorenzo.

Pulled into pci/mvebu (I reworded some commit logs in the process
please have a look) for (tentatively) v4.19 but it is a bit late
in the cycle so let's see how things go.

Thanks,
Lorenzo

> 
> Thanks!
> 
> Thomas
> 
> Thomas Petazzoni (6):
>   PCI: mvebu: Remove redundant platform_set_drvdata() call
>   PCI: mvebu: fix I/O space end address calculation
>   PCI: mvebu: only remap I/O space if configured
>   PCI: mvebu: use resource_size() to remap I/O space
>   PCI: mvebu: Convert to use pci_host_bridge directly
>   PCI: mvebu: Drop bogus comment above mvebu_pcie_map_registers()
> 
>  drivers/pci/controller/pci-mvebu.c | 153 +++++++++++++++++--------------------
>  1 file changed, 68 insertions(+), 85 deletions(-)
> 
> -- 
> 2.14.4
>