From patchwork Mon Sep 10 06:25:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Gautam X-Patchwork-Id: 10593591 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D7FF14E0 for ; Mon, 10 Sep 2018 06:26:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A5B728C91 for ; Mon, 10 Sep 2018 06:26:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4DAF428E82; Mon, 10 Sep 2018 06:26:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C02B628C91 for ; Mon, 10 Sep 2018 06:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=yDVYROChGiJQbWwCvaS9N6ZB2pjhTIkj7/ueEd2smTE=; b=oHP H14Ub+YcsIJFZBTk8SQsWKZ0+M7BZsqFKkkdzvbxAo0L3W7G1OMxrRfC9zeOTILSBbBLOk8q1Kg/P BNG0O7uKHdTBMI6NSl3swZlyo+G3h4eWp0scQQR8vxBogw8LT2qLuPhzt7ymVtUAYQUL7yjsLuxvI /Xw1XAHojyw56dZ8qy9fkmHpUQcU1NEjfW7bpkJt0IyGP2j1tEF+yM3v9OvPa49kjofCXrYW6Dcc3 zi75R6WPyDbZX6/aonHoAU8TD3Oel1OsOerTRNu4ayuark7EteeE2Bd4UapmEp6BmgnwzqsiWGqDd HXUNSievMbRk+FaCGX0r73kH94KtepA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fzFeU-0007lf-VL; Mon, 10 Sep 2018 06:26:26 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fzFeR-0007jP-7h for linux-arm-kernel@lists.infradead.org; Mon, 10 Sep 2018 06:26:25 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7C8C0607EB; Mon, 10 Sep 2018 06:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1536560772; bh=i4lACEsQgF5s2kirjXBD2e/PQzU10q26/V7kKuu1hRs=; h=From:To:Cc:Subject:Date:From; b=aFMwXSGEcyrbZoQlGNYd5C5JXSnDIPloNbwME4j5u7pEWmIFNrwdG6+S7L5gW60ew F7jXW9LA0reIyaor1WmKwRImJyTytPn94RNHCu+QI1qxhHWls1oi9lyS32pZaKOS/9 3IpbJzLgeDru//lmLS4yU+E6OMP1lov1ZHfJmlH8= Received: from blr-ubuntu-41.ap.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vivek.gautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7FE0860721; Mon, 10 Sep 2018 06:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1536560771; bh=i4lACEsQgF5s2kirjXBD2e/PQzU10q26/V7kKuu1hRs=; h=From:To:Cc:Subject:Date:From; b=AF1sa0Hd/EGO5EihjNWzBOkTkZOTLifKQDPP8Tr8lIb4iggUT1dCqyawxl91kYNz3 2egWSP/ohVnDpjq4LHyvypMdxDceqi8HZO0ogiRJfLMJHdEsq2RXj8ZdKzk2SBk3YD JRUhzgj5N0+4qd9qQh1IJU63i/yhMn3eEoOzAMTM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7FE0860721 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org From: Vivek Gautam To: joro@8bytes.org, andy.gross@linaro.org, will.deacon@arm.com, robin.murphy@arm.com, bjorn.andersson@linaro.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 0/4] Qcom smmu-500 TLB invalidation errata for sdm845 Date: Mon, 10 Sep 2018 11:55:47 +0530 Message-Id: <20180910062551.28175-1-vivek.gautam@codeaurora.org> X-Mailer: git-send-email 2.16.1.72.g5be1f00a9a70 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180909_232623_316428_D58DC80A X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, swboyd@chromium.org, david.brown@linaro.org, robdclark@gmail.com, Vivek Gautam , tfiga@chromium.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Qcom's implementation of arm,mmu-500 on sdm845 has a functional/performance errata [1] because of which the TCU cache look ups are stalled during invalidation cycle. This is mitigated by serializing all the invalidation requests coming to the smmu. This patch series addresses this errata by adding new tlb_ops for qcom,sdm845-smmu-500 [2]. These ops take context bank locks for all the tlb_ops that queue and sync the TLB invalidation requests. Besides adding locks, there's a way to expadite these TLB invalidations for display and camera devices by turning off the 'wait-for-safe' logic in hardware that holds the tlb invalidations until a safe level. This 'wait-for-safe' logic is controlled by toggling a chicken bit through a secure register. This secure register is accessed by making an explicit SCM call into the EL3 firmware. There are two ways of handling this logic - * Firmware, such as tz present on sdm845-mtp devices has a handler to do all the register access and bit set/clear. So is the handling in downstream arm-smmu driver [3]. * Other firmwares can have handlers to just read/write this secure register. In such cases the kernel make io_read/writel scm calls to modify the register. This patch series adds APIs in qcom-scm driver to handle both of these cases. Lastly, since these TLB invalidations can happen in atomic contexts there's a need to add atomic versions of qcom_scm_io_readl/writel() and qcom_scm_call() APIs. The traditional scm calls take mutex and we therefore can't use these calls in atomic contexts. This patch series is adapted version of how the errata is handled in downstream [1]. Changes since v1: * Addressed Will and Robin's comments: - Dropped the patch[4] that forked out __arm_smmu_tlb_inv_range_nosync(), and __arm_smmu_tlb_sync(). - Cleaned up the errata patch further to use downstream polling mechanism for tlb sync. * No change in SCM call patches - patches 1 to 3. [1] https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/iommu/arm-smmu.c?h=msm-4.9#n4842 [2] https://lore.kernel.org/patchwork/patch/974114/ [3] https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/iommu/arm-smmu.c?h=msm-4.9#n4864 [4] https://patchwork.kernel.org/patch/10565349/ Vivek Gautam (4): firmware: qcom_scm-64: Add atomic version of qcom_scm_call firmware/qcom_scm: Add atomic version of io read/write APIs firmware/qcom_scm: Add scm call to handle smmu errata iommu/arm-smmu: Add support to handle Qcom's TLBI serialization errata drivers/firmware/qcom_scm-32.c | 17 ++++ drivers/firmware/qcom_scm-64.c | 181 +++++++++++++++++++++++++++++++---------- drivers/firmware/qcom_scm.c | 18 ++++ drivers/firmware/qcom_scm.h | 9 ++ drivers/iommu/arm-smmu-regs.h | 2 + drivers/iommu/arm-smmu.c | 133 +++++++++++++++++++++++++++++- include/linux/qcom_scm.h | 6 ++ 7 files changed, 320 insertions(+), 46 deletions(-)