From patchwork Wed Dec 12 18:51:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Saenz Julienne X-Patchwork-Id: 10726955 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 33020112E for ; Wed, 12 Dec 2018 18:55:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23B8228760 for ; Wed, 12 Dec 2018 18:55:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 12AD02A5B7; Wed, 12 Dec 2018 18:55:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B010928760 for ; Wed, 12 Dec 2018 18:55:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6IxUbT3OqfNgQnxXI28nxTAMdWUmPO7FufR9Z2VsuQI=; b=oAs0jNvHBLA1Lm RbbWiMwDwCWCUDE6rM2KVMAoRQ3NxB/qSgSJ+9UTT5maIl3Q5YT2cA5ivMJ1C9QkJlOyWxtRLhDFG NCuW/5Lq4mUhYazitUv+LZO1edtG2brUyQAw8HwUzMM6ocY8rF7f80k8GfRQcn1C6Q76uoUh6acd/ j6FYCVXyVOMpLrzv1jMOn66ENJYUAbiA/M9eQbY1SkmEWLu1zhBQsjXDaNU788o6+PIbzUE8pE7YV Opuc4nEu6saStEEvt0dowkFQofDBXcATOcpd9cBDkaaaXmoPQFyaJveqHZcJCKy28Fzuae+KR1Tcy Y0Lf/fFnw+3FfF2G/XZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gX9eo-00004s-Pb; Wed, 12 Dec 2018 18:54:54 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gX9eb-0008IU-5H; Wed, 12 Dec 2018 18:54:42 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 919C5AEE4; Wed, 12 Dec 2018 18:54:25 +0000 (UTC) From: Nicolas Saenz Julienne To: linux-kernel@vger.kernel.org Subject: [PATCH 0/3] staging: vchiq: fix completion routines & semaphores Date: Wed, 12 Dec 2018 19:51:32 +0100 Message-Id: <20181212185136.6620-1-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181212_105441_458744_0F37EFF8 X-CRM114-Status: UNSURE ( 7.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefan.wahren@i2se.com, devel@driverdev.osuosl.org, arnd@arndb.de, gregkh@linuxfoundation.org, eric@anholt.net, linux-rpi-kernel@lists.infradead.org, Nicolas Saenz Julienne , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP As pointed out by Arnd Bergman[1] there where some issues on how I converted semaphores to completion routines. I wasn't aware of a macro override happening in vchiq_killable.h, which was changing down_interruptible()'s meaning. This patch changes all completions so they use the proper APIs and gets rid of vchiq_killable.h. I took into account Arnd's commit to avoid merge conflicts. [1] https://www.spinics.net/lists/arm-kernel/msg694422.html === Nicolas Saenz Julienne (3): staging: vchiq: switch to wait_for_completion_killable staging: vchiq_2835_arm: quit using custom down_interruptible() staging: vchiq: delete vchiq_killable.h .../interface/vchiq_arm/vchiq_2835_arm.c | 3 +- .../interface/vchiq_arm/vchiq_arm.c | 22 ++++---- .../interface/vchiq_arm/vchiq_connected.c | 1 - .../interface/vchiq_arm/vchiq_core.c | 22 ++++---- .../interface/vchiq_arm/vchiq_killable.h | 55 ------------------- .../interface/vchiq_arm/vchiq_util.c | 7 +-- 6 files changed, 24 insertions(+), 86 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_killable.h Reviewed-by: Arnd Bergmann