| Message ID | 20190214175725.60462-1-ray.jui@broadcom.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iProc I2C slave mode and NIC mode | expand |
Hi Wolfram, Rob has reviewed all DT binding related changes from this patch series. Could you please help to review the I2C driver related changes when you have time? Thanks, Ray On 2/14/2019 9:57 AM, Ray Jui wrote: > This patch series adds the following support to the iProc I2C driver: > - Increase maximum read transfer size to 255 bytes > - I2C slave mode > - Polling mode > - NIC I2C mode > > This patch series is based on kernel v5.0-rc3 and available at: > https://github.com/Broadcom/arm64-linux.git > branch: i2c-slave-v5 > > Changes from v4: > - Add more detailed explanations in the device tree binding document > changes, to address Rob's review comments > > Changes from v3: > - Various minor fixes on commit messages and commits > - Rebased to v5.0-rc3 > > Changes from v2: > - Address Ray's review comments. > > Changes from v1: > - Rebased to Linux v5.0.0-rc2 > > Ray Jui (1): > dt-bindings: i2c: iproc: make 'interrupts' optional > > Rayagonda Kokatanur (5): > i2c: iproc: add polling support > i2c: iproc: use wrapper for read/write access > dt-bindings: i2c: iproc: add "brcm,iproc-nic-i2c" compatible string > i2c: iproc: add NIC I2C support > arm64: dts: Stingray: Add NIC i2c device node > > Shreesha Rajashekar (2): > i2c: iproc: Extend I2C read up to 255 bytes > i2c: iproc: Add slave mode support > > .../bindings/i2c/brcm,iproc-i2c.txt | 17 +- > .../boot/dts/broadcom/stingray/stingray.dtsi | 18 + > drivers/i2c/busses/Kconfig | 1 + > drivers/i2c/busses/i2c-bcm-iproc.c | 758 +++++++++++++++--- > 4 files changed, 663 insertions(+), 131 deletions(-) >
On 2/22/19 12:04 PM, Ray Jui wrote: > Hi Wolfram, > > Rob has reviewed all DT binding related changes from this patch series. > Could you please help to review the I2C driver related changes when you > have time? Wolfram, did you queue those patches yet? The dt-binding patch has been reviewed by Rob, therefore I am going to queue up patch 8 for the ARM SoC pull request for 5.2. Let me know if that does not align with when you plan on sending the i2c changes, thanks! > > Thanks, > > Ray > > On 2/14/2019 9:57 AM, Ray Jui wrote: >> This patch series adds the following support to the iProc I2C driver: >> - Increase maximum read transfer size to 255 bytes >> - I2C slave mode >> - Polling mode >> - NIC I2C mode >> >> This patch series is based on kernel v5.0-rc3 and available at: >> https://github.com/Broadcom/arm64-linux.git >> branch: i2c-slave-v5 >> >> Changes from v4: >> - Add more detailed explanations in the device tree binding document >> changes, to address Rob's review comments >> >> Changes from v3: >> - Various minor fixes on commit messages and commits >> - Rebased to v5.0-rc3 >> >> Changes from v2: >> - Address Ray's review comments. >> >> Changes from v1: >> - Rebased to Linux v5.0.0-rc2 >> >> Ray Jui (1): >> dt-bindings: i2c: iproc: make 'interrupts' optional >> >> Rayagonda Kokatanur (5): >> i2c: iproc: add polling support >> i2c: iproc: use wrapper for read/write access >> dt-bindings: i2c: iproc: add "brcm,iproc-nic-i2c" compatible string >> i2c: iproc: add NIC I2C support >> arm64: dts: Stingray: Add NIC i2c device node >> >> Shreesha Rajashekar (2): >> i2c: iproc: Extend I2C read up to 255 bytes >> i2c: iproc: Add slave mode support >> >> .../bindings/i2c/brcm,iproc-i2c.txt | 17 +- >> .../boot/dts/broadcom/stingray/stingray.dtsi | 18 + >> drivers/i2c/busses/Kconfig | 1 + >> drivers/i2c/busses/i2c-bcm-iproc.c | 758 +++++++++++++++--- >> 4 files changed, 663 insertions(+), 131 deletions(-) >>
On Thu, Feb 14, 2019 at 09:57:17AM -0800, Ray Jui wrote: > This patch series adds the following support to the iProc I2C driver: > - Increase maximum read transfer size to 255 bytes > - I2C slave mode > - Polling mode > - NIC I2C mode > > This patch series is based on kernel v5.0-rc3 and available at: > https://github.com/Broadcom/arm64-linux.git So, I had a high level look at these patches and made a few comments. For the details, I trust you (being the maintainer :))
On 3/27/2019 3:27 PM, Wolfram Sang wrote: > On Thu, Feb 14, 2019 at 09:57:17AM -0800, Ray Jui wrote: >> This patch series adds the following support to the iProc I2C driver: >> - Increase maximum read transfer size to 255 bytes >> - I2C slave mode >> - Polling mode >> - NIC I2C mode >> >> This patch series is based on kernel v5.0-rc3 and available at: >> https://github.com/Broadcom/arm64-linux.git > > So, I had a high level look at these patches and made a few comments. For > the details, I trust you (being the maintainer :)) > Thanks for the feedback, Wolfram. We'll reply and address your comments. Ray