[v2,0/4] Adding scale support to the lpc32xx ADC driver

Message

Gregory CLEMENT March 15, 2019, 9:52 a.m. UTC

Hello,

This is the second version of a series adding the support of the scale
feature to the lpc32xx ADC driver. In order to use it we need to have
the voltage reference as a device tree property, however in order to
be backward compatible, this property is optional and do not prevent
to use the driver if missing.

I updated the binding documentation accordingly.

Gregory

Changelog:
v1 -> v2:

 - "dt-bindings: iio: adc: move lpc32xx-adc out of staging" and
   "iio:adc:lpc32xx use SPDX-License-Identifier" has been merged

 - split "iio:adc:lpc32xx use SPDX-License-Identifier" in 2 patches
   one foe sorting and the second one for removal

 - add reviewed-by from Rob Herring on the binding documentation patch

 - add default in the switch/case in lpc32xx_read_raw()

 - no more use scan_type.realbits and directly put the value in the
   IIO_CHAN_INFO_SCALE case

 - keep the const for the struct iio_chan_spec and declare 2 of them.

 - remove the unrelated and bad whitespace change.

Gregory CLEMENT (4):
  iio: adc: lpc32xx: Sort headers
  iio: adc: lpc32xx: Cleanup headers
  iio: adc: lpc32xx: Add scale feature
  dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply

 .../bindings/iio/adc/lpc32xx-adc.txt          |  5 ++
 drivers/iio/adc/lpc32xx_adc.c                 | 59 +++++++++++++------
 2 files changed, 47 insertions(+), 17 deletions(-)

Comments

Jonathan Cameron March 16, 2019, 5:16 p.m. UTC | #1

On Fri, 15 Mar 2019 10:52:27 +0100
Gregory CLEMENT <[e-mail]> wrote:

> Hello,
> 
> This is the second version of a series adding the support of the scale
> feature to the lpc32xx ADC driver. In order to use it we need to have
> the voltage reference as a device tree property, however in order to
> be backward compatible, this property is optional and do not prevent
> to use the driver if missing.
> 
> I updated the binding documentation accordingly.
> 
> Gregory
> 
> Changelog:
> v1 -> v2:
> 
>  - "dt-bindings: iio: adc: move lpc32xx-adc out of staging" and
>    "iio:adc:lpc32xx use SPDX-License-Identifier" has been merged
> 
>  - split "iio:adc:lpc32xx use SPDX-License-Identifier" in 2 patches
>    one foe sorting and the second one for removal
Hohum. I'm reviewing cover letters now. Must have too much time on 
my hands ;)

This is talking about the wrong patch.

> 
>  - add reviewed-by from Rob Herring on the binding documentation patch
> 
>  - add default in the switch/case in lpc32xx_read_raw()
> 
>  - no more use scan_type.realbits and directly put the value in the
>    IIO_CHAN_INFO_SCALE case
> 
>  - keep the const for the struct iio_chan_spec and declare 2 of them.
> 
>  - remove the unrelated and bad whitespace change.
> 
> Gregory CLEMENT (4):
>   iio: adc: lpc32xx: Sort headers
>   iio: adc: lpc32xx: Cleanup headers
>   iio: adc: lpc32xx: Add scale feature
>   dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply
> 
>  .../bindings/iio/adc/lpc32xx-adc.txt          |  5 ++
>  drivers/iio/adc/lpc32xx_adc.c                 | 59 +++++++++++++------
>  2 files changed, 47 insertions(+), 17 deletions(-)
>