| Message ID | 20190813170149.26037-1-will@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix issues with 52-bit kernel virtual addressing | expand |
On Tue, Aug 13, 2019 at 06:01:41PM +0100, Will Deacon wrote: > Hi all, > > This patch series addresses some issues with 52-bit kernel VAs reported > by Qian Cai and Geert. It's all confined to asm/memory.h and I got a bit > carried away cleaning that thing up so the patches get more worthless > as you go through the series. Still, I'd like to queue this on top of > the 52-bit VA stuff currently sitting in -next. > > Although Geert and Steve tested my initial hacks, I dropped the tags > because I've split things up and could've easily broken things again. > > Cheers, > > Will > A really big thank you for this Will! and apologies again for missing these things in testing. I've applied this series to for-next/52-bit-kva and tested using 52-bit VAs with SW TAGS with DEBUG_VIRTUAL and DEBUG_VM, so please feel free to add: Tested-by: Steve Capper <steve.capper@arm.com> Cheers,
Hi Will, On Tue, Aug 13, 2019 at 7:01 PM Will Deacon <will@kernel.org> wrote: > This patch series addresses some issues with 52-bit kernel VAs reported > by Qian Cai and Geert. It's all confined to asm/memory.h and I got a bit > carried away cleaning that thing up so the patches get more worthless > as you go through the series. Still, I'd like to queue this on top of > the 52-bit VA stuff currently sitting in -next. > > Although Geert and Steve tested my initial hacks, I dropped the tags > because I've split things up and could've easily broken things again. Thanks, this fixes the problem I was seeing, so Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> > Will Deacon (8): > arm64: memory: Fix virt_addr_valid() using __is_lm_address() > arm64: memory: Ensure address tag is masked in conversion macros > arm64: memory: Rewrite default page_to_virt()/virt_to_page() > arm64: memory: Simplify virt_to_page() implementation > arm64: memory: Simplify _VA_START and _PAGE_OFFSET definitions > arm64: memory: Implement __tag_set() as common function > arm64: memory: Add comments to end of non-trivial #ifdef blocks > arm64: memory: Cosmetic cleanups > > arch/arm64/include/asm/memory.h | 89 ++++++++++++++++++++--------------------- > 1 file changed, 44 insertions(+), 45 deletions(-) Gr{oetje,eeting}s, Geert
On Tue, Aug 13, 2019 at 06:01:41PM +0100, Will Deacon wrote: > Hi all, > > This patch series addresses some issues with 52-bit kernel VAs reported > by Qian Cai and Geert. It's all confined to asm/memory.h and I got a bit > carried away cleaning that thing up so the patches get more worthless > as you go through the series. Still, I'd like to queue this on top of > the 52-bit VA stuff currently sitting in -next. > > Although Geert and Steve tested my initial hacks, I dropped the tags > because I've split things up and could've easily broken things again. > > Cheers, > > Will > > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Steve Capper <steve.capper@arm.com> > Cc: Qian Cai <cai@lca.pw> > Cc: Andrey Konovalov <andreyknvl@google.com> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> Other than the comments I've made, for the series: Reviewed-by: Mark Rutland <mark.rutland@arm.com> If you want, I can spin a fix / cleanup for the VA_START issues I mentioned atop of this series. Thanks, Mark. > > --->8 > > Will Deacon (8): > arm64: memory: Fix virt_addr_valid() using __is_lm_address() > arm64: memory: Ensure address tag is masked in conversion macros > arm64: memory: Rewrite default page_to_virt()/virt_to_page() > arm64: memory: Simplify virt_to_page() implementation > arm64: memory: Simplify _VA_START and _PAGE_OFFSET definitions > arm64: memory: Implement __tag_set() as common function > arm64: memory: Add comments to end of non-trivial #ifdef blocks > arm64: memory: Cosmetic cleanups > > arch/arm64/include/asm/memory.h | 89 ++++++++++++++++++++--------------------- > 1 file changed, 44 insertions(+), 45 deletions(-) > > -- > 2.11.0 >