From patchwork Mon Nov 4 00:18:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 11224797 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6EBED1515 for ; Mon, 4 Nov 2019 00:18:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 472B221D71 for ; Mon, 4 Nov 2019 00:18:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lSdi3Q69"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="PnxPhNy4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 472B221D71 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alliedtelesis.co.nz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+PV/UCh2p6U4IormdjYL9z+uKR+3m/TYJoqj7cDKC5I=; b=lSdi3Q69oJEFUs 2szAZGwW2qomvUWWt0qU3blIbQ/A7geqGypm6JLLSFMNPVK21kQjfT+Y5hhg5GbhsHECaV7TkKjSD 6AGhylBwKAA1QTOJDC4LTAGHFGyHkvIERmiJBj8ewArtpz+HrJStn0zhbVxR39OFM9i9j6k9TNrcg fQ2Io/IUafGapzASFjxHg9qFgFsEaaFmO8NahXemBbGcTICoCKyl2ug0CBoi7PpH9BXtMOJ8M0Y8H Yqr3/xxrmdNs896S8QwqYjrfFY1Q5Kw+cgnaE9CQ386im9wKV0b99hxOllee/Fv0SZL1noYuIxRLv 9eFoDkQftylZeI5BJL0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRQ55-0000yb-4V; Mon, 04 Nov 2019 00:18:51 +0000 Received: from gate2.alliedtelesis.co.nz ([2001:df5:b000:5::4]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRQ51-0000uL-35 for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 00:18:48 +0000 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id A89738365A; Mon, 4 Nov 2019 13:18:22 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1572826702; bh=HiEdNYNi8oKqRVwMtkU4iyatNl5LZzujdzu2zDPjPIc=; h=From:To:Cc:Subject:Date; b=PnxPhNy4SsDGLht5Cy52+X6zSxg/blzoA8ivVURqj7leEM+4aqUIia1JlBHPs4cNS 1gqJYofHnPtf9YxpSZoTnS65EiK56Eav2fXm6tqE7+th3kxGOl7YwRKoXOIiErHCEW yOsRXPzbXN3TilfUc6tSzQeFXuEWfzydkpo1N93hXAKAsCocOHsp0CuO14jLpV+cOr bAvymnCfRnHcLd9cVtG8bIm5W6hwYpUsJZwbjKhAb5Y1jhOY+goA4v7GdrAdM8EEpC BOmN759CRGY1PjrPiYGQk1AB96fuTSSfr+H62gbrmz3a2kV97WbsLKts01CqNczNRY 9qobjxascWe9A== Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 8, 10121) id ; Mon, 04 Nov 2019 13:18:21 +1300 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.20]) by smtp (Postfix) with ESMTP id 2E1FC13EED4; Mon, 4 Nov 2019 13:18:18 +1300 (NZDT) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 51A1C28005D; Mon, 4 Nov 2019 13:18:19 +1300 (NZDT) From: Chris Packham To: linus.walleij@linaro.org, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com Subject: [PATCH v3 0/2] pinctrl: bcm: nsp: gpio improvements Date: Mon, 4 Nov 2019 13:18:17 +1300 Message-Id: <20191104001819.2300-1-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 x-atlnz-ls: pat X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191103_161847_313270_E0DA2418 X-CRM114-Status: GOOD ( 10.47 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, Chris Packham , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org I'm working on a platform using the BCM 58525 SoC. I noticed that some of the peripherals were being deferred (not that that's a problem) and debugfs was complaining "File ':axi@18000000:gpio@20' in directory 'domains' already present!" which is more of a sign that things were not right. The debugfs error was because the manually created irq domain was not cleaned up on failure (or deferral). I've dropped the patch from this series that changes the order in the device tree. I can probably live with the deferrals. While I was debugging another issue I noticed my gpio-hogs weren't showing up correctly in /sys/kernel/debug/gpio. At first I thought I was missing commit d95da993383c ("gpiolib: Preserve desc->flags when setting state") but as it turns out pinctrl-nsp-gpio.c didn't provide a get_direction function so the generic code assumed they all started as inputs. I've added a new patch to address that. Chris Packham (2): pinctrl: bcm: nsp: use gpiolib infrastructure for interrupts pinctrl: bcm: nsp: implement get_direction drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 119 ++++++++++++------------- 1 file changed, 56 insertions(+), 63 deletions(-)