From patchwork Fri Nov 8 10:59:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 11234565 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 879AE1575 for ; Fri, 8 Nov 2019 10:59:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60055218AE for ; Fri, 8 Nov 2019 10:59:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iIfl19HI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60055218AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5HqThZjwO5XmyuM31HNjpl5ECZGaWYDVrQb/VOgaizA=; b=iIfl19HIT0yqae 9g/H4rPgxG+ACzrClGoLFjjJB1kduYAzbqQi5gMs5royQb8t13WJ6qJGdSuCZcXWYAJ4Rl86UVqni k3hqQhIbKnsrIglHLBeUmj9VVX0GBb8LhZrvdfFJRFd0VXbrKHW2Yms2+hTfav5JM/J6ePmamKTZD kASle1yag0wUt97FaVPL/kWNTOS6Sdjb9m2gNali/HSH5tboRLPDw7eJFE3aPizZxTGDw+10VA645 fBiGAp+Mv1TK/LaW0WDHnXjl4Z+4bMYMYyGbn6lU22lMTggFe4P6xexsj5WXw+tiprY9hEAoKnj29 Fi00f6LWIRrVIPMra/Xg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT1zM-0005IV-Kp; Fri, 08 Nov 2019 10:59:36 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT1zJ-0005Fi-LW for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2019 10:59:35 +0000 X-Originating-IP: 86.206.246.123 Received: from localhost.localdomain (lfbn-tou-1-421-123.w86-206.abo.wanadoo.fr [86.206.246.123]) (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B4E54E000F; Fri, 8 Nov 2019 10:59:23 +0000 (UTC) From: Miquel Raynal To: Mark Brown , Michal Simek , Naga Sureshkumar Relli Subject: [PATCH 0/7] spi: zynq-qspi: Clarify and fix the chip selection Date: Fri, 8 Nov 2019 11:59:13 +0100 Message-Id: <20191108105920.19014-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_025933_881099_CE698FFC X-CRM114-Status: UNSURE ( 7.62 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.196 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.196 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miquel Raynal , Tudor Ambarus , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hello, While working on SPI-NOR support I figured the chip select handling of the Zynq 7000 QSPI driver was not behaving as I would have expected. While cheking out what was wrong I decided to clarify things around so I did a bit of cleaning. The step-by-step changes are the reason for patches [1-6]. This way, the last patch actually adding support for both CS is much more understandable. Thanks, Miquèl Miquel Raynal (7): spi: zynq-qspi: Anything else than CS0 is not supported yet spi: zynq-qspi: Keep the naming consistent across the driver spi: zynq-qspi: Keep the bitfields naming consistent spi: zynq-qspi: Enhance the Linear CFG bit definitions spi: zynq-qspi: Clarify the select chip function spi: zynq-qspi: Do the actual hardware initialization later in the probe spi: zynq-qspi: Support two chip selects drivers/spi/spi-zynq-qspi.c | 84 ++++++++++++++++++++++--------------- 1 file changed, 51 insertions(+), 33 deletions(-)