mbox series

[net,v2,0/4] net: stmmac: general fixes for Ethernet functionality

Message ID 20200115071003.42820-1-boon.leong.ong@intel.com (mailing list archive)
Headers show
Series net: stmmac: general fixes for Ethernet functionality | expand

Message

Ong Boon Leong Jan. 15, 2020, 7:09 a.m. UTC 
Thanks to all feedbacks from community.

We updated the patch-series to below:-

1/4: It ensures that the real_num_rx|tx_queues are set in both driver
     probe() and resume(). So, move the netif_set_real_num_rx|tx_queues()
     into stmmac_hw_setup().

2/4: It ensures that the previous value of GMAC_VLAN_TAG register is
     read first before for updating the register.

3/4: It ensures the GMAC IP v4.xx and above behaves correctly to:-
       ip link set <devname> multicast off|on

4/4: It ensures PCI platform data is using plat->phy_interface.

Rgds,
Boon Leong

Changes from v1:-
 - Drop v1 patches (1/7, 3/7 & 4/7) that are not valid.

Aashish Verma (1):
  net: stmmac: Fix incorrect location to set real_num_rx|tx_queues

Tan, Tee Min (1):
  net: stmmac: fix incorrect GMAC_VLAN_TAG register writting
    implementation

Verma, Aashish (1):
  net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter

Voon Weifeng (1):
  net: stmmac: update pci platform data to use phy_interface

 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c |  9 +++++----
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |  8 ++++----
 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c  | 14 ++++++++------
 3 files changed, 17 insertions(+), 14 deletions(-)

Comments

Jose Abreu Jan. 16, 2020, 8:30 a.m. UTC | #1 
From: Ong Boon Leong <boon.leong.ong@intel.com>
Date: Jan/15/2020, 07:09:59 (UTC+00:00)

> 2/4: It ensures that the previous value of GMAC_VLAN_TAG register is
>      read first before for updating the register.
> 
> 3/4: It ensures the GMAC IP v4.xx and above behaves correctly to:-
>        ip link set <devname> multicast off|on

Can we please also get these fixes in XGMAC core ? The code base is very 
similar so it should be pretty straight forward.

---
Thanks,
Jose Miguel Abreu