| Message ID | 20200223131435.681620-1-megous@megous.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for charger LED for AXP813 and TBS A711 Tablet | expand |
On Sun, Feb 23, 2020 at 02:14:31PM +0100, megous hlavni wrote: > The tablet has a charger LED exposed on the top. This LED is controlled > by AXP813 PMIC. Add support for enabling the LED and using it either > for charging indication (handled by PMIC automatically) or for other uses > via user control. Dang, I just noticed someone sent a similar driver recently, although I had this one prepared for quite some time (since 2017) in my tree. I guess I should have sent it earlier. Please ignore. regards, o. > Please take a look. > > thank you and regards, > Ondrej Jirman > > Ondrej Jirman (4): > dt-bindings: leds: Add a binding for AXP813 charger led > leds: axp20x: Support charger LED on AXP20x like PMICs > ARM: dts: axp813: Add charger LED > ARM: dts: sun8i-a83t-tbs-a711: Enable charging LED > > .../devicetree/bindings/leds/leds-axp20x.yaml | 24 ++ > arch/arm/boot/dts/axp81x.dtsi | 5 + > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 + > drivers/leds/Kconfig | 7 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-axp20x.c | 240 ++++++++++++++++++ > drivers/mfd/axp20x.c | 3 + > 7 files changed, 284 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml > create mode 100644 drivers/leds/leds-axp20x.c > > -- > 2.25.1 >
On Sun, Feb 23, 2020 at 02:27:30PM +0100, megous hlavni wrote: > On Sun, Feb 23, 2020 at 02:14:31PM +0100, megous hlavni wrote: > > The tablet has a charger LED exposed on the top. This LED is controlled > > by AXP813 PMIC. Add support for enabling the LED and using it either > > for charging indication (handled by PMIC automatically) or for other uses > > via user control. > > Dang, I just noticed someone sent a similar driver recently, although I had this > one prepared for quite some time (since 2017) in my tree. I guess I should have > sent it earlier. > > Please ignore. Though the meaning of "recently" is a bit relative. The other work was sent in a year ago. Here's a reference: https://lore.kernel.org/patchwork/cover/1042764/ > regards, > o. > > > > Please take a look. > > > > thank you and regards, > > Ondrej Jirman > > > > Ondrej Jirman (4): > > dt-bindings: leds: Add a binding for AXP813 charger led > > leds: axp20x: Support charger LED on AXP20x like PMICs > > ARM: dts: axp813: Add charger LED > > ARM: dts: sun8i-a83t-tbs-a711: Enable charging LED > > > > .../devicetree/bindings/leds/leds-axp20x.yaml | 24 ++ > > arch/arm/boot/dts/axp81x.dtsi | 5 + > > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 + > > drivers/leds/Kconfig | 7 + > > drivers/leds/Makefile | 1 + > > drivers/leds/leds-axp20x.c | 240 ++++++++++++++++++ > > drivers/mfd/axp20x.c | 3 + > > 7 files changed, 284 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml > > create mode 100644 drivers/leds/leds-axp20x.c > > > > -- > > 2.25.1 > >
On 2/23/20 3:35 PM, Ondřej Jirman wrote: > On Sun, Feb 23, 2020 at 02:27:30PM +0100, megous hlavni wrote: >> On Sun, Feb 23, 2020 at 02:14:31PM +0100, megous hlavni wrote: >>> The tablet has a charger LED exposed on the top. This LED is controlled >>> by AXP813 PMIC. Add support for enabling the LED and using it either >>> for charging indication (handled by PMIC automatically) or for other uses >>> via user control. >> Dang, I just noticed someone sent a similar driver recently, although I had this >> one prepared for quite some time (since 2017) in my tree. I guess I should have >> sent it earlier. >> >> Please ignore. > Though the meaning of "recently" is a bit relative. The other work was sent in > a year ago. Here's a reference: > > https://lore.kernel.org/patchwork/cover/1042764/ Hi, I'm the author of the 'other' work. I don't know the full story here, but I don't mind someone else submitting this patch as his. When I submitted the last patch, there was the proposal to use the ledtrig-pattern instead of sysfs entries. Also AXP209 has inverted CTRL bit. Please read the the 'other' discussion. Best regards, Stefan Mavrodiev > >> regards, >> o. >> >> >>> Please take a look. >>> >>> thank you and regards, >>> Ondrej Jirman >>> >>> Ondrej Jirman (4): >>> dt-bindings: leds: Add a binding for AXP813 charger led >>> leds: axp20x: Support charger LED on AXP20x like PMICs >>> ARM: dts: axp813: Add charger LED >>> ARM: dts: sun8i-a83t-tbs-a711: Enable charging LED >>> >>> .../devicetree/bindings/leds/leds-axp20x.yaml | 24 ++ >>> arch/arm/boot/dts/axp81x.dtsi | 5 + >>> arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 + >>> drivers/leds/Kconfig | 7 + >>> drivers/leds/Makefile | 1 + >>> drivers/leds/leds-axp20x.c | 240 ++++++++++++++++++ >>> drivers/mfd/axp20x.c | 3 + >>> 7 files changed, 284 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml >>> create mode 100644 drivers/leds/leds-axp20x.c >>> >>> -- >>> 2.25.1 >>>
On Mon, Feb 24, 2020 at 08:31:06AM +0200, Stefan Mavrodiev wrote: > > On 2/23/20 3:35 PM, Ondřej Jirman wrote: > > On Sun, Feb 23, 2020 at 02:27:30PM +0100, megous hlavni wrote: > > > On Sun, Feb 23, 2020 at 02:14:31PM +0100, megous hlavni wrote: > > > > The tablet has a charger LED exposed on the top. This LED is controlled > > > > by AXP813 PMIC. Add support for enabling the LED and using it either > > > > for charging indication (handled by PMIC automatically) or for other uses > > > > via user control. > > > Dang, I just noticed someone sent a similar driver recently, although I had this > > > one prepared for quite some time (since 2017) in my tree. I guess I should have > > > sent it earlier. > > > > > > Please ignore. > > Though the meaning of "recently" is a bit relative. The other work was sent in > > a year ago. Here's a reference: > > > > https://lore.kernel.org/patchwork/cover/1042764/ > > Hi, > > I'm the author of the 'other' work. I don't know the full story here, but I > don't > mind someone else submitting this patch as his. Hello Stefan, There's really no story. Just me being a bit anoyed at myself, for not checking the mailing lists prior to spending some time cleaning up and extending some old patches to upstream them, and wasting quite a bit of time in the process. https://megous.com/git/linux/commit/?h=linux-tbs&id=737eec64565d328cab98b75879e3f9eb1cf2f609 > When I submitted the last patch, there was the proposal to use the > ledtrig-pattern instead > of sysfs entries. Also AXP209 has inverted CTRL bit. > > Please read the the 'other' discussion. Thanks, I'll check it out. regards, o. > Best regards, > Stefan Mavrodiev > > > > > > regards, > > > o. > > > > > > > > > > Please take a look. > > > > > > > > thank you and regards, > > > > Ondrej Jirman > > > > > > > > Ondrej Jirman (4): > > > > dt-bindings: leds: Add a binding for AXP813 charger led > > > > leds: axp20x: Support charger LED on AXP20x like PMICs > > > > ARM: dts: axp813: Add charger LED > > > > ARM: dts: sun8i-a83t-tbs-a711: Enable charging LED > > > > > > > > .../devicetree/bindings/leds/leds-axp20x.yaml | 24 ++ > > > > arch/arm/boot/dts/axp81x.dtsi | 5 + > > > > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 + > > > > drivers/leds/Kconfig | 7 + > > > > drivers/leds/Makefile | 1 + > > > > drivers/leds/leds-axp20x.c | 240 ++++++++++++++++++ > > > > drivers/mfd/axp20x.c | 3 + > > > > 7 files changed, 284 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml > > > > create mode 100644 drivers/leds/leds-axp20x.c > > > > > > > > -- > > > > 2.25.1 > > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel